Bug 277951 - graphics/zathura: Update to 0.5.4
Summary: graphics/zathura: Update to 0.5.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://pwmt.org/news/category/zathur...
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2024-03-25 15:04 UTC by mew14930xvi
Modified: 2024-04-11 06:21 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (quentin.stievenart)


Attachments
Update to 0.5.4 (3.25 KB, patch)
2024-03-25 15:04 UTC, mew14930xvi
no flags Details | Diff
update to 0.5.4 (3.60 KB, patch)
2024-04-06 00:17 UTC, mew14930xvi
no flags Details | Diff
fix BUILD_DEPENDS (3.51 KB, patch)
2024-04-06 17:40 UTC, mew14930xvi
no flags Details | Diff
Update to 0.5.4 (4.52 KB, patch)
2024-04-06 19:24 UTC, mew14930xvi
no flags Details | Diff
Update to 0.5.4 (4.51 KB, patch)
2024-04-06 22:44 UTC, mew14930xvi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mew14930xvi 2024-03-25 15:04:43 UTC
Created attachment 249477 [details]
Update to 0.5.4

Update to 0.5.4.
Comment 1 quentin.stievenart 2024-04-01 12:49:35 UTC
Why are the PORTREVISION bumped for related packages? It doesn't look necessary to me.

Otherwise, the patch looks good.
Comment 2 mew14930xvi 2024-04-01 13:18:48 UTC
It does not work with an error.
The build of the plugin depends on zathura.

error: Could not find 'zathura_plugin_5_6' in plugin /usr/local/lib/zathura/libdjvu.so - is not a plugin or needs to be rebuilt.
error: Could not find 'zathura_plugin_5_6' in plugin /usr/local/lib/zathura/libcb.so - is not a plugin or needs to be rebuilt.
error: Could not find 'zathura_plugin_5_6' in plugin /usr/local/lib/zathura/libpdf-poppler.so - is not a plugin or needs to be rebuilt.
error: Could not find 'zathura_plugin_5_6' in plugin /usr/local/lib/zathura/libpdf-mupdf.so - is not a plugin or needs to be rebuilt.
error: Could not find 'zathura_plugin_5_6' in plugin /usr/local/lib/zathura/libps.so - is not a plugin or needs to be rebuilt.
Comment 3 mew14930xvi 2024-04-01 20:53:53 UTC
$ grep -A1 ^plugin_api_version zathura-0.5.2/meson.build
plugin_api_version = '4'
plugin_abi_version = '5'

$ grep -A1 ^plugin_api_version zathura-0.5.4/meson.build
plugin_api_version = '5'
plugin_abi_version = '6'

The plugin needs to be rebuilt and reinstalled, so PORTREVISION will be bumped.
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2024-04-03 07:10:52 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field."
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2024-04-04 07:11:57 UTC
This fails for me with:

Run-time dependency gmodule-no-export-2.0 found: YES 2.80.0                                                                                                                        
Run-time dependency gtk+-3.0 found: YES 3.24.41                                                                                                                                    
Did not find CMake 'cmake'                                                                                                                                                         
Found CMake: NO
Run-time dependency json-glib-1.0 found: NO (tried pkgconfig)

meson.build:44:12: ERROR: Dependency "json-glib-1.0" not found, tried pkgconfig

A full log can be found at /wrkdirs/usr/ports/graphics/zathura/work/zathura-0.5.4/_build/meson-logs/meson-log.txt
WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]` is ambiguous and deprecated.
===>  Script "configure" failed unexpectedly.
Please report the problem to quentin.stievenart@gmail.com [maintainer] and
attach the
"/wrkdirs/usr/ports/graphics/zathura/work/zathura-0.5.4/_build/meson-logs/meson-log.txt"
including the output of the failure of your make command. Also, it might be
a good idea to provide an overview of all packages installed on your system
(e.g. a /usr/local/sbin/pkg-static info -g -Ea).
*** Error code 1

Stop.
make: stopped in /usr/ports/graphics/zathura 

It looks like devel/json-glib is needed as a dependency.

Can you have a look?
Comment 6 mew14930xvi 2024-04-06 00:17:42 UTC
Created attachment 249747 [details]
update to 0.5.4

update to 0.5.4
change BUILD_DEPENDS, LIB_DEPENDS, USE_GNOME
Comment 7 mew14930xvi 2024-04-06 17:40:04 UTC
Created attachment 249767 [details]
fix BUILD_DEPENDS
Comment 8 mew14930xvi 2024-04-06 17:54:06 UTC
(In reply to Fernando Apesteguía from comment #5)

Fixed Makefile.
Comment 9 mew14930xvi 2024-04-06 19:24:04 UTC
Created attachment 249773 [details]
Update to 0.5.4

OPTIONS: add MANPAGES
Comment 10 mew14930xvi 2024-04-06 22:44:05 UTC
Created attachment 249779 [details]
Update to 0.5.4

Fix BUILD_DEPENDS
Comment 11 Fernando Apesteguía freebsd_committer freebsd_triage 2024-04-11 06:21:29 UTC
Committed,

Thanks!
Comment 12 commit-hook freebsd_committer freebsd_triage 2024-04-11 06:21:45 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=de230a17731a69a7e13172472729f0e002227e5e

commit de230a17731a69a7e13172472729f0e002227e5e
Author:     mew14930xvi <mew14930xvi@inbox.lv>
AuthorDate: 2024-04-07 17:39:23 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2024-04-11 06:20:56 +0000

    graphics/zathura: Update to 0.5.4

    ChangeLog: https://pwmt.org/news/category/zathura/index.html

    PR:             277951
    Reported by:    mew14930xvi@inbox.lv
    Approved by:    quentin.stievenart@gmail.com (maintainer)

 graphics/zathura-cb/Makefile          |  2 +-
 graphics/zathura-djvu/Makefile        |  2 +-
 graphics/zathura-pdf-mupdf/Makefile   |  2 +-
 graphics/zathura-pdf-poppler/Makefile |  2 +-
 graphics/zathura-ps/Makefile          |  2 +-
 graphics/zathura/Makefile             | 23 ++++++++++++-----------
 graphics/zathura/distinfo             |  6 +++---
 graphics/zathura/pkg-plist            |  4 ++--
 8 files changed, 22 insertions(+), 21 deletions(-)