I'll try to find time and create patch.
Hi Vladimir, Thanks for the heads-up, I did a quick try and rsync-3.3.0 didn't break the existing build mechanism, but of course additional tests are required to ensure we are not break anything. The changes are really trivial so I attach the patch feel free to compile it and do any test you find relevant. All the best -- rodrigo
Created attachment 249780 [details] rsync-3.3.0
I created patch too - identically with your! :-D Tested build in poudriere 13.2, 13.3, i386, amd64 and on live system 13.3 amd64 - all OK. Not tested 14.0, main and on non-x86 arches. And not tested all combinations of options.
Can I commit? Or do you prefer to do it yourself?
(In reply to Vladimir Druzenko from comment #4) For this port specifically, I prefer to do it my self. Cheers, -- rodrigo
ping
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8002d6300ed5100232524a701ee00b3a00540b20 commit 8002d6300ed5100232524a701ee00b3a00540b20 Author: Rodrigo Osorio <rodrigo@FreeBSD.org> AuthorDate: 2024-04-09 06:51:00 +0000 Commit: Rodrigo Osorio <rodrigo@FreeBSD.org> CommitDate: 2024-04-27 16:42:24 +0000 net/rsync: upgrade to 3.3.0 Full changelog: https://download.samba.org/pub/rsync/NEWS#3.3.0 Major changes: * Several bugfixes around -sparse --inplace, buffer overflow in the checksum2, string-comparison issue in the internal handling of --progress, ensure local transfer marks the sender side as trusted, changes the argv handling to work with a newer popt library, a problem in the daemon auth for older protocols, old stats bug that counted devices as symlinks * Many enhancements: rrsync with the -no-overwrite option, manpages formating, mapfrom & mapto perl scripts into a single python script, mnt-excl perl script into a python script PR: 278208 Reported by: vvd net/rsync/Makefile | 3 +-- net/rsync/distinfo | 10 +++++----- 2 files changed, 6 insertions(+), 7 deletions(-)
Committed, thanks. Sorry for the delay, I was a little busy the last weeks
> buffer overflow in the checksum2 MFH 2024Q2?
(In reply to Vladimir Druzenko from comment #9) makes sense. Thanks for the heads-up :)
A commit in branch 2024Q2 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=5a12756b044c150486e29460e896d8e7ef3139a2 commit 5a12756b044c150486e29460e896d8e7ef3139a2 Author: Rodrigo Osorio <rodrigo@FreeBSD.org> AuthorDate: 2024-04-09 06:51:00 +0000 Commit: Rodrigo Osorio <rodrigo@FreeBSD.org> CommitDate: 2024-04-27 19:37:01 +0000 net/rsync: upgrade to 3.3.0 Full changelog: https://download.samba.org/pub/rsync/NEWS#3.3.0 Major changes: * Several bugfixes around -sparse --inplace, buffer overflow in the checksum2, string-comparison issue in the internal handling of --progress, ensure local transfer marks the sender side as trusted, changes the argv handling to work with a newer popt library, a problem in the daemon auth for older protocols, old stats bug that counted devices as symlinks * Many enhancements: rrsync with the -no-overwrite option, manpages formating, mapfrom & mapto perl scripts into a single python script, mnt-excl perl script into a python script PR: 278208 Reported by: vvd (cherry picked from commit 8002d6300ed5100232524a701ee00b3a00540b20) net/rsync/Makefile | 3 +-- net/rsync/distinfo | 10 +++++----- 2 files changed, 6 insertions(+), 7 deletions(-)