Bug 278324 - [exp-run] Mk/ autodeps
Summary: [exp-run] Mk/ autodeps
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL: https://reviews.freebsd.org/D43619
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-12 08:32 UTC by Baptiste Daroussin
Modified: 2024-04-18 12:22 UTC (History)
1 user (show)

See Also:
bapt: merge-quarterly?
bapt: exp-run?


Attachments
QA warnings about lib depends from a few days ago (zipped) (107.47 KB, application/octet-stream)
2024-04-16 11:16 UTC, Antoine Brodin
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Baptiste Daroussin freebsd_committer freebsd_triage 2024-04-12 08:32:32 UTC
Hello,

I would like to request an exp-run for this new autodeps feature where library based dependencies are now auto determined.
Comment 1 Baptiste Daroussin freebsd_committer freebsd_triage 2024-04-15 09:49:09 UTC
autodeps is correct, but make poudriere keeps "detecting new dependency because of a hue load of "wrong" dependencies
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-04-15 10:09:41 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2d80d8f4cc61d66f614154e9891c7b346e5fbd90

commit 2d80d8f4cc61d66f614154e9891c7b346e5fbd90
Author:     Baptiste Daroussin <bapt@FreeBSD.org>
AuthorDate: 2024-04-15 10:04:36 +0000
Commit:     Baptiste Daroussin <bapt@FreeBSD.org>
CommitDate: 2024-04-15 10:04:36 +0000

    devel/bison: fix wrong dependency on readline

    While the port claim a dependency on readline, it is actually never
    linked to it.

    While removing the dependency on readline encure via CONFIGURE_ENV
    that readline never gets picked by accident.

    Revealed by testing the new autodeps feature

    PR:     278324

 devel/bison/Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2024-04-15 12:46:47 UTC
Yes,  it seems a lot of committers don't look at QA warnings:

yelp-tools-42.0.log:Warning: you might not need LIB_DEPENDS on libintl.so
yelp-tools-42.0.log:Warning: you might not need LIB_DEPENDS on libxml2.so
yelp-tools-42.0.log:Warning: you might not need LIB_DEPENDS on libxslt.so
yelp-xsl-42.0.log:Warning: you might not need LIB_DEPENDS on libintl.so
yelp-xsl-42.0.log:Warning: you might not need LIB_DEPENDS on libxml2.so
yelp-xsl-42.0.log:Warning: you might not need LIB_DEPENDS on libxslt.so

more than 5000 ports have those warnings...
Comment 4 Emmanuel Vadot freebsd_committer freebsd_triage 2024-04-16 10:47:57 UTC
(In reply to Antoine Brodin from comment #3)

I wonder if we could run a testport on all ports like once a month after the bulk in the builder, and mail the result if there is any warning to the maintainer.
No idea if we can afford the resources.
Comment 5 Antoine Brodin freebsd_committer freebsd_triage 2024-04-16 11:16:31 UTC
Created attachment 250004 [details]
QA warnings about lib depends from a few days ago (zipped)

QA warnings about lib depends from a few days ago (zipped)
Comment 6 Baptiste Daroussin freebsd_committer freebsd_triage 2024-04-16 11:33:48 UTC
this reveals plenty of issues with the ports tree, which needs to be analysed and fixed.
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-04-18 12:22:51 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bed3b0ad509eca940c9a368658a69c9e6210cdec

commit bed3b0ad509eca940c9a368658a69c9e6210cdec
Author:     Emmanuel Vadot <manu@FreeBSD.org>
AuthorDate: 2024-04-18 08:45:46 +0000
Commit:     Emmanuel Vadot <manu@FreeBSD.org>
CommitDate: 2024-04-18 12:22:16 +0000

    graphics/libosmesa: Remove expat from LIB_DEPENDS

    It's not needed for this mesa component.

    Differential Revision:  https://reviews.freebsd.org/D44828
    PR:                     278324
    Reported by:            autodep
    Reviewed by:            bapt
    Sponsored by:           Beckhoff Automation GmbH & Co. KG

 graphics/libosmesa/Makefile       | 1 +
 graphics/mesa-dri/Makefile.common | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-04-18 12:22:52 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=171cdaf295e37c781f9a4999b05ea74da0bcd0f0

commit 171cdaf295e37c781f9a4999b05ea74da0bcd0f0
Author:     Emmanuel Vadot <manu@FreeBSD.org>
AuthorDate: 2024-04-18 08:54:08 +0000
Commit:     Emmanuel Vadot <manu@FreeBSD.org>
CommitDate: 2024-04-18 12:22:27 +0000

    graphics/mesa-libs: Fix LIB_DEPENDS

    Mesa itself does not depend on libOpenGL.so from libglvnd but it needs
    libglvnd at build stage.
    Also it doesn't not depend on libwayland-egl.so but on libwayland-server.so
    and libwayland-client.so

    Differential Revision:  https://reviews.freebsd.org/D44831
    PR:                     278324
    Reported by:            autodep
    Reviewed by:            bapt
    Sponsored by:           Beckhoff Automation GmbH & Co. KG

 graphics/mesa-libs/Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-04-18 12:22:54 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3119e2cc3528b6b9f710209fbc42da620cdb79c3

commit 3119e2cc3528b6b9f710209fbc42da620cdb79c3
Author:     Emmanuel Vadot <manu@FreeBSD.org>
AuthorDate: 2024-04-18 08:48:11 +0000
Commit:     Emmanuel Vadot <manu@FreeBSD.org>
CommitDate: 2024-04-18 12:22:21 +0000

    graphics/mesa-gallium-va: Remove libva from LIB_DEPENDS

    This port provides a lib for libva to use, not the other way
    around so add it to BUILD_DEPENDS

    Differential Revision:  https://reviews.freebsd.org/D44829
    PR:                     278324
    Reported by:            autodep
    Reviewed by:            bapt
    Sponsored by:           Beckhoff Automation GmbH & Co. KG

 graphics/mesa-gallium-va/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Comment 10 commit-hook freebsd_committer freebsd_triage 2024-04-18 12:22:56 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=803124df1222193ecb37afcd31e42cf2b95579f1

commit 803124df1222193ecb37afcd31e42cf2b95579f1
Author:     Emmanuel Vadot <manu@FreeBSD.org>
AuthorDate: 2024-04-18 08:49:05 +0000
Commit:     Emmanuel Vadot <manu@FreeBSD.org>
CommitDate: 2024-04-18 12:22:24 +0000

    graphics/mesa-gallium-vdpau: Remove libvdpau from LIB_DEPENDS

    This port provides a lib for libvdpau to use, not the other way
    around so add it to BUILD_DEPENDS

    Differential Revision:  https://reviews.freebsd.org/D44830
    PR:                     278324
    Reported by:            autodep
    Reviewed by:            bapt
    Sponsored by:           Beckhoff Automation GmbH & Co. KG

 graphics/mesa-gallium-vdpau/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)