Bug 278343 - x11/tint: Fix crashes caused by conky
Summary: x11/tint: Fix crashes caused by conky
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-13 08:49 UTC by yamagi
Modified: 2024-05-09 06:31 UTC (History)
1 user (show)

See Also:


Attachments
git patch with the update (1.61 KB, patch)
2024-04-13 08:49 UTC, yamagi
yamagi: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description yamagi 2024-04-13 08:49:03 UTC
Created attachment 249947 [details]
git patch with the update

Hi,

the attached patch integrates a band-aid fix into x11/tint which fixes crashes when conky is running on the the same X11 display. This might also help against other crashes, maybe #277541.

I'll see if I can update the port to the latest (and properly last) upstream version, which fixes a few more bugs. That will take a while, because it needs thorough testing and I don't have the time for that in the upcoming weeks.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2024-05-07 15:49:41 UTC
^Triage: [tags] in issue Titles are deprecated.

^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]

^Triage: Maintainer-feedback flag (+) not required unless requested (?) first.


Thanks!
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2024-05-08 06:49:57 UTC
Isn't this something we want in quarterly?
The bug you mention that might be resolved by this (#277541) was filed in March, before the creation of Q2.
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2024-05-09 06:31:14 UTC
Committed,

Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-05-09 06:31:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ef10d90ce399d295a7887173bd8ebbbd8f3cbe46

commit ef10d90ce399d295a7887173bd8ebbbd8f3cbe46
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2024-05-07 15:51:12 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2024-05-09 06:30:42 +0000

    x11/tint: Fix crashes caused by conky

    The attached patch integrates a band-aid fix into x11/tint which fixes crashes
    when conky is running on the the same X11 display

    PR:             278343
    Reported by:    yamagi@yamagi.org

 x11/tint/Makefile                     |  2 +-
 x11/tint/files/patch-src_main.c (new) | 12 ++++++++++++
 2 files changed, 13 insertions(+), 1 deletion(-)