Bug 278620 - x11-themes/flat-remix-icon-themes: Update to 20240201
Summary: x11-themes/flat-remix-icon-themes: Update to 20240201
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-27 19:24 UTC by Alexander Vereeken
Modified: 2024-05-23 15:03 UTC (History)
1 user (show)

See Also:

Attachments
0001-x11-themes-flat-remix-icon-themes-Update-to-20240201.patch.7z (927.98 KB, application/x-7z-compressed)
2024-04-27 19:34 UTC, Alexander Vereeken 		Alexander88207: maintainer-approval+
Details
0001-x11-themes-flat-remix-icon-themes-Update-to-20240201.patch.tar.gz (207.78 KB, application/gzip)
2024-05-22 16:17 UTC, Alexander Vereeken 		Alexander88207: maintainer-approval+
Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Vereeken 2024-04-27 19:24:34 UTC 
Hello,

this is an update to 20240201.

Changes: https://github.com/daniruiz/flat-remix/compare/20230622...20240201

Thank you in advance!
Comment 1 Alexander Vereeken 2024-04-27 19:34:33 UTC 
Created attachment 250272 [details]
0001-x11-themes-flat-remix-icon-themes-Update-to-20240201.patch.7z

Sorry, had to put it in an archive, the plist from the past was too big.

I have now added something there we plist gets created on the fly.
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2024-05-12 20:20:14 UTC 
Not a big fan of you circumventing the plist mechanism like this.

Please resubmit with your email address corrected and a proper plist.

Also please compress with xz, not 7z if possible.  xz is preinstalled on FreeBSD, 7z is not.
Comment 3 Alexander Vereeken 2024-05-22 16:17:11 UTC 
Created attachment 250876 [details]
0001-x11-themes-flat-remix-icon-themes-Update-to-20240201.patch.tar.gz

(In reply to Robert Clausecker from comment #2)

> Not a big fan of you circumventing the plist mechanism like this.

There should be just an policy of when autoplist is and isn't appropriate.
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2024-05-22 16:59:54 UTC 
(In reply to Alexander Vereeken from comment #3)

The policy is: unless there's a specific framework for it (as e.g. with Python and the PORTDOCS/PORTDATA stuff) we strongly prefer explicit pack lists.

Main exceptions include when the packlist contains random generated identifiers or when it's *really* large.  But these cases should be discussed on a case to case basis.  I'll go ahead and put your updated patch in my next batch.
Comment 5 Alexander Vereeken 2024-05-22 19:16:03 UTC 
(In reply to Robert Clausecker from comment #4)

Alright, thanks for the clarification and sorry for the circumstances.
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-05-23 14:57:53 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1ddee6844cc7d1c9c4dc6b5821ac3f4a491a2075

commit 1ddee6844cc7d1c9c4dc6b5821ac3f4a491a2075
Author:     Alexander Vereeken <Alexander88207@protonmail.com>
AuthorDate: 2024-05-22 16:11:37 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-05-23 14:56:49 +0000

    x11-themes/flat-remix-icon-themes: Update to 20240201

    Changes: https://github.com/daniruiz/flat-remix/compare/20230622...20240201

    PR:             278620
    Approved by:    Submitter is maintainer

 x11-themes/flat-remix-icon-themes/Makefile  |    2 +-
 x11-themes/flat-remix-icon-themes/distinfo  |    6 +-
 x11-themes/flat-remix-icon-themes/pkg-plist | 5692 +++++++++++++++++++++++++++
 3 files changed, 5696 insertions(+), 4 deletions(-)
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2024-05-23 15:03:04 UTC 
Thank you for your submission.