Bug 279214 - net-p2p/transmission-components: Get transmission-web back or add web option to transmission gtk
Summary: net-p2p/transmission-components: Get transmission-web back or add web option ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-22 07:28 UTC by Fernando Apesteguía
Modified: 2024-05-24 17:57 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (mondo.debater_0q)


Attachments
patch-transmission-web (9.30 KB, patch)
2024-05-22 19:32 UTC, Rafe
mondo.debater_0q: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fernando Apesteguía freebsd_committer freebsd_triage 2024-05-22 07:28:50 UTC
During the reorganization as a metaport in ac3e39992e95659a5193a15d4cb873efb00fcb30, we lost the transmission-web package.

The web option is now only available if we choose the daemon flavor in transmission-components. However this poses a problem: transmission-gtk is not only a frontend, but a client in itself. Before the reorganization, transmission-gtk and transmission-web provided a client able to download torrent files and two interfaces: gtk and web.

Now, the only way to have the web interface IIUC, is to install the daemon version. But the daemon version and the gtk version use different client parts so things downloading in the daemon are not seen in the gtk client and vice versa.

In addition, the gtk client has a nice feature that I can't find neither in the daemon, nor in the client. This is the ability to call a custom script for finished downloads.

So, could we please add the INSTALL_WEB option in the gtk client?
Comment 1 Rafe 2024-05-22 08:22:27 UTC
I think the proper way to fix this is to break out web as a new component as it was with a slave port. Otherwise, there would be overlap between the various component packages. 

My apologies for this, I made a poor assumption about who was using the web interface.
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2024-05-22 08:33:42 UTC
(In reply to Rafe from comment #1)
Hi Rafe,

Thanks for the quick response.

I did not caught this earlier because I have that setup in an old (14 years old) media center and that one gets updated only once in a while :-)

I think reintroducing transmission-web is a good option.
Do you want to provide a patch?
Comment 3 Anton Saietskii 2024-05-22 12:32:19 UTC
(In reply to Rafe from comment #1)

It may also be a good time to consider subpackages from review D40549 -- port can finally depend on 'itself' with this.
Comment 4 Anton Saietskii 2024-05-22 12:43:00 UTC
(In reply to Fernando Apesteguía from comment #0)

> In addition, the gtk client has a nice feature that I can't find
> neither in the daemon, nor in the client. This is the ability to
> call a custom script for finished downloads.
There is such feature in daemon indeed:
jason@jnb: [?:0] ~ $ sudo -u transmission sed -rn 's/ +("script.*)/\1/p' /usr/local/etc/transmission/settings.json
"script-torrent-added-enabled": false,
"script-torrent-added-filename": "",
"script-torrent-done-enabled": false,
"script-torrent-done-filename": "",
"script-torrent-done-seeding-enabled": false,
"script-torrent-done-seeding-filename": "",
jason@jnb: [?:0] ~ $

Additionally, while I understand that what I'm going to write next isn't the same as web GUI, I would still suggest net-p2p/tremotesf. If you want GUI -- likely you're accessing your daemon remotely, and tremotesf can do that (having Android version as well).
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2024-05-22 15:34:41 UTC
(In reply to Anton Saietskii from comment #4)
I don't know why I missed that. I read the documentation for the daemon and I remember having a look at the variables of the rc script too.

Still, the actual setup is broken: you can tell transmission-gtk to listen in the 9091 (the default) port, just to get a nasty 404 when trying to access the web interface.
Comment 6 Rafe 2024-05-22 19:32:39 UTC
Created attachment 250880 [details]
patch-transmission-web

Here is a patch separating out the web interface to a separate port. It builds clean. Let me know if you have any difficulties with it. 

Shifting to sub packages, while perhaps ideal, can be left for another day.
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2024-05-22 20:59:37 UTC
(In reply to Rafe from comment #6)
Thanks, I'll try and have a look at it tomorrow.
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2024-05-22 21:00:47 UTC
(In reply to Anton Saietskii from comment #3)
We are in pause for subpackages at the moment. There were some issues found after the implementation landed in the ports framework.
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-05-24 17:57:16 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bd0b0eec12d655b9c8b87ace4503f6f36dc14e5f

commit bd0b0eec12d655b9c8b87ace4503f6f36dc14e5f
Author:     Rafe <mondo.debater_0q@icloud.com>
AuthorDate: 2024-05-23 06:24:38 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2024-05-24 17:56:56 +0000

    net-p2p/transmission-components: Get transmission-web back

    After the reorganization of the port in ac3e39992e95659a5193a15d4cb873efb00fcb30
    the web interface was only available if the daemon component was selected.
    This is not right since the gtk version of transmission needs those files too,
    otherwise the setup is broken.

    Bring transmission-web option back.

    PR:             279214
    Reported by:    fernape@FreeBSD.org

 UPDATING                                           |  7 +++++++
 net-p2p/transmission-components/Makefile           | 24 ++++++++++++++++------
 net-p2p/transmission-components/pkg-descr.daemon   |  7 +------
 net-p2p/transmission-components/pkg-descr.gtk      |  4 +++-
 net-p2p/transmission-components/pkg-descr.qt       |  4 +++-
 .../transmission-components/pkg-descr.web (new)    |  8 ++++++++
 net-p2p/transmission-components/pkg-plist.daemon   |  7 -------
 .../transmission-components/pkg-plist.web (new)    |  7 +++++++
 net-p2p/transmission/Makefile                      |  7 +++++--
 9 files changed, 52 insertions(+), 23 deletions(-)
Comment 10 Fernando Apesteguía freebsd_committer freebsd_triage 2024-05-24 17:57:57 UTC
Committed,

Thanks!