Bug 279551 - x11/arandr: update to 0.1.11
Summary: x11/arandr: update to 0.1.11
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rodrigo Osorio
URL:
Keywords:
: 280016 280017 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-06-06 09:24 UTC by Rodrigo Osorio
Modified: 2024-07-17 13:10 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sbz)


Attachments
update to 0.1.11 with getargspec patch (1.59 KB, patch)
2024-06-06 09:24 UTC, Rodrigo Osorio
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rodrigo Osorio freebsd_committer freebsd_triage 2024-06-06 09:24:44 UTC
Created attachment 251245 [details]
update to 0.1.11 with getargspec patch

Update arandr patch to 0.1.11 and fix the issue with deprecate call to inspect getargspec


Changelog: https://gitlab.com/arandr/arandr/-/blob/0.1.11/ChangeLog?ref_type=tags

The getargspec was fixes one year ago, but the project seems a little bit abandoned.
Comment 1 Cy Schubert freebsd_committer freebsd_triage 2024-07-15 13:06:43 UTC
Looks like this PR or PR/280017 can be committed based on maintainer timeout.

Though it should be commited with the update and getargspec patches in separate commits.
Comment 2 Rodrigo Osorio freebsd_committer freebsd_triage 2024-07-17 11:15:50 UTC
(In reply to Cy Schubert from comment #1)
Yes, I think we should commit the patch first and MFC it to quarter branch since the issue also affect current version, then do the update to 0.1.11
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-07-17 12:13:59 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cb8a650b356b0e9458da36e06b99a5fe6a1f1206

commit cb8a650b356b0e9458da36e06b99a5fe6a1f1206
Author:     Rodrigo Osorio <rodrigo@FreeBSD.org>
AuthorDate: 2024-07-17 12:03:56 +0000
Commit:     Rodrigo Osorio <rodrigo@FreeBSD.org>
CommitDate: 2024-07-17 12:10:41 +0000

    x11/arandr: fix broken port

    Fix the issue with deprecate call to inspect getargspec.
    The change was done by upstream in the master branch,
    but wasn't released yet.

    PR:             279551
    Approved by:    maintainer timeout

 x11/arandr/Makefile                              |  2 +-
 x11/arandr/files/patch-screenlayout_gui.py (new) | 11 +++++++++++
 2 files changed, 12 insertions(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-07-17 12:23:03 UTC
A commit in branch 2024Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d324e398d355702d1041747a68e0d27ead919c0d

commit d324e398d355702d1041747a68e0d27ead919c0d
Author:     Rodrigo Osorio <rodrigo@FreeBSD.org>
AuthorDate: 2024-07-17 12:03:56 +0000
Commit:     Rodrigo Osorio <rodrigo@FreeBSD.org>
CommitDate: 2024-07-17 12:20:41 +0000

    x11/arandr: fix broken port

    Fix the issue with deprecate call to inspect getargspec.
    The change was done by upstream in the master branch,
    but wasn't released yet.

    PR:             279551
    Approved by:    maintainer timeout

    (cherry picked from commit cb8a650b356b0e9458da36e06b99a5fe6a1f1206)

 x11/arandr/Makefile                              |  2 +-
 x11/arandr/files/patch-screenlayout_gui.py (new) | 11 +++++++++++
 2 files changed, 12 insertions(+), 1 deletion(-)
Comment 5 Rodrigo Osorio freebsd_committer freebsd_triage 2024-07-17 12:25:26 UTC
*** Bug 280016 has been marked as a duplicate of this bug. ***
Comment 6 Rodrigo Osorio freebsd_committer freebsd_triage 2024-07-17 12:28:11 UTC
*** Bug 280017 has been marked as a duplicate of this bug. ***
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-07-17 13:04:07 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1b02277b4e5f285142a493a764f02cd3f5ae2ff4

commit 1b02277b4e5f285142a493a764f02cd3f5ae2ff4
Author:     Rodrigo Osorio <rodrigo@FreeBSD.org>
AuthorDate: 2024-07-17 12:31:52 +0000
Commit:     Rodrigo Osorio <rodrigo@FreeBSD.org>
CommitDate: 2024-07-17 13:00:20 +0000

    x11/arandr: update to 0.1.11

    Changelog: https://gitlab.com/arandr/arandr/-/blob/8348c0b6020a792c1fed5baca923151db98b9397/ChangeLog

    Port changes:
        * Remove patch-screenlayout_gui.py not required anymore

    PR:             279551
    Approved by:    maintainer timeout

 x11/arandr/Makefile                               |  5 ++---
 x11/arandr/distinfo                               |  6 +++---
 x11/arandr/files/patch-screenlayout_gui.py (gone) | 11 -----------
 3 files changed, 5 insertions(+), 17 deletions(-)
Comment 8 Rodrigo Osorio freebsd_committer freebsd_triage 2024-07-17 13:10:04 UTC
The submitted patch to upgrade to 0.1.11 was wrong, it only updates the PORTVERSION
number but not the GH_TAGNAME, thanks @zirias for point me out with a previous commit :P

Now patch on screenlayout_gui.py is not required anymore.

Thanks @cy for your gentle bump about this PR.