Bug 279981 - net-p2p/radarr: Update to 5.7.0.8882
Summary: net-p2p/radarr: Update to 5.7.0.8882
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://github.com/Radarr/Radarr/rele...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-25 06:54 UTC by nomoo
Modified: 2024-07-09 13:35 UTC (History)
3 users (show)

See Also:
michiel: maintainer-feedback+


Attachments
patch (2.73 KB, patch)
2024-06-25 06:54 UTC, nomoo
no flags Details | Diff
0001-net-p2p-radarr-Update-to-5.7.0.8882.patch (3.72 KB, patch)
2024-06-29 11:19 UTC, Michiel van Baak Jansen
michiel: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nomoo 2024-06-25 06:54:35 UTC
Created attachment 251684 [details]
patch

poudriere ok
runs in production on my setup, 14.1 amd64
Comment 1 Michiel van Baak Jansen 2024-06-25 07:45:05 UTC
Thanks for the patch. I am running the exact same patch in production on my setup.
Good to go!
Comment 2 Michiel van Baak Jansen 2024-06-25 07:45:47 UTC
changelog url: https://github.com/Radarr/Radarr/releases/tag/v5.7.0.8882
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2024-06-28 18:01:11 UTC
Patch is in MS-DOS format (did you copy-paste it?)
Would it be possible to attach it to the PR?

Thanks!
Comment 4 Michiel van Baak Jansen 2024-06-29 11:19:55 UTC
Created attachment 251772 [details]
0001-net-p2p-radarr-Update-to-5.7.0.8882.patch

Additional change: added an `export PATH` to the rc script to help pre and post import scripts to find 3rd party binaries.

poudriere ok
runs in production on my setup for some time now already.
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2024-06-29 18:53:55 UTC
Committed,

Thanks!
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-06-29 18:54:44 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=38b2c5feffcba3be37d73b34970502efedbf6cb0

commit 38b2c5feffcba3be37d73b34970502efedbf6cb0
Author:     Michiel van Baak Jansen <michiel@vanbaak.eu>
AuthorDate: 2024-06-29 18:52:49 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2024-06-29 18:52:49 +0000

    net-p2p/radarr: Update to 5.7.0.8882

    ChangeLog: https://github.com/Radarr/Radarr/releases/tag/v5.7.0.8882

     * Multiple Translations updated by Weblate
     * Fixed: Importing from IMDb list
     * New: Display stats for delete movies modal
     * New: Ignore inaccessible folders when getting folders
     * Fixed: Ensure TMDb import lists are paginated
     * Fixed: Adding movies with unknown items in queue
     * Multiple Translations updated by Weblate
     * Automated API Docs update
     * Fixed: Skip invalid movie paths during validation
     * Ignore Grabbed from API docs

    PR:             279981
    Reported by:    nomoo@nomoo.ru

 net-p2p/radarr/Makefile        |  2 +-
 net-p2p/radarr/distinfo        |  6 +++---
 net-p2p/radarr/files/radarr.in |  3 +++
 net-p2p/radarr/pkg-plist       | 13 +++++++------
 4 files changed, 14 insertions(+), 10 deletions(-)
Comment 7 Benoît Guillemaud 2024-07-07 17:02:45 UTC
Hello,

Why was this version pushed only to FreeBSD:14 and not 13 ?

Best regards !
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2024-07-07 17:08:23 UTC
(In reply to benoit from comment #7)
What do you mean? This was pushed to head.
Comment 9 Benoît Guillemaud 2024-07-07 17:14:42 UTC
(In reply to Fernando Apesteguía from comment #8)

I mean I can't get the update with pkg on a FreeBSD 13 install.

According to FreshPorts it's only available on 14 : https://www.freshports.org/net-p2p/radarr/
Comment 10 Fernando Apesteguía freebsd_committer freebsd_triage 2024-07-07 17:38:45 UTC
(In reply to Benoît Guillemaud from comment #9)
Notice that is the *package* available, not the *port*.
If it is not in 13, it is probably because the builder did not build it yet and/or is failing there
Comment 11 Benoît Guillemaud 2024-07-07 17:49:51 UTC
(In reply to Fernando Apesteguía from comment #10)
Thnkas for the information, I'm quite new to all of this 😅

Is there a place where I can check if the builder is having problems building the package ?
Comment 12 Fernando Apesteguía freebsd_committer freebsd_triage 2024-07-08 09:59:15 UTC
(In reply to Benoît Guillemaud from comment #11)
Which FreeBSD version are you on? Notice that 13.2 has gone EoL :-)
Comment 13 Benoît Guillemaud 2024-07-08 11:55:34 UTC
(In reply to Fernando Apesteguía from comment #12)
Hi Fernando,

Radarr is currently running in a jail based on 13.2-RELEASE-p11. The "host" system is TrueNAS 13.3-BETA2 which is based on FreeBSD 13.3-RELEASE-p2.

AFAIK 13.3 is not EoL yet ?
Comment 14 Fernando Apesteguía freebsd_committer freebsd_triage 2024-07-08 16:11:20 UTC
(In reply to Benoît Guillemaud from comment #13)
13.2 has been EoLed. Since you are using that in your jail, that is what you will see if you try to install a package from the jail.

13.3 is well alive.

Notice that 13.2 is *wrongly* showed as Production in the web site of the project. I'm fixing that now.
Comment 15 Benoît Guillemaud 2024-07-08 22:26:31 UTC
(In reply to Fernando Apesteguía from comment #14)
So, I did upgrade the jail to 13.3-RELEASE-p4, still no package for 5.7.0. Still stuck on 5.6.0.

Which makes sense since (as far as I konw), there is one package tree per major version. (http://pkg.freebsd.org/FreeBSD:13:amd64/latest/)
Comment 16 Michiel van Baak Jansen 2024-07-09 07:39:35 UTC
(In reply to Benoît Guillemaud from comment #15)

See https://www.freshports.org/net-p2p/radarr/ and scroll down to `Packages`
It will show you exactly what version of radarr is available in the package repositories for latest and quarterly, for your version of FreeBSD.
Comment 17 Benoît Guillemaud 2024-07-09 08:25:49 UTC
(In reply to Michiel van Baak Jansen from comment #16)
Hello Michiel,

Yeah I already know Freshports (cf. comment #9). Thta's how I know this version is available on the 14 and 15 branches, but not 13.

Now the question is why ?
Comment 18 Michiel van Baak Jansen 2024-07-09 09:16:36 UTC
(In reply to Benoît Guillemaud from comment #17)
See comment #10 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279981#c10
It explains why.
The builder will get to it, just have to be more patient.
Not much we can do beyond this point.
Comment 19 Benoît Guillemaud 2024-07-09 09:20:50 UTC
(In reply to Michiel van Baak Jansen from comment #18)
Ok, thanks for the info.

I'm really not familiar with the whole process here 😅

Is the package building an automatic process done automatically once the patch has been comitted ? If so, where can we check if there is a problem with the package building process ?
Comment 20 Michiel van Baak Jansen 2024-07-09 09:46:07 UTC
(In reply to Benoît Guillemaud from comment #19)

https://pkg-status.freebsd.org
Comment 21 Benoît Guillemaud 2024-07-09 13:18:25 UTC
(In reply to Michiel van Baak Jansen from comment #20)
Thanks for the website !

I might be dumb, but I can't figure out how to find the build status of a specific package :-(
Comment 22 Benoît Guillemaud 2024-07-09 13:20:57 UTC
I figure it must be related to this build, but I can't figure which packages failed to duild : https://pkg-status.freebsd.org/builds/default:default:133amd64:58363a86b3c6:beefy16
Comment 23 Benoît Guillemaud 2024-07-09 13:35:46 UTC
Sorry for the mail bombing with my several comments in a row.

I think I managed to find the build environment I was looking for : https://pkg-status.freebsd.org/beefy16/build.html?mastername=133amd64-default&build=58363a86b3c6

According to this page, the radarr package for 5.7.0 was indeed built, and here is the log : https://pkg-status.freebsd.org/beefy16/data/133amd64-default/58363a86b3c6/logs/radarr-5.7.0.8882.log

So, it looks like the package was properly built on Sunday. Does that means it should be available shortly in pkg ?