Bug 280151 - sysutils/di: Update to 4.53
Summary: sysutils/di: Update to 4.53
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Zsolt Udvari
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-06 04:29 UTC by Naram Qashat
Modified: 2024-07-08 05:28 UTC (History)
1 user (show)

See Also:
uzsolt: maintainer-feedback+

Attachments
di-4.53.patch (3.51 KB, patch)
2024-07-06 04:29 UTC, Naram Qashat 		cyberbotx: maintainer-approval+
Details | Diff
di-4.53.patch (4.05 KB, patch)
2024-07-08 02:05 UTC, Naram Qashat 		cyberbotx: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Naram Qashat 2024-07-06 04:29:51 UTC 
Created attachment 251894 [details]
di-4.53.patch

- Update to 4.53
- Apply small fix to Makefile from portfmt
- Update distinfo
- Update patches

No online changelogs available.

Tested in poudriere for 13 amd64 and 14 amd64.
Comment 1 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-06 19:02:02 UTC 
Thanks your patch.
Would you like add do-test: target into Makefile? As I see mkconfig/runtests.sh does this.
It would be nice because can test works well everything or not.
Comment 2 Naram Qashat 2024-07-06 22:36:13 UTC 
I could look into it but I haven't done tests in a port before, so if you know what needs to be added to make that work, you could add it and I'd be fine with it.
Comment 3 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-07 18:23:12 UTC 
(In reply to Naram Qashat from comment #2)
I tried but don't know why fails. I think the "mkconfig/runtests.sh tests.d" is the command but "diinst ... install ... failed".

If you've lust debug it do it but if no I'll commit it without adding do-test.
Comment 4 Naram Qashat 2024-07-08 02:05:46 UTC 
Created attachment 251930 [details]
di-4.53.patch

OK, I am updating the patch to include a way to run the tests. I made it not bother with the diinst test because I feel for what I'm doing for the install makes it so the test is invalid anyways, and I don't think it is really needed like the other tests are.
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-07-08 05:27:38 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ccca232b0a6f12f16160066a45a144afce40ad1a

commit ccca232b0a6f12f16160066a45a144afce40ad1a
Author:     Naram Qashat <cyberbotx@cyberbotx.com>
AuthorDate: 2024-07-08 05:22:10 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-07-08 05:22:10 +0000

    sysutils/di: update to 4.53

    Swith to DISTVERSION.
    Add TEST_TARGET and USES=perl5 to test phase.

    Changelog:
    Fixed library check for modern compilers.
    Removed old D language stuff.
    Remove support for K&R compilers and ancient systems.
    Fix debug output for env vars.
    DI_ARGS: print error and exit when encountering unknown data.

    PR:             280151
    Approved by:    submitter is maintainer

 sysutils/di/Makefile                              |  9 +++++---
 sysutils/di/distinfo                              |  6 ++---
 sysutils/di/files/patch-C-Makefile                | 28 ++++-------------------
 sysutils/di/files/patch-Makefile                  | 24 ++++++++-----------
 sysutils/di/files/patch-tests.d_test__order (new) |  8 +++++++
 5 files changed, 31 insertions(+), 44 deletions(-)
Comment 6 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-08 05:28:46 UTC 
Committed, thanks!