Bug 280277 - devel/automake: Update to 1.17
Summary: devel/automake: Update to 1.17
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tijl Coosemans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-14 14:28 UTC by Tijl Coosemans
Modified: 2024-07-20 11:35 UTC (History)
0 users

See Also:
antoine: exp-run+


Attachments
patch (7.21 KB, patch)
2024-07-14 14:28 UTC, Tijl Coosemans
no flags Details | Diff
patch2 (16.35 KB, patch)
2024-07-18 15:56 UTC, Tijl Coosemans
no flags Details | Diff
patch3 (16.33 KB, patch)
2024-07-19 08:37 UTC, Tijl Coosemans
no flags Details | Diff
patch4 (17.77 KB, patch)
2024-07-20 10:50 UTC, Tijl Coosemans
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tijl Coosemans freebsd_committer freebsd_triage 2024-07-14 14:28:52 UTC
Created attachment 252046 [details]
patch

Update devel/automake to 1.17.
Comment 2 Tijl Coosemans freebsd_committer freebsd_triage 2024-07-18 15:56:42 UTC
Created attachment 252146 [details]
patch2

Fix build failures.

biology/libneurosim: Fix use of libltdl.

dns/ddclient: Take out -Werror.

lang/sdcc:
- Patching ARCH is no longer needed.  Remove it because it touched some configure.ac files and that causes other autotools files to appear out-of-date.
- Run autoreconf in WRKSRC/device/lib/pic14 because aclocal.m4 and config.h.in appear out-of-date.

net/rpki-client: Patch Makefile.in instead of Makefile.am to avoid autotools.

sysutils/genimage: Run configure with --disable-silent-rules because upstream changed the default to silent and when silent rules are enabled it also runs make with --no-print-directory which is a gmake flag.
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2024-07-18 16:04:14 UTC
Patch fails to apply:

error: patch failed: biology/libneurosim/Makefile:29
error: biology/libneurosim/Makefile: patch does not apply
Comment 4 Tijl Coosemans freebsd_committer freebsd_triage 2024-07-19 08:37:48 UTC
Created attachment 252162 [details]
patch3

Rebased on clean tree.
Comment 5 Antoine Brodin freebsd_committer freebsd_triage 2024-07-19 15:27:06 UTC
The genimage failure remains
Comment 6 Tijl Coosemans freebsd_committer freebsd_triage 2024-07-20 10:50:53 UTC
Created attachment 252191 [details]
patch4

sysutils/genimage: Patch Makefile.am so it uses --no-print-directory depending on the actual verbosity instead of the default.
Comment 7 Antoine Brodin freebsd_committer freebsd_triage 2024-07-20 10:55:53 UTC
(In reply to Tijl Coosemans from comment #6)
I let you test it
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-07-20 11:30:38 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c8eeb158e413fdfba1cc3f226d7c9ed8521e39af

commit c8eeb158e413fdfba1cc3f226d7c9ed8521e39af
Author:     Tijl Coosemans <tijl@FreeBSD.org>
AuthorDate: 2024-07-14 14:14:05 +0000
Commit:     Tijl Coosemans <tijl@FreeBSD.org>
CommitDate: 2024-07-20 11:27:02 +0000

    devel/automake: Update to 1.17

    biology/libneurosim: Fix use of libltdl.

    dns/ddclient: Take out -Werror.

    lang/sdcc:
    - Patching ARCH is no longer needed.  Remove it because it touched some
      configure.ac files and that causes other autotools files to appear
      out-of-date.
    - Run autoreconf in WRKSRC/device/lib/pic14 because aclocal.m4 and
      config.h.in appear out-of-date.

    net/rpki-client: Patch Makefile.in instead of Makefile.am to avoid
    autotools.

    sysutils/genimage: Run configure with --disable-silent-rules because
    upstream changed the default to silent and when silent rules are
    enabled it also runs make with --no-print-directory which is a gmake
    flag.  Patch Makefile.am so it uses --no-print-directory depending on
    the actual verbosity instead of the default.

    PR:             280277
    Exp-run by:     antoine

 Mk/Uses/autoreconf.mk                              |  2 +-
 biology/libneurosim/Makefile                       | 10 ++--
 biology/libneurosim/files/patch-configure.ac (new) | 53 ++++++++++++++++++++++
 devel/automake/Makefile                            | 17 ++++---
 devel/automake/distinfo                            |  6 +--
 devel/automake/files/patch-Makefile.in (gone)      | 14 ------
 devel/automake/files/patch-m4_python.m4 (gone)     | 16 -------
 devel/automake/pkg-plist                           | 18 ++++----
 dns/ddclient/files/patch-configure.ac (new)        | 11 +++++
 lang/sdcc/Makefile                                 | 33 ++------------
 lang/sdcc/pkg-plist                                |  1 +
 net/rpki-client/Makefile                           |  2 +-
 .../files/{patch-Makefile.am => patch-Makefile.in} |  8 ++--
 sysutils/genimage/Makefile                         |  1 +
 sysutils/genimage/files/patch-Makefile.am (new)    | 12 +++++
 sysutils/genimage/files/patch-configure.ac (new)   | 12 +++++
 16 files changed, 126 insertions(+), 90 deletions(-)