Bug 280621 - www/gitlab: Could not find gem 'cssbundling-rails (= 1.4.0)' in locally installed gems, building in poudriere
Summary: www/gitlab: Could not find gem 'cssbundling-rails (= 1.4.0)' in locally insta...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Matthias Fechner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-05 06:37 UTC by Anton Evel
Modified: 2024-08-08 05:52 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (mfechner)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Evel 2024-08-05 06:37:57 UTC
Dear sirs,

the staging phase didn't complete this night on my poudriere with the following:

===========================================================================
=======================<phase: stage          >============================
===== env: NO_DEPENDS=yes USER=root UID=0 GID=0
===>  Staging for gitlab-ce-17.1.3_2
===>   Generating temporary packing list
===> Creating groups
===> Creating users
cp -f /wrkdirs/usr/ports/www/gitlab/work-ce/gitlab-foss-v17.1.3/config/database.yml.postgresql /wrkdirs/usr/ports/www/gitlab/work-ce/gitlab-foss-v17.1.3/config/database.yml.sample
(cd /wrkdirs/usr/ports/www/gitlab/work-ce/gitlab-foss-v17.1.3 && bundle config set --local bin .bin)
(cd /wrkdirs/usr/ports/www/gitlab/work-ce/gitlab-foss-v17.1.3 && /bin/rm -f Gemfile.lock && HOME=/wrkdirs/usr/ports/www/gitlab/work-ce  PWD="${PWD}"  __MAKE_CONF=/nonexistent OSVERSION=1400097 PATH=/wrkdirs/usr/ports/www/gitlab/work-ce/.bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin TMPDIR=/tmp UNAME_r=14.0-RELEASE-p8 UNAME_v=FreeBSD\ 14.0-RELEASE-p8  bundle install --local)
Don't run Bundler as root. Installing your bundle as root will break this
application for all non-root users on this machine.
Could not find gem 'cssbundling-rails (= 1.4.0)' in locally installed gems.

The source contains the following gems matching 'cssbundling-rails':
  * cssbundling-rails-1.4.1
*** Error code 7

Stop.
make: stopped in /usr/ports/www/gitlab
=>> Cleaning up wrkdir
===>  Cleaning for gitlab-ce-17.1.3_2
build of www/gitlab@ce | gitlab-ce-17.1.3_2 ended at Mon Aug  5 00:16:21 MSK 2024
build time: 00:02:14
!!! build failure encountered !!!

As I can see, there's some trouble with dependencies. Thanks in advance if you can fix it!

Anton.
Comment 1 Matthias Fechner freebsd_committer freebsd_triage 2024-08-05 07:15:54 UTC
Dear Anton,

thanks a lot for your report.
The problem is related to this commit:
https://cgit.freebsd.org/ports/commit/?id=09d7eada6c2c214adac9780307f2dd7689ab8660

My problem is, that I can currently not test gitlab patches (I can only test the build itself as I do not have access to my gitlab test instances from remote).

If the build finished, I can provide a patch, maybe you can test it?
Comment 2 Anton Evel 2024-08-05 11:12:03 UTC
I think I could make a try..
Comment 3 Matthias Fechner freebsd_committer freebsd_triage 2024-08-05 11:41:41 UTC
I committed the fix to this branch:
https://gitlab.fechner.net/mfechner/Gitlab/-/commits/280621

This is the specific commit:
https://gitlab.fechner.net/mfechner/Gitlab/-/commit/2e240af0c5fa015fe51908ae5e11fa241801eac7

The pipeline will make a final check after it is green, you can try to apply the patch to your side and install the new package to a gitlab installation (at best to a test environment, to not break an existing installation by accident).
Comment 4 Anton Evel 2024-08-05 12:03:33 UTC
I've added patch to the files dir and the poudriere finished building gitlab-ce without any errors this time.
Can't install and try it for now because we have working hours and I don't have any test environment to check. Will try it today at about 21:00 UTC

Thank you, Matthias!
Comment 5 Anton Evel 2024-08-07 07:20:24 UTC
I've checked the patch and it seems that all is ok now. Thank you!
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-08-07 07:38:29 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3cb9a29a46e9cbe42bcb24e80e83780057480c0c

commit 3cb9a29a46e9cbe42bcb24e80e83780057480c0c
Author:     Matthias Fechner <mfechner@FreeBSD.org>
AuthorDate: 2024-08-05 07:26:08 +0000
Commit:     Matthias Fechner <mfechner@FreeBSD.org>
CommitDate: 2024-08-07 07:37:05 +0000

    www/gitlab: fix regression from 09d7eada6c2c214adac9780307f2dd7689ab8660

    Gitlab requires cssbundling 1.4.0.
    As changelog of cssbundling seems not to have a breaking change, allow 1.4.x.

    PR:             280621
    Tested by:      Админ всея АСУ-ВЭИ <admin@asu-vei.ru>

 www/gitlab/Makefile | 1 +
 1 file changed, 1 insertion(+)
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-08-07 07:38:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a5e529d6a767023c10d083c7ad441ad464b01c1e

commit a5e529d6a767023c10d083c7ad441ad464b01c1e
Author:     Matthias Fechner <mfechner@FreeBSD.org>
AuthorDate: 2024-08-05 07:26:08 +0000
Commit:     Matthias Fechner <mfechner@FreeBSD.org>
CommitDate: 2024-08-07 07:37:05 +0000

    www/gitlab: fix regression from 09d7eada6c2c214adac9780307f2dd7689ab8660

    Gitlab requires cssbundling 1.4.0.
    As changelog of cssbundling seems not to have a breaking change, allow 1.4.x.
    That patch is not approved from upstream and needs to be tested carefully.

    PR:             280621

 www/gitlab/Makefile            |  2 +-
 www/gitlab/files/patch-Gemfile | 23 ++++++++++++++++-------
 2 files changed, 17 insertions(+), 8 deletions(-)
Comment 8 Matthias Fechner freebsd_committer freebsd_triage 2024-08-08 05:52:00 UTC
thanks a lot for testing.