Bug 281317 - databases/sfcgal fails to build from source due to "phase: patch"
Summary: databases/sfcgal fails to build from source due to "phase: patch"
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Many People
Assignee: Loïc Bartoletti
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-06 21:39 UTC by Dennis Clarke
Modified: 2024-09-08 19:14 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (lbartoletti)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Clarke 2024-09-06 21:39:37 UTC
Seen over the past week with poudriere and the 2024Q3 ports tree.



triton# cat  ./logs/sfcgal-1.5.1_1.log
=>> Building databases/sfcgal
build started at Fri Sep  6 21:26:27 UTC 2024
port directory: /usr/ports/databases/sfcgal
package name: sfcgal-1.5.1_1
building for: FreeBSD 141amd64-2024Q3-job-01 14.1-RELEASE-p3 FreeBSD 14.1-RELEASE-p3 1401000 amd64
maintained by: lbartoletti@FreeBSD.org
Makefile datestamp: -rw-r--r--  1 root wheel 753 Jul 10 06:31 /usr/ports/databases/sfcgal/Makefile
Ports top last git commit: 3f44e8bb4bf3
Ports top unclean checkout: no
Port dir last git commit: b733ae96495f
Port dir unclean checkout: no
Poudriere version: poudriere-git-3.4.2
Host OSVERSION: 1500023
Jail OSVERSION: 1401000
Job Id: 01

---Begin Environment---
SHELL=/bin/sh
OSVERSION=1401000
UNAME_v=FreeBSD 14.1-RELEASE-p3 1401000
UNAME_r=14.1-RELEASE-p3
BLOCKSIZE=K
MAIL=/var/mail/root
MM_CHARSET=UTF-8
LANG=C.UTF-8
STATUS=1
HOME=/root
PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin
MAKE_OBJDIR_CHECK_WRITABLE=0
LOCALBASE=/usr/local
USER=root
POUDRIERE_NAME=poudriere-git
LIBEXECPREFIX=/usr/local/libexec/poudriere
POUDRIERE_VERSION=3.4.2
MASTERMNT=/poudriere/data/.m/141amd64-2024Q3/ref
LC_COLLATE=C
POUDRIERE_BUILD_TYPE=bulk
PACKAGE_BUILDING=yes
SAVED_TERM=xterm
OUTPUT_REDIRECTED_STDERR=4
OUTPUT_REDIRECTED=1
PWD=/poudriere/data/.m/141amd64-2024Q3/01/.p
OUTPUT_REDIRECTED_STDOUT=3
P_PORTS_FEATURES=FLAVORS SUBPACKAGES SELECTED_OPTIONS
MASTERNAME=141amd64-2024Q3
SCRIPTPREFIX=/usr/local/share/poudriere
SCRIPTNAME=bulk.sh
OLDPWD=/poudriere/data/.m/141amd64-2024Q3/ref/.p/pool
POUDRIERE_PKGNAME=poudriere-git-3.4.2
SCRIPTPATH=/usr/local/share/poudriere/bulk.sh
POUDRIEREPATH=/usr/local/bin/poudriere
---End Environment---

---Begin Poudriere Port Flags/Env---
PORT_FLAGS=
PKGENV=
FLAVOR=
MAKE_ARGS=
---End Poudriere Port Flags/Env---

---Begin OPTIONS List---
---End OPTIONS List---

--MAINTAINER--
lbartoletti@FreeBSD.org
--End MAINTAINER--

--CONFIGURE_ARGS--

--End CONFIGURE_ARGS--

--CONFIGURE_ENV--
XDG_DATA_HOME=/wrkdirs/usr/ports/databases/sfcgal/work  XDG_CONFIG_HOME=/wrkdirs/usr/ports/databases/sfcgal/work  XDG_CACHE_HOME=/wrkdirs/usr/ports/databases/sfcgal/work/.cache  HOME=/wrkdirs/usr/ports/databases/sfcgal/work TMPDIR="/tmp" PATH=/wrkdirs/usr/ports/databases/sfcgal/work/.bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin PKG_CONFIG_LIBDIR=/wrkdirs/usr/ports/databases/sfcgal/work/.pkgconfig:/usr/local/libdata/pkgconfig:/usr/local/share/pkgconfig:/usr/libdata/pkgconfig SHELL=/bin/sh CONFIG_SHELL=/bin/sh
--End CONFIGURE_ENV--

--MAKE_ENV--
NINJA_STATUS="[%p %s/%t] " XDG_DATA_HOME=/wrkdirs/usr/ports/databases/sfcgal/work  XDG_CONFIG_HOME=/wrkdirs/usr/ports/databases/sfcgal/work  XDG_CACHE_HOME=/wrkdirs/usr/ports/databases/sfcgal/work/.cache  HOME=/wrkdirs/usr/ports/databases/sfcgal/work TMPDIR="/tmp" PATH=/wrkdirs/usr/ports/databases/sfcgal/work/.bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin PKG_CONFIG_LIBDIR=/wrkdirs/usr/ports/databases/sfcgal/work/.pkgconfig:/usr/local/libdata/pkgconfig:/usr/local/share/pkgconfig:/usr/libdata/pkgconfig MK_DEBUG_FILES=no MK_KERNEL_SYMBOLS=no SHELL=/bin/sh NO_LINT=YES DESTDIR=/wrkdirs/usr/ports/databases/sfcgal/work/stage PREFIX=/usr/local  LOCALBASE=/usr/local  CC="cc" CFLAGS="-O2 -pipe  -fstack-protector-strong -fno-strict-aliasing "  CPP="cpp" CPPFLAGS=""  LDFLAGS=" -fstack-protector-strong " LIBS=""  CXX="c++" CXXFLAGS="-O2 -pipe -fstack-protector-strong -fno-strict-aliasing  " BSD_INSTALL_PROGRAM="install  -s -m 555"  BSD_INSTALL_LIB="install  -s -m 0644"  BSD_INSTALL_SCRIPT="install  -m 555"  BSD_INSTALL_DATA="install  -m 0644"  BSD_INSTALL_MAN="install  -m 444"
--End MAKE_ENV--

--PLIST_SUB--
SHL3=1.5.1 SHL1=1 DEBUG_SUFFIX= CMAKE_BUILD_TYPE="release" OSREL=14.1 PREFIX=%D LOCALBASE=/usr/local  RESETPREFIX=/usr/local LIB32DIR=lib DOCSDIR="share/doc/sfcgal"  EXAMPLESDIR="share/examples/sfcgal"  DATADIR="share/sfcgal"  WWWDIR="www/sfcgal"  ETCDIR="etc/sfcgal"
--End PLIST_SUB--

--SUB_LIST--
PREFIX=/usr/local LOCALBASE=/usr/local  DATADIR=/usr/local/share/sfcgal DOCSDIR=/usr/local/share/doc/sfcgal EXAMPLESDIR=/usr/local/share/examples/sfcgal  WWWDIR=/usr/local/www/sfcgal ETCDIR=/usr/local/etc/sfcgal
--End SUB_LIST--

---Begin make.conf---
USE_PACKAGE_DEPENDS=yes
BATCH=yes
WRKDIRPREFIX=/wrkdirs
PORTSDIR=/usr/ports
PACKAGES=/packages
DISTDIR=/distfiles
FORCE_PACKAGE=yes
PACKAGE_BUILDING=yes
PACKAGE_BUILDING_FLAVORS=yes
WITH_CCACHE_BUILD=yes
CCACHE_DIR=/root/.ccache
#### Misc Poudriere ####
.include "/etc/make.conf.ports_env"
GID=0
UID=0
---End make.conf---
--Resource limits--
cpu time               (seconds, -t)  unlimited
file size           (512-blocks, -f)  unlimited
data seg size           (kbytes, -d)  33554432
stack size              (kbytes, -s)  524288
core file size      (512-blocks, -c)  unlimited
max memory size         (kbytes, -m)  unlimited
locked memory           (kbytes, -l)  unlimited
max user processes              (-u)  89999
open files                      (-n)  8192
virtual mem size        (kbytes, -v)  unlimited
swap limit              (kbytes, -w)  unlimited
socket buffer size       (bytes, -b)  unlimited
pseudo-terminals                (-p)  unlimited
kqueues                         (-k)  unlimited
umtx shared locks               (-o)  unlimited
--End resource limits--
=======================<phase: check-sanity   >============================
===== env: NO_DEPENDS=yes USER=root UID=0 GID=0
===>  License GPLv2 accepted by the user
===========================================================================
=======================<phase: pkg-depends    >============================
===== env: USE_PACKAGE_DEPENDS_ONLY=1 USER=root UID=0 GID=0
===>   sfcgal-1.5.1_1 depends on file: /usr/local/sbin/pkg - not found
===>   Installing existing package /packages/All/pkg-1.21.3.pkg
[141amd64-2024Q3-job-01] Installing pkg-1.21.3...
[141amd64-2024Q3-job-01] Extracting pkg-1.21.3: .......... done
===>   sfcgal-1.5.1_1 depends on file: /usr/local/sbin/pkg - found
===>   Returning to build of sfcgal-1.5.1_1
===========================================================================
=======================<phase: fetch-depends  >============================
===== env: USE_PACKAGE_DEPENDS_ONLY=1 USER=root UID=0 GID=0
===========================================================================
=======================<phase: fetch          >============================
===== env: NO_DEPENDS=yes USER=root UID=0 GID=0
===>  License GPLv2 accepted by the user
===> Fetching all distfiles required by sfcgal-1.5.1_1 for building
===========================================================================
=======================<phase: checksum       >============================
===== env: NO_DEPENDS=yes USER=root UID=0 GID=0
===>  License GPLv2 accepted by the user
===> Fetching all distfiles required by sfcgal-1.5.1_1 for building
=> SHA256 Checksum OK for CGAL-5.6.tar.xz.
=> SHA256 Checksum OK for SFCGAL-v1.5.1.tar.bz2.
===========================================================================
=======================<phase: extract-depends>============================
===== env: USE_PACKAGE_DEPENDS_ONLY=1 USER=root UID=0 GID=0
===========================================================================
=======================<phase: extract        >============================
===== env: NO_DEPENDS=yes USER=root UID=0 GID=0
===>  License GPLv2 accepted by the user
===> Fetching all distfiles required by sfcgal-1.5.1_1 for building
===>  Extracting for sfcgal-1.5.1_1
=> SHA256 Checksum OK for CGAL-5.6.tar.xz.
=> SHA256 Checksum OK for SFCGAL-v1.5.1.tar.bz2.
===========================================================================
=======================<phase: patch-depends  >============================
===== env: USE_PACKAGE_DEPENDS_ONLY=1 USER=root UID=0 GID=0
===========================================================================
=======================<phase: patch          >============================
===== env: NO_DEPENDS=yes USER=root UID=0 GID=0
===>  Patching for sfcgal-1.5.1_1
===>  Applying FreeBSD patches for sfcgal-1.5.1_1 from /usr/ports/databases/sfcgal/files
No file to patch.  Skipping...
3 out of 3 hunks ignored--saving rejects to ../CGAL-5.6.1/include/CGAL/boost/graph/iterator.h.rej
Can't create ../CGAL-5.6.1/include/CGAL/boost/graph/iterator.h.rej, output is in /tmp/patchrHZv1fNxva6: No such file or directory
===>  FAILED Applying FreeBSD patch-include_CGAL_boost_graph_iterator.h
===> FAILED to apply cleanly FreeBSD patch(es)  patch-include_CGAL_boost_graph_iterator.h
*** Error code 1

Stop.
make: stopped in /usr/ports/databases/sfcgal
=>> Cleaning up wrkdir
===>  Cleaning for sfcgal-1.5.1_1
build of databases/sfcgal | sfcgal-1.5.1_1 ended at Fri Sep  6 21:26:30 UTC 2024
build time: 00:00:04
!!! build failure encountered !!!
triton#
Comment 1 Dennis Clarke 2024-09-08 18:37:28 UTC

Could someone please, for the love of all that is reasonable, please
change the patch file thus : 

t# head files/patch-include_CGAL_boost_graph_iterator.h 
--- ../CGAL-5.6/include/CGAL/boost/graph/iterator.h     2024-02-24 21:04:12 UTC
+++ ../CGAL-5.6/include/CGAL/boost/graph/iterator.h
@@ -214,11 +214,6 @@ class Halfedge_around_source_iterator { (public)
 

Just change that thing and remove the ".1" from the version.
Comment 2 Dimitry Andric freebsd_committer freebsd_triage 2024-09-08 19:07:16 UTC
(In reply to Dennis Clarke from comment #1)
Sorry about that, I messed it up in https://cgit.freebsd.org/ports/commit/?h=2024Q3&id=b733ae96495fdd841d5955ddca4365927ddb5321, which was an MFH of https://cgit.freebsd.org/ports/commit/?id=6a668853ee5c59d92fc9dd6e4d2279d3e5a4eff1, but I had not realized the version number of CGAL was different in the 2024q3 branch.

This port is unusual in the sense that it unpacks _two_ tarballs side-by-side, but patches are always relative to the first unpacked directory. Which is why I had to use ../xxx in the patch files. If somebody knows of a better mechanism to do this in ports, I would be interested. :)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-09-08 19:09:59 UTC
A commit in branch 2024Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b4e7d88d4153cd0b717d1548f1727e34978ff730

commit b4e7d88d4153cd0b717d1548f1727e34978ff730
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-09-08 19:07:39 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-09-08 19:07:42 +0000

    databases/sfcgal: fix patch after MFH

    PR:             281317

 databases/sfcgal/files/patch-include_CGAL_boost_graph_iterator.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 4 Dennis Clarke 2024-09-08 19:14:21 UTC
(In reply to commit-hook from comment #3)

Thank you so much Sir !  This was blocking my ability to get LXDE ( and
other stuff ) built for my local Lenovo laptop. I like to use the poudriere
magic and I have a local pkg build server. So anyways ... yes! Thank you!

I will give the poudriere process a go and then report back. Real soon.

Sadly the pkg server is tied up at the moment with rust etc. 

Dennis Clarke