Bug 31142 - patch-libtool target in bsd.port.mk breaks some ports
Summary: patch-libtool target in bsd.port.mk breaks some ports
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-08 17:50 UTC by Johann Visagie
Modified: 2002-04-25 16:30 UTC (History)
0 users

See Also:

Attachments
file.diff (635 bytes, patch)
2001-10-08 17:50 UTC, Johann Visagie 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Johann Visagie freebsd_committer freebsd_triage 2001-10-08 17:50:00 UTC 
The overly general sed(1) substitution applied in the patch-libtool target of
bsd.port.mk breaks the build process of several packages.  Two examples of
such packages are iODBC (http://www.iodbc.org/) and ORBit-C++
(http://orbitcpp.sourceforge.net).

These packages ship with an autoconf 2.13-generated configure script which
contain the following line:

  ltmain="$ac_aux_dir/ltmain.sh"

The value of ${ltmain} is later tested for file existence in order to
determine whether to build the libtool script:

  if test -f "$ltmain"; then
    <<create libtool>>
  fi

If these packages are wrapped in a port with USE_LIBTOOL defined, the
patch-libtool target in bsd.port.mk munges the line where ${ltmain} is
defined to become:

  ltmain="--disable-ltlibs /usr/local/share/libtool/ltmain.sh"

This of course fails the "test -f", with the result that libtool is never
created and the port build breaks.

The attached patch restricts the scope of the sed(1) substitution to lines
starting with "ltmain=".
Comment 1 Maxim Sobolev freebsd_committer freebsd_triage 2002-04-25 16:30:48 UTC 
State Changed
From-To: open->closed

The problem was resolved in rev.1.410 of bsd.port.mk. Thank you for submission!