Bug 36800 - tvision 0.8 port upgrade breaks libh
Summary: tvision 0.8 port upgrade breaks libh
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-04-05 22:10 UTC by AnarCat
Modified: 2002-05-27 04:06 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (498 bytes, patch)
2002-04-05 22:10 UTC, AnarCat
no flags Details | Diff
file.diff (461 bytes, patch)
2002-04-05 22:10 UTC, AnarCat
no flags Details | Diff
file.diff (281 bytes, patch)
2002-04-05 22:10 UTC, AnarCat
no flags Details | Diff
file.diff (317 bytes, patch)
2002-04-05 22:10 UTC, AnarCat
no flags Details | Diff
file.diff (337 bytes, patch)
2002-04-05 22:10 UTC, AnarCat
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description AnarCat 2002-04-05 22:10:01 UTC
The devel/tvision 0.8 update change endianess handling by using a
header file called "myendian.h" in the tvision source.

For some reason, this file doesn't get installed with tvision. But not
only that, the system.h file from tvision tries to include it using
<myendian.h> which should be instead <tvision/myendian.h>.

The file is also misplaced in the distro.

The errors reported by the libh build look like this:

/usr/local/include/tvision/drawbuf.h:113: myendian.h: No such file or
directory

Fix: Workaround: use tvision 0.7

Fix:

Plan A: (see also plan B below)

1- these diffs go into files/

[files/patch::lib-system.h]

2- 

[files/patch::lib/Makefile.am]

[files/patch::lib-Makefile.in]

4-

[files/patch-lib::drawbuf.h]

5- for some odd reason, the myendian.h file is not with the other
header files (lib/) but in ./ :

6- finally, the pkg-list needs patching:



Plan B: patch system.h to use the old way of doing things:

anarcat@lenny[~/src/ports/distfiles]% diff -u tvision-0.7/lib/system.h tvision-0.8/lib/system.h | grep -5 endian
      */
     uchar buttons;
 };
 
-#ifdef __FreeBSD__
-#include <machine/endian.h>
-#else
-#include <endian.h>
-#endif
+#include <tvision/myendian.h>
 
 /**
- * This structure stores informations about a key.
+ * This structure stores information about a key.
  * @see KeyDownEvent--7nFFF6AhJDFwGQE8NWCLIhbcJ2o9iHHIcPNgMU8mWAZ1SeWA
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- lib/system.h.orig	Fri Apr  5 15:25:19 2002
+++ lib/system.h	Fri Apr  5 15:25:33 2002
@@ -182,7 +182,7 @@
     uchar buttons;
 };
 
-#include <myendian.h>
+#include <tvision/myendian.h>
 
 /**
  * This structure stores information about a key.
How-To-Repeat: 
cd /usr/ports/misc/libh && make
Comment 1 Pete Fritchman freebsd_committer freebsd_triage 2002-05-27 04:06:02 UTC
State Changed
From-To: open->closed

Committed, thanks!