Bug 39319 - Update: SpamAssassin 2.20 -> 2.30
Summary: Update: SpamAssassin 2.20 -> 2.30
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Doug Barton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-06-15 04:40 UTC by Alex Vasylenko
Modified: 2002-06-15 11:07 UTC (History)
0 users

See Also:

Attachments
file.diff (2.00 KB, patch)
2002-06-15 04:40 UTC, Alex Vasylenko 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Vasylenko 2002-06-15 04:40:01 UTC 
	SpamAssassin 2.30 is out, port installs older version (2.20)

How-To-Repeat: 	cd /usr/ports/mail/p5-Mail-SpamAssassin
	make install clean
Comment 1 Doug Barton freebsd_committer freebsd_triage 2002-06-15 05:35:38 UTC 
Responsible Changed
From-To: freebsd-ports->dougb


spam assassin is my new favorite toy, I'll take this one.
Comment 2 Doug Barton freebsd_committer freebsd_triage 2002-06-15 10:58:06 UTC 
State Changed
From-To: open->closed


I updated the port, and I do appreciate your PR submission. 
However, for future reference, you missed a couple things. 

1. No distinfo update. Yes, that's an easy thing for the 
committer to do themselves, however the more complete your 
PR's are, the more likely they are to get committed. 

2. I'm not sure that you tested this very thoroughly. The 
new code has a hard dependency on dccproc, which we have 
no port for, and most users will not have installed on 
their systems. 

3. Please install ports/devel/portlint and learn how to 
use it. At minimum, ports should pass 'portlint -act' 
with no fatal flaws, and as few warnings as possible. 

I certainly don't want to discourage you, please don't get 
the wrong impression. I hope you find these suggestions 
useful, and that we see more PR submissions from 
you in the future.