Bug 41714 - mail/razor-agents: (perl58) does not install man5 files, deletes /usr/local/perllocal.pod on deinstallation(?)
Summary: mail/razor-agents: (perl58) does not install man5 files, deletes /usr/local/p...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Yen-Ming Lee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-08-16 17:30 UTC by Alan E
Modified: 2002-10-21 08:39 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (1.31 KB, patch)
2002-08-16 17:30 UTC, Alan E
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alan E 2002-08-16 17:30:01 UTC
Using perl58 on stable:

1. although it looks like it should, it does not install the man5 files,
   therefore does not generate a package. that's why this marked critical.
   the package did work. now it is broken.

2. deletes ${PREFIX}/lib/perllocal.pod on uninstallation. 


General note to perl module maintainers: you now have a responsibility to make
sure that the module builds, installs, and packages correctly under stable and
perl58 before committing, at least IMO. Thanks, I know it means more work and
that you need to play perl version games, but this is the second instance of
breakage due to untested modules under 5.8 on stable that I have found, in 2
ports I have tried to upgrade. That's 100% failure rate.

Fix: 1. Don't know. Need a perl module install dude.

2. Remove lib/perllocal.pod from pkg-plist.

Temporary fix to make things build:

==8<====8<====8<====8<====8<====8<====8<====8<====8<====8<==
Comment 1 Alan Eldridge 2002-08-16 17:40:24 UTC
On second thought, it appears that the path is just wrong. But I'll
stand by my position that the file should not be in pkg-plist.
-- 
AlanE
KDE-FreeBSD Core Team (http://freebsd.kde.org/)
Comment 2 Alan Eldridge freebsd_committer freebsd_triage 2002-08-16 17:45:32 UTC
Responsible Changed
From-To: freebsd-ports->leeym

Over to maintainer.
Comment 3 Alan Eldridge 2002-08-16 23:38:40 UTC
It appears that perllocal.pod is located in different places depending
on the perl version.

However, it is used to track state; I have confirmed that. 

Therefore, it should not be listed in any pkg-plist, because deleting it damages
the perl local-modules installation.

--
Alan Eldridge
Comment 4 Yen-Ming Lee freebsd_committer freebsd_triage 2002-08-17 04:49:55 UTC
State Changed
From-To: open->feedback

I'll contact the ExtUtils::MakeMaker rewriter/manager to solve this problem.
Comment 5 Giorgos Keramidas freebsd_committer freebsd_triage 2002-08-20 00:31:47 UTC
--- Adding to audit trail:

Message-Id: <20020817134058.GA46783@utopia.leeym.com>
Date: Sat, 17 Aug 2002 21:40:58 +0800
From: Yen-Ming Lee <leeym@leeym.com>
Subject: Re: mail/razor-agents: (perl58) does not install man5 files, deletes /usr/local/perllocal.pod on deinstallation(?)

No matter in perl5.6 or perl5.8, ExtUtils::MakeMaker install MAN1/MAN3 only.
In this case that the author of razor-agents wrap the ExtUtils::MakeMaker and
generate Makefile, by replacing INSTALLMAN1DIR and add MAN5 related settings.

Before perl5.6, the variable used in pure_$(INSTALLDIRS)_install is always
INSTALLDIRS, no matter INSTALLDIRS is "site" or "perl".

In perl5.8, that variable is split into INSTALLMAN1DIR and INSTALLSITEMAN1DIR.
So that perl5.8 only install MAN5 when INSTALLDIRS=perl, and in default
situation (INSTALLDIRS=site), MAN5 is ignored because of that variable is
renamed to INSTALLSITEMAN1DIR, not INSTALLMAN1DIR.

I'll patch the Makefile.PL of razor-agents to add MAN5 related settings by
replace INSTALLMAN1DIR *and* INSTALLSITEMAN1DIR.

regards,

-- 
Yen-Ming Lee


Message-Id: <20020817155259.GB58748@wwweasel.geeksrus.net>
Date: Sat, 17 Aug 2002 11:52:59 -0400
From: Alan E <alane@geeksrus.net>
Subject: Re: mail/razor-agents: (perl58) does not install man5 files, deletes /usr/local/perllocal.pod on deinstallation(?)

Is this the right thing to do? This is possibly a common problem across
other ports. And you're talking conditional patches, here, right? Or
will they work with system perl, too?

We might want to consider, instead, conditionally adding a
post-install:: (note that I've got two colons) to do the MAN5 stuff.
THey get manified, just not installed. Hold off until I can investigate
some more.

Checking perl version is another sticky issue, anyway, so let me have a
crack at that and then we'll come back to this. I'll mail you later
today or tomorrow.

-- 
AlanE
KDE-FreeBSD Core Team (http://freebsd.kde.org/)
Comment 6 Yen-Ming Lee freebsd_committer freebsd_triage 2002-10-21 08:37:21 UTC
State Changed
From-To: feedback->closed

both two problems were fixed, thanks.