Bug 42096 - scrollkeeper port fails install because of find -L
Summary: scrollkeeper port fails install because of find -L
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-08-27 22:20 UTC by John-David Childs
Modified: 2002-08-28 03:49 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John-David Childs 2002-08-27 22:20:01 UTC
scrollkeeper port fails to complete installation (hangs). find -L ${PREFIX} (/usr/local) appears to hang, even when done manually, and the scrollkeeper port uses this syntax to find the prefix for the DocBook DTD.  Because scrollkeeper fails/hangs, the entire installation of Gnome2 fails.

Fix: 

remove -L from find command in pkg-install
How-To-Repeat: cd /usr/ports/textproc/scrollkeeper
sudo make
Comment 1 Joe Marcus Clarke freebsd_committer freebsd_triage 2002-08-27 22:23:53 UTC
Responsible Changed
From-To: freebsd-ports->gnome

Over to maintainers.
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2002-08-27 22:24:09 UTC
State Changed
From-To: open->feedback
Comment 3 Joe Marcus Clarke freebsd_committer freebsd_triage 2002-08-27 22:34:41 UTC
Can you test the attached patch to pkg-install, and let me know if it
works for you?  Thanks.

Index: pkg-install
===================================================================
RCS file: /home/ncvs/ports/textproc/scrollkeeper/pkg-install,v
retrieving revision 1.2
diff -u -r1.2 pkg-install
--- pkg-install	1 Jul 2002 04:51:13 -0000	1.2
+++ pkg-install	27 Aug 2002 21:31:49 -0000
@@ -47,7 +47,7 @@
 #
 # find the prefix for DocBook DTD
 #
-found=`find -L ${PREFIX} -name docbookx.dtd 2> /dev/null`
+found=`find ${PREFIX}/ -name docbookx.dtd 2> /dev/null`
 if [ "$found" = "" ] ; then
     echo could not locate docbookx.dtd for DocBook XML
     exit 1
@@ -119,7 +119,7 @@
 #
 top=`dirname $docbookdir`
 found=`find $top -iname "iso*amsb.ent" 2> /dev/null`
-found=`find -L ${PREFIX} -iname "iso*amsb.ent" 2> /dev/null`
+found=`find ${PREFIX}/ -iname "iso*amsb.ent" 2> /dev/null`
 if [ "$found" = "" ] ; then
     echo could not locate iso-amsb.ent of ISO DocBook entities
     exit 1
@@ -208,7 +208,7 @@
 #
 top=`dirname $docbookdir`
 found=`find $top -name chunk.xsl 2> /dev/null`
-found=`find -L ${PREFIX} -name chunk.xsl 2> /dev/null`
+found=`find ${PREFIX} -name chunk.xsl 2> /dev/null`
 if [ "$found" = "" ] ; then
     echo could not locate chunk-common.xsl of DocBook XSLT stylesheets
     exit 1
Comment 4 jdc 2002-08-27 23:06:03 UTC
As a matter of fact, that's exactly what I did (manually) to make it
work.  I should have included it as a patch.


On Tue, 2002-08-27 at 15:34, Joe Marcus Clarke wrote:
> Can you test the attached patch to pkg-install, and let me know if it
> works for you?  Thanks.
> 
> Index: pkg-install
> ===================================================================
> RCS file: /home/ncvs/ports/textproc/scrollkeeper/pkg-install,v
> retrieving revision 1.2
> diff -u -r1.2 pkg-install
> --- pkg-install	1 Jul 2002 04:51:13 -0000	1.2
> +++ pkg-install	27 Aug 2002 21:31:49 -0000
> @@ -47,7 +47,7 @@
>  #
>  # find the prefix for DocBook DTD
>  #
> -found=`find -L ${PREFIX} -name docbookx.dtd 2> /dev/null`
> +found=`find ${PREFIX}/ -name docbookx.dtd 2> /dev/null`
>  if [ "$found" = "" ] ; then
>      echo could not locate docbookx.dtd for DocBook XML
>      exit 1
> @@ -119,7 +119,7 @@
>  #
>  top=`dirname $docbookdir`
>  found=`find $top -iname "iso*amsb.ent" 2> /dev/null`
> -found=`find -L ${PREFIX} -iname "iso*amsb.ent" 2> /dev/null`
> +found=`find ${PREFIX}/ -iname "iso*amsb.ent" 2> /dev/null`
>  if [ "$found" = "" ] ; then
>      echo could not locate iso-amsb.ent of ISO DocBook entities
>      exit 1
> @@ -208,7 +208,7 @@
>  #
>  top=`dirname $docbookdir`
>  found=`find $top -name chunk.xsl 2> /dev/null`
> -found=`find -L ${PREFIX} -name chunk.xsl 2> /dev/null`
> +found=`find ${PREFIX} -name chunk.xsl 2> /dev/null`
>  if [ "$found" = "" ] ; then
>      echo could not locate chunk-common.xsl of DocBook XSLT stylesheets
>      exit 1
>
Comment 5 Joe Marcus Clarke freebsd_committer freebsd_triage 2002-08-27 23:20:38 UTC
On Tue, 2002-08-27 at 18:06, John-David Childs wrote:
> As a matter of fact, that's exactly what I did (manually) to make it
> work.  I should have included it as a patch.

Including the trailing '/' after the directories?  That's really what I
wanted you to test.

Joe

> 
> 
> On Tue, 2002-08-27 at 15:34, Joe Marcus Clarke wrote:
> > Can you test the attached patch to pkg-install, and let me know if it
> > works for you?  Thanks.
> > 
> > Index: pkg-install
> > ===================================================================
> > RCS file: /home/ncvs/ports/textproc/scrollkeeper/pkg-install,v
> > retrieving revision 1.2
> > diff -u -r1.2 pkg-install
> > --- pkg-install	1 Jul 2002 04:51:13 -0000	1.2
> > +++ pkg-install	27 Aug 2002 21:31:49 -0000
> > @@ -47,7 +47,7 @@
> >  #
> >  # find the prefix for DocBook DTD
> >  #
> > -found=`find -L ${PREFIX} -name docbookx.dtd 2> /dev/null`
> > +found=`find ${PREFIX}/ -name docbookx.dtd 2> /dev/null`
> >  if [ "$found" = "" ] ; then
> >      echo could not locate docbookx.dtd for DocBook XML
> >      exit 1
> > @@ -119,7 +119,7 @@
> >  #
> >  top=`dirname $docbookdir`
> >  found=`find $top -iname "iso*amsb.ent" 2> /dev/null`
> > -found=`find -L ${PREFIX} -iname "iso*amsb.ent" 2> /dev/null`
> > +found=`find ${PREFIX}/ -iname "iso*amsb.ent" 2> /dev/null`
> >  if [ "$found" = "" ] ; then
> >      echo could not locate iso-amsb.ent of ISO DocBook entities
> >      exit 1
> > @@ -208,7 +208,7 @@
> >  #
> >  top=`dirname $docbookdir`
> >  found=`find $top -name chunk.xsl 2> /dev/null`
> > -found=`find -L ${PREFIX} -name chunk.xsl 2> /dev/null`
> > +found=`find ${PREFIX} -name chunk.xsl 2> /dev/null`
> >  if [ "$found" = "" ] ; then
> >      echo could not locate chunk-common.xsl of DocBook XSLT stylesheets
> >      exit 1
> > 
> 
> 
> 
>
Comment 6 jdc 2002-08-28 01:34:58 UTC
On Tue, 2002-08-27 at 16:20, Joe Marcus Clarke wrote:
> On Tue, 2002-08-27 at 18:06, John-David Childs wrote:
> > As a matter of fact, that's exactly what I did (manually) to make it
> > work.  I should have included it as a patch.
> 
> Including the trailing '/' after the directories?  That's really what I
> wanted you to test.

The trailing slash did appear to work.  (I pkg_deleted scrollkeeper,
patched pkg-install, rm -rf scrollkeeper/work, and did a sudo make
install from the textproc/scrollkeeper directory).

On a completely different system, the find -L didn't cause a problem at
all, but the fact that I don't have -lgiconv broke the build (XSLT_LIB
in config.status).  I believe there's an existing PR for that. I
pkg_deleted libxslt-1.0.12 and installed 1.0.20, and I was able to
compile/install scrollkeeper with the find -L.


> 
> Joe
> 
> > 
> > 
> > On Tue, 2002-08-27 at 15:34, Joe Marcus Clarke wrote:
> > > Can you test the attached patch to pkg-install, and let me know if it
> > > works for you?  Thanks.
> > > 
> > > Index: pkg-install
> > > ===================================================================
> > > RCS file: /home/ncvs/ports/textproc/scrollkeeper/pkg-install,v
> > > retrieving revision 1.2
> > > diff -u -r1.2 pkg-install
> > > --- pkg-install	1 Jul 2002 04:51:13 -0000	1.2
> > > +++ pkg-install	27 Aug 2002 21:31:49 -0000
> > > @@ -47,7 +47,7 @@
> > >  #
> > >  # find the prefix for DocBook DTD
> > >  #
> > > -found=`find -L ${PREFIX} -name docbookx.dtd 2> /dev/null`
> > > +found=`find ${PREFIX}/ -name docbookx.dtd 2> /dev/null`
> > >  if [ "$found" = "" ] ; then
> > >      echo could not locate docbookx.dtd for DocBook XML
> > >      exit 1
> > > @@ -119,7 +119,7 @@
> > >  #
> > >  top=`dirname $docbookdir`
> > >  found=`find $top -iname "iso*amsb.ent" 2> /dev/null`
> > > -found=`find -L ${PREFIX} -iname "iso*amsb.ent" 2> /dev/null`
> > > +found=`find ${PREFIX}/ -iname "iso*amsb.ent" 2> /dev/null`
> > >  if [ "$found" = "" ] ; then
> > >      echo could not locate iso-amsb.ent of ISO DocBook entities
> > >      exit 1
> > > @@ -208,7 +208,7 @@
> > >  #
> > >  top=`dirname $docbookdir`
> > >  found=`find $top -name chunk.xsl 2> /dev/null`
> > > -found=`find -L ${PREFIX} -name chunk.xsl 2> /dev/null`
> > > +found=`find ${PREFIX} -name chunk.xsl 2> /dev/null`
> > >  if [ "$found" = "" ] ; then
> > >      echo could not locate chunk-common.xsl of DocBook XSLT stylesheets
> > >      exit 1
> > > 
> > 
> > 
> > 
> > 
>
Comment 7 Joe Marcus Clarke freebsd_committer freebsd_triage 2002-08-28 03:49:03 UTC
State Changed
From-To: feedback->closed

This has been fixed.