Bug 42972 - --with-ssl is not supported by /usr/ports/irc/bitchx makefile
Summary: --with-ssl is not supported by /usr/ports/irc/bitchx makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Tilman Keskinoz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-09-19 23:40 UTC by Bob Fleck
Modified: 2002-10-25 10:57 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bob Fleck 2002-09-19 23:40:01 UTC
The ports Makefile for BitchX (/usr/ports/irc/bitchx) does not support building BitchX with SSL support.  The version of the client in the distfile does however.  Support to pass this flag should be added to the
Makefile.

Fix: 

I propose adding -DWITH_SSL as a make flag for the port.  This should
pass --with-ssl to the configure script.  I've tested this, but my patch
to the makefile was not clean.  If you want me to clean it up and send
diffs, drop me an email at bob@securesoftware.com
Comment 1 Bob Fleck 2002-09-20 00:54:17 UTC
If anyone wants an easy patch to slip in before the ports freeze,  I've
revisited my PR of this afternoon for BitchX. I have patched up the
Makefile so the port builds using ssl when you `make -DWITH_SSL`.

Bob Fleck

Patch follows:

--- Makefile.orig       Thu Sep 19 19:32:44 2002
+++ Makefile    Thu Sep 19 19:36:20 2002
@@ -76,6 +76,9 @@
 CONFIGURE_ARGS+=       --with-socks5=${LOCALBASE}
 CONFIGURE_ENV+=                CPPFLAGS="-I${LOCALBASE}/include"
 .endif
+.if defined(WITH_SSL)
+CONFIGURE_ARGS+=--with-ssl
+.endif
 .if defined(WITH_PLUGINS)
 PLUGINS=      
abot,acro,aim,arcfour,autocycle,blowfish,cavlink,encrypt,fserv,hint,identd,nap,pkga,possum,qbx,qmail,scan,wavplay
 PLIST_SUB+=    PLUGINS:=""
@@ -119,6 +122,9 @@
 .endif
 .if !defined(WITH_SOCKS5)
        @${ECHO_CMD} "WITH_SOCKS5  - Build BitchX with SOCKS5 support"
+.endif
+.if !defined(WITH_SSL)
+       @${ECHO_CMD} "WITH_SSL     - Build BitchX with SSL support"
 .endif
 .if !defined(WITH_IPV6)
        @${ECHO_CMD} "WITH_IPV6    - Build BitchX with IPV6 support"
Comment 2 Tilman Keskinoz freebsd_committer freebsd_triage 2002-10-17 10:35:06 UTC
Responsible Changed
From-To: freebsd-ports->arved

I am the Maintainer, so i should look at this. 
Bob, if you had  CCed me, this PR may have been handled earlier.
Comment 3 Tilman Keskinoz freebsd_committer freebsd_triage 2002-10-25 10:56:05 UTC
State Changed
From-To: open->closed

Committed, thanks.