Bug 46148 - update SFS port to 0.7.1, current port broken on -STABLE/CURRENT
Summary: update SFS port to 0.7.1, current port broken on -STABLE/CURRENT
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pete Fritchman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-12-09 16:50 UTC by Michael Handler
Modified: 2003-01-02 06:24 UTC (History)
0 users

See Also:


Attachments
file.diff (18.05 KB, patch)
2002-12-09 16:50 UTC, Michael Handler
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Handler 2002-12-09 16:50:00 UTC
The current SFS port doesn't build at all on -CURRENT or -STABLE; this patch
updates the port for the latest SFS version and compiles perfectly on
those platforms.
Comment 1 Pete Fritchman freebsd_committer freebsd_triage 2002-12-10 05:01:52 UTC
State Changed
From-To: open->feedback

skull(~/cvs/sfs) [57] > make 

Comment 3 dean 2002-12-12 09:59:30 UTC
Port security/sfs builds correctly with Bison 1.35, not with 1.75.
Comment 4 Michael Handler 2002-12-12 16:08:43 UTC
Dean Strik <dean@dragon.stack.nl> writes:

> Port security/sfs builds correctly with Bison 1.35, not with 1.75.

I built it fine with bison 1.75 on FreeBSD 4.7-STABLE #0: Wed Nov
20 01:26:12 EST 2002. My copy of bison was built from ports
(devel/bison), so there's nothing special about it.

What platform and FreeBSD release are you trying to compile on?
Comment 5 petef 2002-12-22 20:39:32 UTC
Hmm, I can't get this to build on a fairly recent -current:

checking for nfs_args mount structure... no
configure: error: Could not find NFS mount argument structure!
===>  Script "configure" failed unexpectedly.
      Please report the problem to handler@grendel.net [maintainer] and attach
      the "/usr/home/petef/cvs/sfs/work/sfs-0.7.1/config.log" including the
      output of the failure of your make command. Also, it might be a good
      idea to provide an overview of all packages installed on your system
      (e.g. an `ls /var/db/pkg`).
*** Error code 1

Stop in /usr/home/petef/cvs/sfs.

You can find the config.log file at

    http://absolutbsd.org/petef/sfs-config.log

Thanks,

--pete
Comment 6 Michael Handler 2002-12-25 02:37:32 UTC
> Hmm, I can't get this to build on a fairly recent -current:

Er. By my reading of this log:

In file included from nfsconf.h:33,
                 from configure:9705:
/usr/include/nfs/nfs.h:200: field `nsd_cr' has incomplete type

There's no nfs/nfs.h file on my friend's -CURRENT system (FreeBSD
5.0-CURRENT #91: Tue Nov 19 08:04:07 EST 2002), and by my reading
of cvsweb, there shouldn't be one on yours. I'm guessing this file
dates back to the NFS client/server code split, and is ancient.
Can I get a time and date stamp on it, and a CVS tag?

Can you mv /usr/include /usr/include.old and rerun make installworld
from your build tree to make sure that we've got clean correct
headers, and try rebuilding?
Comment 7 Michael Handler 2002-12-25 02:56:49 UTC
Talk about trying to hit a moving target; sfs 0.7.2 came out while we
were working through this.

Here's a complete tarball of the current state of the port as
desired. Please don't just up the PORTVERSION to 0.7.2; there are
some improvements in the Makefile and the documentation too.

http://www.grendel.net/handler/pub/sfs-port/sfs-port-20021224-1.tar

Please test this on your system (after correcting /usr/include),
and commit this. Note that you'll need to delete the files
patch-async_malloc.C, patch-parse.yy, and patch-scan.ll into Attic,
as they've been obsoleted.
Comment 8 Michael Handler 2002-12-31 17:22:07 UTC
where do we stand on getting this port committed? --handler
Comment 9 petef 2003-01-01 19:32:24 UTC
Still getting errors; can you maybe provide a patch to get rid of
-Werror?

gmake[2]: Entering directory `/usr/home/petef/cvs/sfs/work/sfs-0.7.1/sfsauthd'
c++ -DHAVE_CONFIG_H -I. -I. -I..   -I/usr/local/include -I.. -I../async -I../arpc -I../crypt -I../sfsmisc -I../sfsrodb -I../adb -I../svc -I../svc -DEXECDIR=\"/usr/local/lib/sfs-0.7.1\" -DETCDIR=\"/usr/local/etc/sfs\" -DDATADIR=\"/usr/local/share/sfs\" -DPIDDIR=\"/var/run\" -DSFSDIR=\"/var/spool/sfs\"  -O -pipe -mcpu=pentiumpro -Wall -Werror  -c sfsdeclog.C
cc1plus: warnings being treated as errors
sfsdeclog.C: In function `void writewait(int)':
sfsdeclog.C:49: warning: comparison between signed and unsigned integer 
   expressions
gmake[2]: *** [sfsdeclog.o] Error 1
gmake[2]: Leaving directory `/usr/home/petef/cvs/sfs/work/sfs-0.7.1/sfsauthd'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/home/petef/cvs/sfs/work/sfs-0.7.1'
gmake: *** [all-recursive-am] Error 2
*** Error code 2

Stop in /usr/home/petef/cvs/sfs.
skull(~/cvs/sfs) [27] > 

--pete
Comment 10 Michael Handler 2003-01-01 20:32:13 UTC
> gmake[2]: Entering directory `/usr/home/petef/cvs/sfs/work/sfs-0.7.1/sfsauthd'

you're still compiling 0.7.1, not 0.7.2. please blow away that
directory, and grab the port tarball from:

http://www.grendel.net/handler/pub/sfs-port/sfs-port-20021224-1.tar

and test that port, as it's the latest version of the port which
encompasses the latest version of SFS. (mail about this was sent
to the PR on 2002-12-24.)
Comment 11 petef 2003-01-01 21:29:47 UTC
Same error:

Making all in sfsauthd
gmake[2]: Entering directory `/usr/home/petef/cvs/sfs/work/sfs-0.7.2/sfsauthd'
c++ -DHAVE_CONFIG_H -I. -I. -I..   -I/usr/local/include -I.. -I../async -I../arpc -I../crypt -I../sfsmisc -I../sfsrodb -I../adb -I../svc -I../svc -DEXECDIR=\"/usr/local/lib/sfs-0.7.2\" -DETCDIR=\"/usr/local/etc/sfs\" -DDATADIR=\"/usr/local/share/sfs\" -DPIDDIR=\"/var/run\" -DSFSDIR=\"/var/spool/sfs\"  -O -pipe -mcpu=pentiumpro -Wall -Werror  -c sfsdeclog.C
cc1plus: warnings being treated as errors
sfsdeclog.C: In function `void writewait(int)':
sfsdeclog.C:49: warning: comparison between signed and unsigned integer 
   expressions
gmake[2]: *** [sfsdeclog.o] Error 1
gmake[2]: Leaving directory `/usr/home/petef/cvs/sfs/work/sfs-0.7.2/sfsauthd'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/home/petef/cvs/sfs/work/sfs-0.7.2'
gmake: *** [all-recursive-am] Error 2
*** Error code 2

Stop in /usr/home/petef/cvs/sfs.
skull(~/cvs/sfs) [59] > 

--pete
Comment 12 Michael Handler 2003-01-01 23:22:58 UTC
> sfsdeclog.C:49: warning: comparison between signed and unsigned integer 
>    expressions

fixed with a patch to the function's prototype. tests a-ok on FreeBSD
5.0-CURRENT #93: Tue Dec 31 13:45:07 EST 2002 and 4.7-STABLE #0:
Wed Nov 20 01:26:12 EST 2002. new port:

http://www.grendel.net/handler/pub/sfs-port/sfs-port-20030101-1.tar
Comment 13 Pete Fritchman freebsd_committer freebsd_triage 2003-01-02 06:24:31 UTC
State Changed
From-To: feedback->closed

Committed, thanks!