Bug 46722 - [patch] fix emulators/wine on current
Summary: [patch] fix emulators/wine on current
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Gerald Pfeifer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-01-03 13:30 UTC by Stefan Farfeleder
Modified: 2003-01-03 17:40 UTC (History)
1 user (show)

See Also:


Attachments
patch-aa (300 bytes, text/plain)
2003-01-03 13:30 UTC, Stefan Farfeleder
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Farfeleder 2003-01-03 13:30:00 UTC
A test program of Wine tries to include <malloc.h> instead of <stdlib.h> and
stumbles over an #error directive in <malloc.h>.

Fix: I called the diff patch-aa because I could not discover any consistent naming
scheme in ports/emulators/wine/files.  Feel free to rename it however you like.
	
How-To-Repeat: cd /usr/ports/emulators/wine && make

<...>

gmake[3]: Entering directory `/freebsd/ports/emulators/wine/work/wine-20021219/dlls/winmm/tests'
cc -c -I. -I. -I../../../include -I../../../include  -O -pipe -mcpu=pentiumpro -g -Wall -mpreferred-stack-boundary=2  -fPIC -DNONAMELESSUNION -DNONAMELESSSTRUCT  -D_REENTRANT -D_THREAD_SAFE -o wave.o wave.c
In file included from wave.c:21:
/usr/include/malloc.h:3:2: #error "<malloc.h> has been replaced by <stdlib.h>"
wave.c: In function `wave_generate_la':
wave.c:77: warning: implicit declaration of function `malloc'
wave.c:77: warning: assignment makes pointer from integer without a cast
wave.c: In function `wave_out_test_deviceOut':
wave.c:170: warning: implicit declaration of function `free'
gmake[3]: *** [wave.o] Error 1
gmake[3]: Leaving directory `/freebsd/ports/emulators/wine/work/wine-20021219/dlls/winmm/tests'
gmake[2]: *** [tests] Error 2
gmake[2]: Leaving directory `/freebsd/ports/emulators/wine/work/wine-20021219/dlls/winmm'
gmake[1]: *** [winmm] Error 2
gmake[1]: Leaving directory `/freebsd/ports/emulators/wine/work/wine-20021219/dlls'
gmake: *** [dlls] Error 2
*** Error code 2
Comment 1 Tilman Keskinoz freebsd_committer freebsd_triage 2003-01-03 13:56:34 UTC
Responsible Changed
From-To: freebsd-ports->gerald

Over to Maintainer
Comment 2 Gerald Pfeifer freebsd_committer freebsd_triage 2003-01-03 17:22:39 UTC
State Changed
From-To: open->closed

Committed as patch-dlls-winmm, thanks! 

(Basically there were two problems here: Wine developers not caring too much 
about portability, and FreeBSD developers intentionally breaking portability 
from non standards-compliant systems.)