Bug 48192 - www/p5-Apache-Gallery misuses TEMPLATES, breaks readme target
Summary: www/p5-Apache-Gallery misuses TEMPLATES, breaks readme target
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-12 00:50 UTC by Bruce A. Mah
Modified: 2003-02-12 20:48 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bruce A. Mah 2003-02-12 00:50:08 UTC
The www/p5-Apache-Gallery port defines a TEMPLATES Makefile variable.
Unfortunately this variable is used in bsd.port.mk to help locate
files used by "make readme".

Among other things, this prevents a release build that includes
a ports tree.

Fix: 

Rename the port's TEMPLATES variable?
How-To-Repeat: 
nimitz:p5-Apache-Gallery% sudo make readme
===>   Creating README.html for p5-Apache-Gallery-0.5.1
sed: directory.tpl: No such file or directory
sed: error.tpl: No such file or directory
sed: index.tpl: No such file or directory
sed: info.tpl: No such file or directory
sed: layout.tpl: No such file or directory
sed: movie.tpl: No such file or directory
sed: navpicture.tpl: No such file or directory
sed: orig.tpl: No such file or directory
sed: picture.tpl: No such file or directory
sed: scale.tpl: No such file or directory
sed: showpicture.tpl/README.port: No such file or directory
*** Error code 1

Stop in /usr/ports/www/p5-Apache-Gallery.
*** Error code 1

Stop in /usr/ports/www/p5-Apache-Gallery.
Comment 1 Erwin Lansing 2003-02-12 07:55:37 UTC
On Tue, Feb 11, 2003 at 04:49:46PM -0800, Bruce A. Mah wrote:
> 
> >Description:
> 
> The www/p5-Apache-Gallery port defines a TEMPLATES Makefile variable.
> Unfortunately this variable is used in bsd.port.mk to help locate
> files used by "make readme".
> 
> Among other things, this prevents a release build that includes
> a ports tree.
> 
> >Fix:
> 
> Rename the port's TEMPLATES variable?
> 

That would be the easiest, patch at
http://panda.droso.net/~erwin/p5-Apache-Gallery-TEMPLATE.diff

Thanks for catching this!

-erwin

-- 
                    _._     _,-'""`-._
Erwin Lansing      (,-.`._,'(       |\`-/|    http://droso.org/
erwin@lansing.dk       `-.-' \ )-`( , o o)    http://fnidder.dk/
                    -bf-      `-    \`_`"'-
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2003-02-12 20:48:09 UTC
State Changed
From-To: open->closed

Commited, thanks!