Bug 50688 - [PATCH] www/apache13-modssl fails to install
Summary: [PATCH] www/apache13-modssl fails to install
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-04-07 19:10 UTC by Michael O. Boev
Modified: 2003-04-07 19:33 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael O. Boev 2003-04-07 19:10:05 UTC
	Installation of the port fails at the pre-install stage
when it tries to execute the pkg-install script.
The script resides in the ports tree and but not in the WRKDIR

Fix: We can use the (standard?) technique of executing pkg-install by 
referencing it indirectly (through $PKGINSTALL macro), as is done in
net/cvsupit, for example

please, find the patch that makes that change:



pre-install:
-       PKG_PREFIX=${PREFIX} ${SH} pkg-install ${PKGNAME} PRE-INSTALL
+       @PKG_PREFIX=${PREFIX} ${PKGINSTALL} ${PKGNAME} PRE-INSTALL

 post-install:
        ${INSTALL_DATA} ${WRKSRC}/apache.sh ${PREFIX}/etc/rc.d/apache.sh-dist--Rcww6mauuKggSznqQiL7ro2sZcnmIoC5gku3JtNc8paNKo74
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- www/apache13-modssl/Makefile.orig   Tue Apr  8 00:30:22 2003
+++ www/apache13-modssl/Makefile        Tue Apr  8 00:43:17 2003
@@ -147,7 +147,7 @@
        && ${MAKE} certificate TYPE=${TYPE} CRT=${CRT} KEY=${KEY}
How-To-Repeat: 	cd /usr/ports/www/apache13-modssl
	make
	make install
	<breaks here>
Comment 1 Michael O. Boev 2003-04-07 19:27:54 UTC
It is also doubtable whether this script needs the PKG_PREFIX defined.

So, I'd suggest the second version of the patch:

 --- www/apache13-modssl/Makefile.orig   Tue Apr  8 00:30:22 2003
+++ www/apache13-modssl/Makefile        Tue Apr  8 00:43:17 2003
@@ -147,7 +147,7 @@
        && ${MAKE} certificate TYPE=${TYPE} CRT=${CRT} KEY=${KEY}

 pre-install:
-       PKG_PREFIX=${PREFIX} ${SH} pkg-install ${PKGNAME} PRE-INSTALL
+       @${PKGINSTALL} ${PKGNAME} PRE-INSTALL

 post-install:
        ${INSTALL_DATA} ${WRKSRC}/apache.sh
${PREFIX}/etc/rc.d/apache.sh-dist

Best wishes,
Mike Boev.
Comment 2 Dirk Meyer freebsd_committer freebsd_triage 2003-04-07 19:31:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->dinoex

I will take care of it.
Comment 3 Dirk Meyer freebsd_committer freebsd_triage 2003-04-07 19:33:15 UTC
State Changed
From-To: open->closed

committed, thanks.