Bug 50756 - ftp/ncftp3 : options in Makefile.local are ignored
Summary: ftp/ncftp3 : options in Makefile.local are ignored
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: David E. O'Brien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-04-09 15:40 UTC by Ralf van Dooren
Modified: 2003-04-19 01:13 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf van Dooren 2003-04-09 15:40:09 UTC 
        Options you put in  Makefile.local are ignored, for installation.
        This will cause local settings for ncftp3 to be ignored.

	oerania# cd /usr/ports/ftp/ncftp3
	oerania# echo "INSTALL_AS_NCFTP=yes" > Makefile.local
	oerania# make -V INSTALL_AS_NCFTP
	yes
	oerania# make -V LATEST_LINK
	ncftp3
        oerania#

Fix: By separating bsd.ports.mk into bsd.ports.pre.mk and bsd.ports.post.mk
        the problem will be fixed.

	The following patch can be used to correct this:



+.include <bsd.port.pre.mk>
+
 .if defined(INSTALL_AS_NCFTP)
 LATEST_LINK=   ncftp
 .else
@@ -69,4 +71,4 @@
                ${PREFIX}/man/man1
        @${INSTALL_MAN} ${WRKSRC}/Strn/Strn.3 ${PREFIX}/man/man3

-.include <bsd.port.mk>
+.include <bsd.port.post.mk>--rJNTd0T9MsDdcnIqchfJN84qCXlgf50MXNVHJeJHutYKI3oD
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Makefile.orig       Wed Apr  9 16:07:27 2003
+++ Makefile    Wed Apr  9 16:30:56 2003
@@ -20,6 +20,8 @@
 MAINTAINER=    obrien@FreeBSD.org
 COMMENT=       ftp replacement with advanced user interface
How-To-Repeat: 
	Enter the above commands.
Comment 1 Tilman Keskinoz freebsd_committer freebsd_triage 2003-04-09 18:29:49 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->obrien

Over to maintainer
Comment 2 David E. O'Brien freebsd_committer freebsd_triage 2003-04-19 01:13:22 UTC 
State Changed
From-To: open->closed

committed