A native Acqua-like window decoration for KDE3, with window drop shadows by David Sansome.
>> (04.15.2003 @ 1450 PST): Brian Skrab said, in 3.0K: << > XDISTNAME= ${PORTNAME}-${PORTVERSION} This is implied, and thus this definition is redundant. > XGNU_CONFIGURE= yes > XUSE_GMAKE= yes > XUSE_KDEBASE_VER=3 > XUSE_BZIP2= yes Your port installs both shared libraries and libtool archives. Are you sure you want the libtool archives installed? If you want both installed, you must define: INSTALLS_SHLIB= yes USE_LIBTOOL= yes which will make GNU_CONFIGURE irrelevant > XA native Acqua-like window decoration for KDE3, with window drop shadows by > XDavid Sansome. Wait. Did David Sansome just develop the window drop shadows, or did he make the entire application? Your description implies he only made the drop shadows. > sed 's/^X//' >aquaosk/pkg-plist << 'END-of-aquaosk/pkg-plist' > Xlib/kde3 > Xlib/kde3/libkwinaqua_config.so > Xlib/kde3/libkwinaqua_config.la > Xlib/kde3/libkwinaqua.so > Xlib/kde3/libkwinaqua.la > Xshare/apps > Xshare/apps/kwin > Xshare/apps/kwin/aqua.desktop OK, you have 3 directories listed as files in here. lib/kde3, share/apps and share/apps/kwin are not files that get installed by the program, so why do you list them as such? If a directory gets installed by a program (which this list implies this program does not), they get listed as @dirrm's. Otherwise, the directories shouldn't appear in this list. Did you try to uninstall this program yourself? root@smacky:/usr/ports/x11-wm/aquaosk# PREFIX=/tmp/acq make deinstall ===> Deinstalling for aquaosk-2.0 pkg_delete: cannot delete specified file '/usr/local/lib/kde3' - it is a directory! this packing list is incorrect - ignoring delete request pkg_delete: cannot delete specified file '/usr/local/share/apps' - it is a directory! this packing list is incorrect - ignoring delete request pkg_delete: cannot delete specified file '/usr/local/share/apps/kwin' - it is a directory! this packing list is incorrect - ignoring delete request And, this brings up one other point: this port does not honor ${PREFIX}. I love window decoration ports... I like eyecandy ;;) Please fix these things so we can add this port! # Adam -- Adam Weinberger vectors.cx >> adam@vectors.cx FreeBSD.org << adamw@FreeBSD.ORG #vim:set ts=8: 8-char tabs prevent tooth decay.
Adam, I'm just checking in to see if you received my previous reply to your port revision message, that I received on the 15th. I just wanted to touch base, since it's been a week. Thanks, ~brian == 04/16/03 11:56 am ======================================= Adam, Thanks for your quick reply to the submission. I believe that I made a very stupid mistake and submitted a previous, un-polished version of the port. I have included the new version, along with your recommended changes with this message. On Tuesday 15 April 2003 10:48 pm, you wrote: > Your port installs both shared libraries and libtool archives. Are you > sure you want the libtool archives installed? If you want both > installed, you must define: > INSTALLS_SHLIB= yes > USE_LIBTOOL= yes I believe that the libtool archives are required. There appear to be corresponding archives in the same location for other window decorations that are installed on the system. I have added the two lines you mention above to the Makefile. > > XA native Acqua-like window decoration for KDE3, with window drop shadows > > by XDavid Sansome. > > Wait. Did David Sansome just develop the window drop shadows, or did he > make the entire application? Your description implies he only made the > drop shadows. I have enhanced the port description to include a little more information about the supported features. Thus, the implication above has been removed. > OK, you have 3 directories listed as files in here. lib/kde3, share/apps > and share/apps/kwin are not files that get installed by the program, so > why do you list them as such? If a directory gets installed by a program > (which this list implies this program does not), they get listed as > @dirrm's. Otherwise, the directories shouldn't appear in this list. Did > you try to uninstall this program yourself? This was a remnant of the quick-and-dirty port that I mistakenly submitted -- duh. As a note, because the directories that this port installs its components into are used by other ports, I used "@unexec rmdir %%PREFIX%%/dir 2>/dev/null || true" in place of @dirrm /dir. Using @dirrm on non-empty directories results in a misleading error message regarding the validity of the packing list. > And, this brings up one other point: this port does not honor ${PREFIX}. Yet again, my earlier attempt rears its ugly head. > I love window decoration ports... I like eyecandy ;;) Please fix these > things so we can add this port! Thank you for taking interest in this port, and for taking the time to wade through my mistakes. I believe that this new version addresses all of the errors that you identified. ~brian
Is the submitter still interested in this PR? It is over 6 months old now. (I am trying to go through some of the older ports PRs in GNATS).
Yes, the submitter is still interested in having this port reviewed, and hopefully committed. I have attached the last revision I made to the port after a short correspondence with Adam Weinberger regarding this PR. Please let me know if there is anything else that is required to have this port accepted. Thank you, ~brian On Sunday 09 November 2003 10:34 pm, Mark Linimon wrote: > Is the submitter still interested in this PR? It is over 6 months > old now. (I am trying to go through some of the older ports PRs > in GNATS).
Responsible Changed From-To: freebsd-ports-bugs->linimon I'll commit this after checking on 5.x (4.x is ok as is).
State Changed From-To: open->closed Committed, thanks for being patient.