On my box, scrollkeeper refuses to build, as it cannot find docbookx.dtd, etc. I note that in the second chunk of the patch, two finds are run, the first appears to be redundant. I have left this, since it's not causing a problem right now, but is it cruft? Fix: The patch adds -follow to the relevant find commands. How-To-Repeat: Attempt to install scrollkeeper with the above config. Any of portupgrade down to make install will fail
State Changed From-To: open->closed Committed, thanks! In the future, though, when doing a diff it's: diff -u <orig file> <new file> Your diff effectively backed out the changes you wanted to make.
Is there a problem if these find commands traverse ${PREFIX}/share/ rather than ${PREFIX}/ ? docbookx.dtd, iso*amsb.ent and chunk.xsl are installed under share/ in FreeBSD world. Imagine if you have /usr/local/etc/cvsup/prefixes/ made by net/cvsup-mirror port. There are symlinks to /home/ncvs under prefixes/. Because of that, pkg-install of scrollkeeper needlessly traverses /home/ncvs tree entirely three times. Imagine if you have some other *BSD and XF* CVS tree. :-) And, I think some of ${PREFIX}'s in pkg-install which refer to the files installed by other ports should be ${LOCALBASE}, but this is a separate issue. -- FUJISHIMA Satsuki
On Mon, 2003-04-28 at 20:44, FUJISHIMA Satsuki wrote: > Is there a problem if these find commands traverse ${PREFIX}/share/ > rather than ${PREFIX}/ ? docbookx.dtd, iso*amsb.ent and chunk.xsl are > installed under share/ in FreeBSD world. > > Imagine if you have /usr/local/etc/cvsup/prefixes/ made by > net/cvsup-mirror port. There are symlinks to /home/ncvs under > prefixes/. Because of that, pkg-install of scrollkeeper needlessly > traverses /home/ncvs tree entirely three times. Imagine if you have > some other *BSD and XF* CVS tree. :-) Good call. I'll fix that. > > And, I think some of ${PREFIX}'s in pkg-install which refer to the > files installed by other ports should be ${LOCALBASE}, but this is a > separate issue. If you look at what ${PREFIX} actually is in the script, you'll see it's really ${LOCALBASE}. It uses libxml2 as a basis for where to look. Joe -- Joe Marcus Clarke FreeBSD GNOME Team :: marcus@FreeBSD.org http://www.FreeBSD.org/gnome
At 28 Apr 2003 20:47:56 -0400, Joe Marcus Clarke wrote: > Good call. I'll fix that. Good news. Thanks. > If you look at what ${PREFIX} actually is in the script, you'll see it's > really ${LOCALBASE}. It uses libxml2 as a basis for where to look. You are correct. I've misread that. Sorry for false alert. -- FUJISHIMA Satsuki