Bug 51759 - Maintainer update: astro/setiathome (manual page fix, etc.)
Summary: Maintainer update: astro/setiathome (manual page fix, etc.)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-05-04 21:10 UTC by Cyrille Lefevre
Modified: 2003-06-01 06:52 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (11.42 KB, patch)
2003-05-04 21:10 UTC, Cyrille Lefevre
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cyrille Lefevre 2003-05-04 21:10:16 UTC
	The setiathome manual page refer to setiathome.conf while it is
	now named rc.setiathome.conf. also, the manual page has been
	completed (variables, start/stop scripts, etc.)

	Makefile
		PORTREVISION bumped
	pkg-install
		registration heuristic changed (don't register if already
		registered, then automatically start setiathome in either
		case)
	files/rc.setiathome.conf
		seti_proxy_args changed to seti_proxy_server
		seti_socks_server, seti_socks_user, seti_socks_passwd added
		seti_sleep changed to seti_sleep_time
	files/setiathome.1
		/usr/local changed to %%PREFIX%%
		above and below changes described
	files/setiathome.sh
		same changes as files/rc.setiathome.conf
		su heuristic changed back from sh here-doc to sh -c
		due to unnecessary su process (not seen before)
		gracefull (aka apachectl :) option added using
		stop_after_send.txt

How-To-Repeat: 	man setiathome
Comment 1 Mikhail.Teterin 2003-05-16 23:20:07 UTC
Hi, Cyrille!

What about the exploit referenced by the FORBIDDEN message? Seems
like you need to upgrade to 3.08 before removing the FORBIDDEN...

Can you take a look at Brad Forschinger's PR 52297, please?

	http://www.FreeBSD.org/cgi/query-pr.cgi?pr=ports/52297

Seems like we need to incorporate his upgrade and merge your changes
into that. You can send me the new patch and I'll commit that.

Thanks!

	-mi
Comment 2 Mikhail.Teterin 2003-05-17 00:00:42 UTC
Cyrille!

Your changes to the setiathome.sh startup-script now lead to shell
errors on startup -- missing quote. I added the quote, and hit another
error. I'll be sending you my update -- including the upgrade to 3.08
for FreeBSD in a separate e-mail. Please, take a look.

As far as the new start-up script, I'm not sure it is worth the extra
shells (per CPU) to run to automaticly restart setiathome if it exits.

Even if you are convinced, such auto-restarting is desirable (I'm not),
it should be one sleeping shell per machine -- not one per CPU, don't
you think? My dual CPU box has four setiathome-owned processes runing
instead of 3. Someone's 8-way monster will have 16 instead of 9 :-)

Finally, with the amount of shell scripting required for this, may be,
it would be easier to write the seti-helper in C?

Yours,

	-mi
Comment 3 Tilman Keskinoz freebsd_committer freebsd_triage 2003-05-19 13:59:40 UTC
State Changed
From-To: open->analyzed

New version is out ( PR 52297 ) 
mi spotted errors in startup-script.
Comment 4 Cyrille Lefevre 2003-05-27 03:42:38 UTC
On Fri, May 16, 2003 at 06:20:07PM -0400, Mikhail Teterin wrote:
> Hi, Cyrille!
> 
> What about the exploit referenced by the FORBIDDEN message? Seems
> like you need to upgrade to 3.08 before removing the FORBIDDEN...

this was a mistake. unfortunatelly, to build/test setiathome,
FORBIDDEN must be commented and I forgot to uncomment it in the PR.
also, at the time of the PR, 3.08 wasn't out yet.

> Can you take a look at Brad Forschinger's PR 52297, please?
> 
> 	http://www.FreeBSD.org/cgi/query-pr.cgi?pr=ports/52297

this PR is malformed, I've not been CCed :(

> Seems like we need to incorporate his upgrade and merge your changes
> into that. You can send me the new patch and I'll commit that.

done :)

	http://www.FreeBSD.org/cgi/query-pr.cgi?pr=ports/52709

Cyrille.
-- 
Cyrille Lefevre                 mailto:cyrille.lefevre@laposte.net
Comment 5 Cyrille Lefevre 2003-05-27 03:48:53 UTC
On Fri, May 16, 2003 at 07:00:42PM -0400, Mikhail Teterin wrote:
> Cyrille!
> 
> Your changes to the setiathome.sh startup-script now lead to shell
> errors on startup -- missing quote. I added the quote, and hit another
> error. I'll be sending you my update -- including the upgrade to 3.08
> for FreeBSD in a separate e-mail. Please, take a look.

that part has been completly rewritten using an external wrapper...

> As far as the new start-up script, I'm not sure it is worth the extra
> shells (per CPU) to run to automaticly restart setiathome if it exits.

ditto.

> Even if you are convinced, such auto-restarting is desirable (I'm not),
> it should be one sleeping shell per machine -- not one per CPU, don't
> you think? My dual CPU box has four setiathome-owned processes runing
> instead of 3. Someone's 8-way monster will have 16 instead of 9 :-)

done.

> Finally, with the amount of shell scripting required for this, may be,
> it would be easier to write the seti-helper in C?

too complicated... everything was done using our stock sh :)

see you.

Cyrille.
-- 
Cyrille Lefevre                 mailto:cyrille.lefevre@laposte.net
Comment 6 Dirk Meyer freebsd_committer freebsd_triage 2003-06-01 06:50:34 UTC
State Changed
From-To: analyzed->closed

Update has beenn submitted, see ports/52709 


Comment 7 Dirk Meyer freebsd_committer freebsd_triage 2003-06-01 06:50:34 UTC
Responsible Changed
From-To: freebsd-ports-bugs->dinoex

I commited the pathc