Bug 52444 - Fix to ports/lang/ici build problem on 5-CURRENT
Summary: Fix to ports/lang/ici build problem on 5-CURRENT
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-05-19 22:50 UTC by Andy Newman
Modified: 2003-08-23 21:50 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Newman 2003-05-19 22:50:13 UTC 
Patch to fix build failures of lang/ici port on 5-CURRENT.  Note this
is UNTESTED (my 5-CURRENT machine disappeared last week) but the same
fix was required on other gcc 3.x using platforms (Mac OS X) and I am
assuming it will repair the brokeness.

How-To-Repeat: 
Patch the port as follows, adds a files/patch-conf-bsd.h file to
supply a necessary include to pick up the real float_t prior to
ICI defining its float_t.


diff -x CVS -PNru /usr/ports/lang/ici/files/patch-conf-bsd.h ./files/patch-conf-bsd.h
--- /usr/ports/lang/ici/files/patch-conf-bsd.h	Thu Jan  1 10:00:00 1970
+++ ./files/patch-conf-bsd.h	Tue May 20 07:14:24 2003
@@ -0,0 +1,10 @@
+--- old-conf-bsd.h	Tue May 20 07:13:49 2003
++++ conf-bsd.h	Tue May 20 07:13:58 2003
+@@ -1,6 +1,7 @@
+ #ifndef ICI_CONF_H
+ #define ICI_CONF_H
+ 
++#include <math.h>
+ #include <sys/param.h>
+ #undef isset
+
Comment 1 Erwin Lansing freebsd_committer freebsd_triage 2003-06-21 11:32:33 UTC 
State Changed
From-To: open->feedback

This still doesn't compile for me on -CURRENT 
http://people.freebsd.org/~erwin/ici.log
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2003-08-23 13:48:35 UTC 
State Changed
From-To: feedback->closed

The patch didn't work but the post-patch in the Makefile solved it. 
Please contact the author of the program, saying that float_t in 
his code should be replaced by floats_t to a. keep it consequent 
with the rest and b. keep it compilable on freebsd (and other sysems)
Comment 3 Andy Newman 2003-08-23 21:39:10 UTC 
I am one of the authors and it's been fixed in v4 of ICI
for some time.  A port of v4 needs to be done.
--
Andy Newman