Bug 52956 - Bugfix: net/p5-NetPacket
Summary: Bugfix: net/p5-NetPacket
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-05 02:40 UTC by Lars Eggert
Modified: 2003-06-21 07:24 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (948 bytes, patch)
2003-06-05 02:40 UTC, Lars Eggert
no flags Details | Diff
smime.p7s (3.45 KB, application/x-pkcs7-signature)
2003-06-18 20:07 UTC, larse
no flags Details
patch.p5-NetPacket (5.09 KB, text/plain; charset=us-ascii)
2003-06-19 02:19 UTC, Foxfair Hu
no flags Details
patch.p5-NetPacket (3.04 KB, text/plain; charset=us-ascii)
2003-06-19 02:33 UTC, Foxfair Hu
no flags Details
smime.p7s (3.45 KB, application/x-pkcs7-signature)
2003-06-19 05:33 UTC, larse
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Eggert 2003-06-05 02:40:16 UTC
NetPacket::IP calculates the IP checksum incorrectly when sending
packets. The attached patch fixes this, has been submitted to the
authors and verified by them to fix the problem.

> From: Stephanie Wehner <_@r4k.net>
> To: Lars Eggert <larse@ISI.EDU>
> Subject: Re: NetPacket::IP bug (with patch)
>  
> Hi Lars,
>  
> Sorry for the late reply, quite busy lately :(
>  
> > I think there's a small bug in NetPacket::IP - the wrong "offset"
> > variable is used when encoding a packet (see the included patch). Other
>  
> Thanks for the patch ! I'll incorporate it tomorrow or on tuesday
> (along with some additions people submitted). I'll let you know
> when the new version's on cpan.
>  
> bye,
> Stephanie
Comment 1 Foxfair Hu freebsd_committer freebsd_triage 2003-06-11 06:25:35 UTC
State Changed
From-To: open->feedback

NetPacket-0.04 is out, is it possible to submit an udpdate instead 
of just a bugfix?
Comment 2 larse 2003-06-18 20:07:24 UTC
> NetPacket-0.04 is out, is it possible to submit an udpdate instead 
> of just a bugfix? 

I've briefly checked 0.04, but it doesn't have the fix either.
-- 
Lars Eggert <larse@isi.edu>           USC Information Sciences Institute
Comment 3 Foxfair Hu 2003-06-19 02:19:07 UTC
Hello Lars,

	Here is a patch to upgrade p5-NetPacket to 0.04 included
the patch (patch-aa).


foxfair
Comment 4 Foxfair Hu 2003-06-19 02:33:05 UTC
Ah, please ignore the "Makefile.orig" part in last email.
Once again, here is a complete set of patch include the bugfix.

foxfair.
Comment 5 larse 2003-06-19 05:33:44 UTC
Foxfair Hu wrote:
> Ah, please ignore the "Makefile.orig" part in last email.
> Once again, here is a complete set of patch include the bugfix.

Looks good to me!

(What I meant in my earlier email is that the vanilla 0.04 doesn't have
the bugfix, but this ports includes it, so I'm all for it.)

Thanks,
Lars
-- 
Lars Eggert <larse@isi.edu>           USC Information Sciences Institute
Comment 6 Foxfair Hu freebsd_committer freebsd_triage 2003-06-21 07:23:59 UTC
State Changed
From-To: feedback->closed

Committed, thanks!