Bug 56345 - p5-postgresql-plperl - modify postgresql slave ports build behaviour
Summary: p5-postgresql-plperl - modify postgresql slave ports build behaviour
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-03 01:50 UTC by Palle Girgensohn
Modified: 2003-09-04 13:48 UTC (History)
0 users

See Also:


Attachments
file.diff (1.78 KB, patch)
2003-09-03 01:50 UTC, Palle Girgensohn
no flags Details | Diff
d (1.88 KB, application/octet-stream)
2003-09-03 10:56 UTC, Palle Girgensohn
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Palle Girgensohn 2003-09-03 01:50:19 UTC
The postgresql slave ports now use .include to get info about version
etc from the master port. This has drawbacks, and the now introduced
scheme, using `...!= make -V ...', is better.
Comment 1 Mathieu Arnold freebsd_committer freebsd_triage 2003-09-03 09:09:30 UTC

+-Le 03/09/2003 02:44 +0200, Palle Girgensohn écrivait :
| 
| +.include <bsd.port.pre.mk>
| +.if ${OSVERSION} >= 500000
| +BROKEN=		Cannot build PL/Perl because libperl is not a shared library.
| +.endif
| +

That is plain wrong, there was a libperl.so at this time. (perl was removed
at 500036).
And this does not take into account 4.X where 5.6.1 or 5.8 is installed and
use.perl port was
You should really look at the patch I sent you, as it's in this port's
patches, it won't affect others, and removing a fonctionnality while there
is a patch to do it right is not what I believe to be the right way :)

-- 
Mathieu Arnold
Comment 2 Palle Girgensohn 2003-09-03 10:56:26 UTC
Please use the attached patch instead of the above.

Fix for perl 5.6++ by Mathieu Arnold <mat@FreeBSD.org>. Thanks!

/Palle
Comment 3 Palle Girgensohn 2003-09-03 11:03:24 UTC
Wow, that patch didn't get out right in gnats, sorry!

Same patch again, in plaintext (thanks, emacs...:) :

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/databases/p5-postgresql-plperl/Makefile,v
retrieving revision 1.7
diff -u -r1.7 Makefile
--- Makefile	19 Jun 2003 09:12:55 -0000	1.7
+++ Makefile	3 Sep 2003 09:53:51 -0000
@@ -1,27 +1,32 @@
-# New ports collection makefile for:	PostgreSQL PL/Perl 
+# New ports collection makefile for:	PostgreSQL PL/Perl
 # Date created:		January 14, 2002
 # Whom:			Palle Girgensohn <girgen@partitur.se>
 #
 # $FreeBSD: ports/databases/p5-postgresql-plperl/Makefile,v 1.7 2003/06/19 09:12:55 daichi Exp $
 #
+POSTGRESQL_PORT?=	databases/postgresql7
 
-PORTNAME=	postgresql-plperl
-CATEGORIES=	databases perl5
+PORTNAME=	postgresql
+PORTVERSION!=	${MAKE} -C ${.CURDIR}/../../${POSTGRESQL_PORT} -V PORTVERSION
+PORTREVISION=	1
+CATEGORIES=	databases
+MASTER_SITES=	${MASTER_SITE_PGSQL}
+MASTER_SITE_SUBDIR!=	${MAKE} -C ${.CURDIR}/../../${POSTGRESQL_PORT} -V MASTER_SITE_SUBDIR
 PKGNAMEPREFIX=	p5-
-PORTREVISION=	0
+PKGNAMESUFFIX=	-plperl
+DISTFILES!=	${MAKE} -C ${.CURDIR}/../../${POSTGRESQL_PORT} -V DISTFILES
+DIST_SUBDIR=	postgresql
 
 MAINTAINER=	girgen@pingpong.net
 COMMENT=	A module for using Perl5 to write SQL functions
 
-POSTGRESQL_PORT?=	databases/postgresql7
-POSTGRESQL_SUBPORT=YES
-.include "../../${POSTGRESQL_PORT}/Makefile"
-
 RUN_DEPENDS=	postgres:${PORTSDIR}/${POSTGRESQL_PORT}
 
+MD5_FILE=	${.CURDIR}/../../${POSTGRESQL_PORT}/distinfo
 USE_PERL5=	yes
+USE_GMAKE=	yes
+GNU_CONFIGURE=	yes
 CONFIGURE_ARGS=	--with-perl
-
 MAKE_ARGS+=	-C src/pl/plperl
 MAKEFILE=	GNUmakefile
 
--- /dev/null	Wed Sep  3 11:49:12 2003
+++ files/patch-src-makefiles-Makefile.freebsd	Wed Sep  3 11:24:58 2003
@@ -0,0 +1,8 @@
+--- src/makefiles/Makefile.freebsd.orig	Wed Aug 29 21:14:40 2001
++++ src/makefiles/Makefile.freebsd	Mon Sep  1 10:16:26 2003
+@@ -23,3 +23,5 @@
+ endif
+ 
+ sqlmansect = 7
++
++allow_nonpic_in_shlib = yes
Comment 4 Sergey A. Osokin freebsd_committer freebsd_triage 2003-09-04 13:47:54 UTC
State Changed
From-To: open->closed

Committed with modifications from 56404, thanks!