Bug 56668 - Port update: www/elinks Elinks crashes on frameset webpages
Summary: Port update: www/elinks Elinks crashes on frameset webpages
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-10 05:30 UTC by Mário Freitas
Modified: 2003-11-24 22:10 UTC (History)
0 users

See Also:


Attachments
patch-parse.c (434 bytes, text/plain)
2003-09-10 05:30 UTC, Mário Freitas
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mário Freitas 2003-09-10 05:30:11 UTC
I noticed elinks crashes most of the times after parsing a web
page which includes framesets (try loading a frameset with for example
rows="200,*"). This occurs because it tries to free some arbitrary block
of memory without checking if the previous functions returned errors.

Fix: Please, place this patch in www/elinks/files directory and update the 
port revision.
How-To-Repeat: Try opening a webpage with some frameset including rows="200,*" for example.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2003-10-07 23:49:03 UTC
Hello,

Please see ports/56668 regarding a patch for elinks:
	http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/56668

Do you approve this patch?
If so, please reply and forward it to the authors of elinks too. 

Edwin

-- 
Edwin Groothuis
edwin@freebsd.org
http://www.mavetju.org
Comment 2 jharris 2003-10-08 04:31:47 UTC
On Wed, Oct 08, 2003 at 08:49:03AM +1000, Edwin Groothuis wrote:

> Please see ports/56668 regarding a patch for elinks:
> 	http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/56668
> 
> Do you approve this patch?


Yes.

-- 
Jason Harris          | NIC:  JH329, PGP:  This _is_ PGP-signed, isn't it?
jharris@widomaker.com | web:  http://keyserver.kjsl.com/~jharris/
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2003-10-08 04:45:02 UTC
State Changed
From-To: open->closed

Commited, thanks! 
Please can you forward this patch to the authors of the software too?
Comment 4 pasky 2003-11-24 22:03:48 UTC
Dear diary, on Wed, Oct 08, 2003 at 05:31:47AM CEST, I got a letter,
where Jason Harris <jharris@widomaker.com> told me, that...
> On Wed, Oct 08, 2003 at 08:49:03AM +1000, Edwin Groothuis wrote:
> 
> > Please see ports/56668 regarding a patch for elinks:
> > 	http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/56668
> > 
> > Do you approve this patch?
> 
> Yes.


Thanks a lot. Slightly extended and applied to 0.4 (the last thing which
was holding 0.4.3, actually ;).

This is called fast, flexible and cooperative mainstream :^). Sorry it
took so long.

-- 
 
				Petr "Pasky" Baudis
.
To get something done, a committee should consist of no more than three
persons, two of them absent.
.
Stuff: http://pasky.ji.cz/