Bug 57646 - [MAINTAINER] port security/nmap: update to version 3.48
Summary: [MAINTAINER] port security/nmap: update to version 3.48
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-10-06 15:20 UTC by Oliver Eikemeier
Modified: 2003-10-08 02:00 UTC (History)
0 users

See Also:


Attachments
nmap-3.48.patch (9.83 KB, patch)
2003-10-06 15:20 UTC, Oliver Eikemeier
no flags Details | Diff
security::nmap.diff6 (11.00 KB, text/plain; charset=us-ascii)
2003-10-06 20:25 UTC, marius
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Eikemeier 2003-10-06 15:20:06 UTC
- improved version detection
- integrates most FreeBSD fixes, thanks to
  Marius Strobl <marius@alchemy.franken.de>
- install localized man pages
Comment 1 marius 2003-10-06 20:25:28 UTC
Hi,

I still can't build Nmap using the OpenSSL port with this update (actually,
the stock Nmap 3.48 still has bugs in the --with-openssl support):

===>  Extracting for nmap-3.48
>> Checksum OK for nmap-3.48.tar.bz2.
===>  Patching for nmap-3.48
===>  Applying FreeBSD patches for nmap-3.48
===>   nmap-3.48 depends on shared library: pcre.0 - found
===>   nmap-3.48 depends on shared library: crypto.3 - found
===>  Configuring for nmap-3.48
<...>
configure: configuring in nbase
configure: running /bin/sh './configure' --prefix=/usr/local  '--without-localdi
rs' '--with-libpcre=/usr/local' '--with-openssl=/usr/local' '--without-nmapfe' '
--prefix=/usr/local' '--build=sparc64-portbld-freebsd5.1' 'LDFLAGS= -rpath=/usr/
local/lib' 'CFLAGS=-O -pipe ' 'CXX=c++' 'build_alias=sparc64-portbld-freebsd5.1'
 'CC=cc' 'CXXFLAGS=-O -pipe' --cache-file=/dev/null --srcdir=.
<...>
===>  Building for nmap-3.48
Compiling libnbase
cd nbase && make
cc -O -pipe  -Wall    -DHAVE_CONFIG_H -DNCRACK_VERSION=\"\" -DHAVE_CONFIG_H=1  -
c snprintf.c
cc -O -pipe  -Wall    -DHAVE_CONFIG_H -DNCRACK_VERSION=\"\" -DHAVE_CONFIG_H=1  -
c getopt.c
cc -O -pipe  -Wall    -DHAVE_CONFIG_H -DNCRACK_VERSION=\"\" -DHAVE_CONFIG_H=1  -
c getopt1.c
cc -O -pipe  -Wall    -DHAVE_CONFIG_H -DNCRACK_VERSION=\"\" -DHAVE_CONFIG_H=1  -
c nbase_str.c
cc -O -pipe  -Wall    -DHAVE_CONFIG_H -DNCRACK_VERSION=\"\" -DHAVE_CONFIG_H=1  -
c nbase_misc.c
cc -O -pipe  -Wall    -DHAVE_CONFIG_H -DNCRACK_VERSION=\"\" -DHAVE_CONFIG_H=1  -
c nbase_memalloc.c
cc -O -pipe  -Wall    -DHAVE_CONFIG_H -DNCRACK_VERSION=\"\" -DHAVE_CONFIG_H=1  -
c nbase_rnd.c
nbase_rnd.c:96:26: openssl/rand.h: No such file or directory
nbase_rnd.c: In function `get_random_bytes':
nbase_rnd.c:118: warning: implicit declaration of function `RAND_bytes'
nbase_rnd.c:120: warning: implicit declaration of function `RAND_pseudo_bytes'
nbase_rnd.c:165: warning: implicit declaration of function `RAND_seed'
nbase_rnd.c:166: warning: implicit declaration of function `RAND_status'
*** Error code 1

Attached is a revised version of the update which fixes this. It's
essentially your patch with small additions in patch-nbase::configure
and patch-nsock::src::configure (nbase and nsock are C source so they
get compiled with CC which means the OpenSSL include path has to be
added to CFLAGS and not CXXFLAGS).
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2003-10-07 23:31:23 UTC
State Changed
From-To: open->closed

Commited, thanks! 
Please check the comments of Marius Strobl in the PR: 
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/57646
Comment 3 Oliver Eikemeier 2003-10-08 01:45:08 UTC
Edwin Groothuis wrote:

> Commited, thanks!
> Please check the comments of Marius Strobl in the PR:
> 	http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/57646

Yes, they actually make sense, even though I'm currently unable to
test them. And please, please ask before you commit changed patches.

Thanks
    Oliver

--- nmap.patch begins here ---
diff -Nur security/nmap/Makefile.orig security/nmap/Makefile
--- security/nmap/Makefile.orig	7 Oct 2003 22:31:18 -0000
+++ security/nmap/Makefile	8 Oct 2003 00:28:12 -0000
@@ -10,6 +10,7 @@
 CATEGORIES=	security ipv6
 MASTER_SITES=	http://download.insecure.org/nmap/dist/ \
 		http://www.mirrors.wiretapped.net/security/network-mapping/nmap/
+DISTNAME=	nmap-${PORTVERSION}
 
 MAINTAINER=	eikemeier@fillmore-labs.com
 COMMENT?=	Port scanning utility for large networks
diff -Nur security/nmap/files/patch-nbase::configure.orig security/nmap/files/patch-nbase::configure
--- security/nmap/files/patch-nbase::configure.orig	7 Oct 2003 22:31:18 -0000
+++ security/nmap/files/patch-nbase::configure	7 Oct 2003 05:27:04 -0000
@@ -1,5 +1,5 @@
---- nbase/configure.orig	Mon Oct  6 13:03:52 2003
-+++ nbase/configure	Mon Oct  6 13:04:08 2003
+--- nbase/configure.orig	Fri Oct  3 10:33:24 2003
++++ nbase/configure	Tue Oct  7 07:27:03 2003
 @@ -2971,7 +2971,7 @@
  
  
@@ -9,3 +9,12 @@
  do
  as_ac_Header=`echo "ac_cv_header_$ac_header" | $as_tr_sh`
  if eval "test \"\${$as_ac_Header+set}\" = set"; then
+@@ -5908,7 +5908,7 @@
+     ;;
+   *)
+     specialssldir="$with_openssl"
+-    CXXFLAGS="-I$with_openssl/include $CXXFLAGS"
++    CFLAGS="-I$with_openssl/include $CFLAGS"
+     ;;
+   esac
+ 
diff -Nur security/nmap/files/patch-nsock::src::configure.orig security/nmap/files/patch-nsock::src::configure
--- security/nmap/files/patch-nsock::src::configure.orig	1 Jan 1970 00:00:00 -0000
+++ security/nmap/files/patch-nsock::src::configure	7 Oct 2003 05:27:34 -0000
@@ -0,0 +1,19 @@
+--- nsock/src/configure.orig	Tue Oct  7 07:23:06 2003
++++ nsock/src/configure	Tue Oct  7 07:27:33 2003
+@@ -1287,7 +1287,6 @@
+      fi
+    if test -d /usr/local/include; then
+      CFLAGS="$CFLAGS -I/usr/local/include"
+-     CXXFLAGS="$CFLAGS -I/usr/local/include"
+    fi
+ fi
+ 
+@@ -3207,7 +3206,7 @@
+     ;;
+   *)
+     specialssldir="$with_openssl"
+-    CXXFLAGS="-I$with_openssl/include $CXXFLAGS"
++    CFLAGS="-I$with_openssl/include $CFLAGS"
+     ;;
+   esac
+ 
--- nmap.patch ends here ---
Comment 4 edwin 2003-10-08 01:57:49 UTC
On Tue, Oct 07, 2003 at 05:50:16PM -0700, Oliver Eikemeier wrote:
> The following reply was made to PR ports/57646; it has been noted by GNATS.
> 
> From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
> To: Edwin Groothuis <edwin@FreeBSD.org>
> Cc: freebsd-gnats-submit@FreeBSD.org
> Subject: Re: ports/57646: [MAINTAINER] port security/nmap: update to version
>  3.48
> Date: Wed, 08 Oct 2003 02:45:08 +0200
> 
>  Edwin Groothuis wrote:
>  
>  > Commited, thanks!
>  > Please check the comments of Marius Strobl in the PR:
>  > 	http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/57646
>  
>  Yes, they actually make sense, even though I'm currently unable to
>  test them. And please, please ask before you commit changed patches.

I didn't commit his patches, I commited only yours.

Edwin

-- 
Edwin Groothuis      |            Personal website: http://www.mavetju.org
edwin@mavetju.org    |    Weblog: http://www.mavetju.org/weblog/weblog.php