On my FreeBSD machine, xawtv misdetects the X11 display as "remote" and hence disables the "overlay" mode which is an important performance feature. This PR includes a workaround for the problem. Please apply until there is an upstream fix in the next xawtv release. Technical: x11/xt.c seems to be unable to retrieve the socket name, but IMHO an address type of AF_UNIX is sufficient to conclude "local display". NOTE: there is another bug in xt.c, it does NOT detect that getnameinfo fails with EAI_FAMILY and still tries to use the results. ltrace: (5 is EAI_FAMILY) This bug needs to be fixed upstream, and I also suggest the patch below for the upstream. getsockname(6, 0xbfbff7b0, 0xbfbff72c, 95, 1) = 0 getnameinfo(0xbfbff7b0, 16, 0xbfbff780, 46, 0xbfbff730) = 5 getpeername(6, 0xbfbff7b0, 0xbfbff72c, 46, 0xbfbff730) = 0 getnameinfo(0xbfbff7b0, 19, 0xbfbff750, 46, 0xbfbff730) = 5 strcmp("", ")\001\003 \326!\b\b.\035\b\b\324R\b\b@\242\b\b\b") = -41 Fix: Gerd, for upstream application, you need to run patch twice on this section, the first time with -p4, which should create files-x11::xt.c, then run patch again with this new file as input to modify x11/xt.c.
Responsible Changed From-To: freebsd-ports-bugs->oliver Over the maintainer!
State Changed From-To: open->closed Committed, Thanks!