This makes ripit use a http proxy if the HTTP_PROXY environment variable is set. Please test this also with non-proxy http und plain cddb mode - I cannot do that since I am behind a rigid firewall (hence the patch :-) I have also mailed the (tiny) diff to the author of the script. How-To-Repeat: N/A
Dear FreeBSD port maintainer, please take a look at http://www.freebsd.org/cgi/query-pr.cgi?pr=59013 Do you approve this change? -- Pav Lucistnik <pav@FreeBSD.org> <pav@oook.cz>
State Changed From-To: open->feedback I'll take care of this.
Responsible Changed From-To: freebsd-ports-bugs->pav I'll take care of this.
* pav@FreeBSD.org: | | Dear FreeBSD port maintainer, | | please take a look at | | http://www.freebsd.org/cgi/query-pr.cgi?pr=59013 | | Do you approve this change? The HTTP proxy change seems fine. However, the patch in the PR also includes a change of perl interpreter path from /usr/bin/perl to /usr/local/bin/perl. This change should _not_ be applied. The correct perl path is set through the use of USE_PERL5 and the post-patch target in the port Makefile. -- Øyvind Møll oyvindmo@initio.no
> The HTTP proxy change seems fine. > > However, the patch in the PR also includes a change of perl > interpreter path from /usr/bin/perl to /usr/local/bin/perl. This > change should _not_ be applied. The correct perl path is set through > the use of USE_PERL5 and the post-patch target in the port Makefile. Oops, sorry. I use the perl5.8 port, and I modified the installed version of the script to produce my patch. Unfortunately, I did not review the patch file, this is why this hunk was also submitted. Simon
State Changed From-To: feedback->closed Committed without shebang change, but with a portrevision bump. Thanks!