Change in port: zed console text editor, highly configurable. Current version of the port has problem of applying patch-zed.h possible change in the original packet. Additionally FreeBSD specific fix was done to main.cc which remedies the problem of Zombie childs upon using the built in shell/make utility which uses fork(). o Pumped the portrevision. o Added last modification time to Makefile Tested under FreeBSD-4.x branch, no idea about 5.x Fix: # Enclosed is the diff file against the old port How-To-Repeat: Current port refused to cleanly apply patches
Responsible Changed From-To: freebsd-ports-bugs->sergei I'll handle it.
Sten, I am planning to commit the change from your PR to the ports tree once the freeze is over. While we still have some time until that happens, can you please look into the following port improvements: - respect PREFIX - right now it hard-codes /usr/local - respect CFLAGS/CXXFLAGS - respect NOPORTDOCS - use DOCSDIR in pkg-plist I believe it may be easier to override the native install mechanism by do-install target in the port's Makefile. Please let me know if you have any questions. Sergei
State Changed From-To: open->feedback Ask maintainer for some additional changes.
Thanks for the valid remarks, the small patch below should make the port a bit more respectful. diff -ruN zed.sent/Makefile zed/Makefile --- zed.sent/Makefile Fri Nov 28 12:30:31 2003 +++ zed/Makefile Wed Dec 3 22:16:04 2003 @@ -8,12 +8,25 @@ PORTNAME= zed PORTVERSION= 1.0.5 -PORTREVISION= 1 +PORTREVISION= 1 CATEGORIES= editors MASTER_SITES= http://zed.c3po.it/ MAINTAINER= exile@chamber.ee COMMENT= Simple, fast, powerful, small, highly configurable TEXT EDITOR + +PREFIX= /usr/local +DOCSDIR= ${PREFIX}/share/doc/${PORTNAME} + +MAKE_ARGS= CFLAGS="${CFLAGS}" + +do-install: + ${INSTALL_PROGRAM} ${WRKSRC}/zed ${PREFIX}/bin/zed + ${INSTALL_DATA} ${WRKSRC}/cfg/zedrc ${PREFIX}/etc/zedrc +.if !defined(NOPORTDOCS) + ${MKDIR} ${DOCSDIR} + ${INSTALL_DATA} ${WRKSRC}/zed.doc ${DOCSDIR}/zed.doc +.endif post-install: @${STRIP_CMD} ${PREFIX}/bin/zed diff -ruN zed.sent/pkg-plist zed/pkg-plist --- zed.sent/pkg-plist Sat Sep 21 09:19:24 2002 +++ zed/pkg-plist Wed Dec 3 22:01:35 2003 @@ -1,4 +1,4 @@ bin/zed etc/zedrc -share/doc/zed/zed.doc -@dirrm share/doc/zed +%%PORTDOCS%%%%DOCSDIR%%/zed.doc +%%PORTDOCS%%@dirrm %%DOCSDIR%%
State Changed From-To: feedback->closed Committed, thanks!