Bug 61683 - [PATCH] bsd.port.mk: enhanced OPTIONS handling
Summary: [PATCH] bsd.port.mk: enhanced OPTIONS handling
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-01-21 20:00 UTC by Oliver Eikemeier
Modified: 2004-02-04 05:35 UTC (History)
0 users

See Also:


Attachments
file.diff (6.39 KB, patch)
2004-01-21 20:00 UTC, Oliver Eikemeier
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Eikemeier 2004-01-21 20:00:35 UTC
- include saved option only if the port is OPTIONS aware (defines OPTIONS)
- The options a saved if:
- ${OPTIONSFILE} if that is defined
- ${PORT_DBDIR}/${UNIQUENAME}/options if UNIQUENAME is defined
- ${PORT_DBDIR}/${LATEST_LINK}/options
  if UNIQUENAME is undefined and LATEST_LINK is defined
- ${PORT_DBDIR}/${PKGNAMEPREFIX}${PORTNAME}/options
  if UNIQUENAME and LATEST_LINK are undefined

This requires PKGNAMEPREFIX, UNIQUENAME and LATEST_LINK to be defined
*before* including bsd.port.pre.mk.

This patch tries to guard against errors by evaluating OPTIONSFILE early
and checking if this value does not change.

*ALL* -client/-server ports have to define LATEST_LINK or UNIQUENAME if
the client and server ports require different saved options.

- bring the ===> messages in line with the existing ones by using PKGNAME
  instead of PORTNAME
- the same for the dialog title
- use ECHO_CMD instead of ECHO_MSG to write the OPTIONSFILE comment,
  add a line with the PKGNAME
- issue a note during compiling that user-specified options have been found
- make the output of the showconfig target a little more user friendly, even
  though unformatted.
Comment 1 Oliver Eikemeier freebsd_committer freebsd_triage 2004-01-21 20:30:59 UTC
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

portmanager business
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2004-01-31 04:15:20 UTC
State Changed
From-To: open->analyzed

This is currently being tested on bento.
Comment 3 Joe Marcus Clarke freebsd_committer freebsd_triage 2004-02-04 05:35:04 UTC
State Changed
From-To: analyzed->closed

Committed, thanks!