Bug 61714 - Update port: x11-wm/fluxbox-devel 0.9.7 -> 0.9.8, fix an evil memory bug.
Summary: Update port: x11-wm/fluxbox-devel 0.9.7 -> 0.9.8, fix an evil memory bug.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pav Lucistnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-01-22 08:20 UTC by Jeremy Messenger
Modified: 2004-01-22 20:32 UTC (History)
1 user (show)

See Also:


Attachments
fluxbox-devel.diff (19.95 KB, patch)
2004-01-22 08:20 UTC, Jeremy Messenger
no flags Details | Diff
fluxbox-devel.diff (20.79 KB, patch)
2004-01-22 18:40 UTC, Jeremy Messenger
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Messenger 2004-01-22 08:20:20 UTC
-Update to 0.9.8
-Remove the '-devel' (ex: $prefix/bin/fluxbox and etc)
-Add CONFLICTS against x11-wm/fluxbox

Fix: What have I done?
	- Remove the '-devel'; adamw@FreeBSD and I have agree that it's mature
	  enough to be fluxbox. Also, we doubt that someone will install both
	  fluxbox and fluxbox-devel at the same time. Because of the ~/.fluxbox
	  that they can't be share. The CONFLICTS should be good enough until
	  1.0 is released.

	  If you, the maintainer (Hendrik), don't agree with this remove of
	  '-devel' then you can create a new diff of it. All you have to do is
	  change the version and checksum, that's it, I think.

	- Re-order the NLSMAKEFILES, because it hurts my eyes when I am trying
	  to compare to see if there has any new one. Now, it looks more clean
	  for our eyes. :-)

	- Modified the pkg-message, explained about the removal of '-devel'.
	  Please, do feel free to correct the English grammar if it needs. ;-)

I think, I didn't leave anything so far. Here's diff.

How-To-Repeat: n/a
Comment 1 Pav Lucistnik freebsd_committer freebsd_triage 2004-01-22 09:56:29 UTC
Dear maintainer of port x11-wm/fluxbox-devel, please take a look at

http://www.freebsd.org/cgi/query-pr.cgi?pr=61714

Do you approve this update, and do you agree with -devel removal?

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

Pain clots and unformed lice pat this train.
Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2004-01-22 09:56:33 UTC
State Changed
From-To: open->feedback

Asked maintainer for approval. 


Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2004-01-22 09:56:33 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pav

Watch'em.
Comment 4 Adam Weinberger freebsd_committer freebsd_triage 2004-01-22 11:17:02 UTC
>> (01.22.2004 @ 0249 PST): Jeremy Messenger said, in 22K: <<
> What have I done?
> 	- Remove the '-devel'; adamw@FreeBSD and I have agree that it's mature
> 	  enough to be fluxbox. Also, we doubt that someone will install both
> 	  fluxbox and fluxbox-devel at the same time. Because of the ~/.fluxbox
> 	  that they can't be share. The CONFLICTS should be good enough until
> 	  1.0 is released.
>> end of "ports/61714: Update port: x11-wm/fluxbox-devel 0.9.7 -> 0.9.8, fix an evil memory bug." from Jeremy Messenger <<

Woah. Mezz, I'm really impressed! Good job with the fb-devel -> fb
renaming!

One thing though: stuff should be added to the pkg-message to caution
people that their menus will probably need to be regenerated, because
all references to fbrun-devel, etc. are going to fail.

# Adam


--
Adam Weinberger
adam@vectors.cx // adamw@FreeBSD.org // adamw@magnesium.net
http://www.vectors.cx
Comment 5 Jeremy Messenger 2004-01-22 18:02:52 UTC
On Thu, 22 Jan 2004 06:17:02 -0500, Adam Weinberger <adamw@FreeBSD.org> 
wrote:

>>> (01.22.2004 @ 0249 PST): Jeremy Messenger said, in 22K: <<
>> What have I done?
>> 	- Remove the '-devel'; adamw@FreeBSD and I have agree that it's mature
>> 	  enough to be fluxbox. Also, we doubt that someone will install both
>> 	  fluxbox and fluxbox-devel at the same time. Because of the ~/.fluxbox
>> 	  that they can't be share. The CONFLICTS should be good enough until
>> 	  1.0 is released.
>>> end of "ports/61714: Update port: x11-wm/fluxbox-devel 0.9.7 -> 0.9.8, 
>>> fix an evil memory bug." from Jeremy Messenger <<
>
> Woah. Mezz, I'm really impressed! Good job with the fb-devel -> fb
> renaming!

Thanks! :-) I was almost totally forgot about 0.9.8, which I had it for a 
week until I am getting few more emails from people last night and today, 
so I had finally create diff and sent it to PR.

> One thing though: stuff should be added to the pkg-message to caution
> people that their menus will probably need to be regenerated, because
> all references to fbrun-devel, etc. are going to fail.

Oh yeah, you are right. Does this new diff of pkg-message looks good?

--------------------------new-fluxbox-devel.diff--------------------------
diff -ur fluxbox-devel.orig/pkg-message fluxbox-devel/pkg-message
--- fluxbox-devel.orig/pkg-message	Tue Nov 18 10:26:51 2003
+++ fluxbox-devel/pkg-message	Thu Jan 22 11:58:16 2004
@@ -5,7 +5,16 @@
  Check out the RoadMap on http://fluxbox.sourceforge.net/roadmap.php
  for more information about upcoming versions.

-ATTENTION: As of 0.9.6 the shell script 'startfluxbox-devel' has been 
added.
+ATTENTION: Now, the -devel has been removed and the CONFLICTS to
+           x11-wm/fluxbox has been added. The x11-wm/fluxbox-devel
+           is stable enough to use daily and we doubt someone will
+           install both fluxbox and fluxbox-devel.
+
+           Since, the '-devel' has been removed and I recommend
+           you to regenerated menu or edit the ~/.fluxbox/menu to
+           remove the '-devel' to make the things work correct.
+
+           As of 0.9.6 the shell script 'startfluxbox' has been added.
             It should be executed instead of fluxbox itself from
             ~/.xinitrc or ~/.xsession.
  *******************************************************************************
--------------------------new-fluxbox-devel.diff--------------------------

Cheers,
Mezz

> # Adam
>
>
> --
> Adam Weinberger
> adam@vectors.cx // adamw@FreeBSD.org // adamw@magnesium.net
> http://www.vectors.cx


-- 
bsdforums.org 's moderator, mezz.
Comment 6 Jeremy Messenger 2004-01-22 18:06:23 UTC
On Thu, 22 Jan 2004 15:44:49 +0100, Hendrik Scholz <hscholz@raisdorf.net> 
wrote:

> Hi!
>
> On Thu, Jan 22, 2004 at 01:49:12AM -0600, Jeremy Messenger wrote:
>> >Fix:
>> What have I done?
>> 	- Remove the '-devel'; adamw@FreeBSD and I have agree that it's mature
>> 	  enough to be fluxbox. Also, we doubt that someone will install both
>> 	  fluxbox and fluxbox-devel at the same time. Because of the ~/.fluxbox
>> 	  that they can't be share. The CONFLICTS should be good enough until
>> 	  1.0 is released.
>
> I'm fine with removing -devel as this should prevent -devel legacy 
> problems
> when 1.0 gets released.
>
> I didn't have the time to test the patch nor will I have it in the next 
> few
> hours as I just had a long flight and need to catch up on a bunch of 
> other
> things (work).
> Mezz: You've always been contributing to the fluxbox stuff and if you 
> like
>       feel free to maintainership!

Yep, I would love to take the maintainership because it's fun! :-) pav, 
can you edit the maintainer before you commit it? Same with the new 
pkg-message too?

Thanks Hendrik, pav and adamw!

Cheers,
Mezz

> Thanks, Hendrik


-- 
bsdforums.org 's moderator, mezz.
Comment 7 Adam Weinberger freebsd_committer freebsd_triage 2004-01-22 18:11:01 UTC
>> (01.22.2004 @ 1302 PST): Jeremy Messenger said, in 2.5K: <<
> On Thu, 22 Jan 2004 06:17:02 -0500, Adam Weinberger <adamw@FreeBSD.org> 
> wrote:
> >One thing though: stuff should be added to the pkg-message to caution
> >people that their menus will probably need to be regenerated, because
> >all references to fbrun-devel, etc. are going to fail.
> 
> Oh yeah, you are right. Does this new diff of pkg-message looks good?
> 
> --------------------------new-fluxbox-devel.diff--------------------------
> diff -ur fluxbox-devel.orig/pkg-message fluxbox-devel/pkg-message
> --- fluxbox-devel.orig/pkg-message	Tue Nov 18 10:26:51 2003
> +++ fluxbox-devel/pkg-message	Thu Jan 22 11:58:16 2004
> @@ -5,7 +5,16 @@
>  Check out the RoadMap on http://fluxbox.sourceforge.net/roadmap.php
>  for more information about upcoming versions.
> 
> -ATTENTION: As of 0.9.6 the shell script 'startfluxbox-devel' has been 
> added.
> +ATTENTION: Now, the -devel has been removed and the CONFLICTS to
> +           x11-wm/fluxbox has been added. The x11-wm/fluxbox-devel
> +           is stable enough to use daily and we doubt someone will
> +           install both fluxbox and fluxbox-devel.
> +
> +           Since, the '-devel' has been removed and I recommend
> +           you to regenerated menu or edit the ~/.fluxbox/menu to
> +           remove the '-devel' to make the things work correct.
> +
> +           As of 0.9.6 the shell script 'startfluxbox' has been added.
>             It should be executed instead of fluxbox itself from
>             ~/.xinitrc or ~/.xsession.
>  *******************************************************************************
> --------------------------new-fluxbox-devel.diff--------------------------
>> end of "Re: ports/61714: Update port: x11-wm/fluxbox-devel 0.9.7 -> 0.9.8, fix an evil memory bug." from Jeremy Messenger <<

Since the '-devel' suffix has been removed, you should either
use (scriptname) to regenerate the menu, or edit your
~/.fluxbox/menu and remove the -devel suffix from fluxbox
program names.

Or something.

# Adam


--
Adam Weinberger
adam@vectors.cx // adamw@FreeBSD.org // adamw@magnesium.net
http://www.vectors.cx
Comment 8 Jeremy Messenger 2004-01-22 18:18:23 UTC
On Thu, 22 Jan 2004 13:11:01 -0500, Adam Weinberger <adamw@FreeBSD.org> 
wrote:

>>> (01.22.2004 @ 1302 PST): Jeremy Messenger said, in 2.5K: <<
>> On Thu, 22 Jan 2004 06:17:02 -0500, Adam Weinberger <adamw@FreeBSD.org>
>> wrote:
>> >One thing though: stuff should be added to the pkg-message to caution
>> >people that their menus will probably need to be regenerated, because
>> >all references to fbrun-devel, etc. are going to fail.
>>
>> Oh yeah, you are right. Does this new diff of pkg-message looks good?
>>
>> --------------------------new-fluxbox-devel.diff--------------------------
>> diff -ur fluxbox-devel.orig/pkg-message fluxbox-devel/pkg-message
>> --- fluxbox-devel.orig/pkg-message	Tue Nov 18 10:26:51 2003
>> +++ fluxbox-devel/pkg-message	Thu Jan 22 11:58:16 2004
>> @@ -5,7 +5,16 @@
>>  Check out the RoadMap on http://fluxbox.sourceforge.net/roadmap.php
>>  for more information about upcoming versions.
>>
>> -ATTENTION: As of 0.9.6 the shell script 'startfluxbox-devel' has been
>> added.
>> +ATTENTION: Now, the -devel has been removed and the CONFLICTS to
>> +           x11-wm/fluxbox has been added. The x11-wm/fluxbox-devel
>> +           is stable enough to use daily and we doubt someone will
>> +           install both fluxbox and fluxbox-devel.
>> +
>> +           Since, the '-devel' has been removed and I recommend
>> +           you to regenerated menu or edit the ~/.fluxbox/menu to
>> +           remove the '-devel' to make the things work correct.
>> +
>> +           As of 0.9.6 the shell script 'startfluxbox' has been added.
>>             It should be executed instead of fluxbox itself from
>>             ~/.xinitrc or ~/.xsession.
>>  *******************************************************************************
>> --------------------------new-fluxbox-devel.diff--------------------------
>>> end of "Re: ports/61714: Update port: x11-wm/fluxbox-devel 0.9.7 -> 
>>> 0.9.8, fix an evil memory bug." from Jeremy Messenger <<
>
> Since the '-devel' suffix has been removed, you should either
> use (scriptname) to regenerate the menu, or edit your
> ~/.fluxbox/menu and remove the -devel suffix from fluxbox
> program names.

Either looks good, I like add scriptname (fluxbox-generate_menu) in it so 
I like your better. :-)

pav, do you want me to create a new full diff of fluxbox-devel? Just let 
me know.

Cheers,
Mezz

> Or something.
>
> # Adam
>
>
> --
> Adam Weinberger
> adam@vectors.cx // adamw@FreeBSD.org // adamw@magnesium.net
> http://www.vectors.cx


-- 
bsdforums.org 's moderator, mezz.
Comment 9 Jeremy Messenger 2004-01-22 18:40:49 UTC
On Thu, 22 Jan 2004 19:23:41 +0100, Pav Lucistnik <pav@FreeBSD.org> wrote:

> V Ät, 22. 01. 2004 v 19:20, Jeremy Messenger píše:
>
>>  pav, do you want me to create a new full diff of fluxbox-devel? Just 
>> let
>>  me know.
>
> Yes please that would ease my job a bit.

Ok, here it is.. The full summary is:

-Update to 0.9.8
-Remove the '-devel' (ex: $prefix/bin/fluxbox and etc)
-Add CONFLICTS against x11-wm/fluxbox
-Change maintainer to Jeremy Messenger <mezz7@cox.net>

I think, I didn't leave anything out so far.. Thanks!

Cheers,
Mezz


-- 
bsdforums.org 's moderator, mezz.
Comment 10 Pav Lucistnik freebsd_committer freebsd_triage 2004-01-22 20:32:37 UTC
State Changed
From-To: feedback->closed

Committed, thanks!