Bug 62689 - maintainer update: net/p5-IO-INET to version 2.01
Summary: maintainer update: net/p5-IO-INET to version 2.01
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Mathieu Arnold
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-11 13:50 UTC by Mohacsi Janos
Modified: 2004-02-25 12:21 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (2.33 KB, patch)
2004-02-11 13:50 UTC, Mohacsi Janos
no flags Details | Diff
p5-IO-INET6.diff2 (3.28 KB, TEXT/PLAIN; charset=US-ASCII)
2004-02-23 18:09 UTC, Mohacsi Janos
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mohacsi Janos 2004-02-11 13:50:00 UTC
	Maintainer update: to net/p5-IO-INET6 to version 2.01
	original package changes: 
	- remove deprecated IPv6 API getipnode()
	- completely protocol independent now
	- more test suite
	- relies on  Socket6-0.12 or later
	- bugfixes in parse and tests
	- peerhost method fix
	port changes:
	- check existence at least of perl 5.6.1
	- mention protocol independence in pkg-descr

	This patch supercedes ports/59675 (responsible mat).

How-To-Repeat: 	Apply this diff.
Comment 1 Mathieu Arnold freebsd_committer freebsd_triage 2004-02-11 13:58:27 UTC
Responsible Changed
From-To: freebsd-ports-bugs->mat

get this one
Comment 2 Mathieu Arnold freebsd_committer freebsd_triage 2004-02-11 15:15:43 UTC
State Changed
From-To: open->feedback
Comment 3 Mathieu Arnold freebsd_committer freebsd_triage 2004-02-11 15:29:52 UTC

+-le 11/02/2004 05:58 -0800, Mathieu Arnold écrivait :
| Synopsis: maintainer update: net/p5-IO-INET to version 2.01

I don't understand why you removed the patch and said it was only for 5.6.1.
The only thing which needs 5.6.1 is the test with the "no utf8" which just
say not to use utf8 at all, which is just what 5.005_03 does.

-- 
Mathieu Arnold
Comment 4 Mohacsi Janos 2004-02-23 13:29:58 UTC
Hi Mathieu,

=09If you look at the patch you can find, that
the 'our' keyword and SO_REUSEPORT socket option is missing in perl
version 5.005_03. It is not related to utf8. I decided to require at least
version 5.6 for this module. I know this is painful for FreeBSD 4.x
users ...


Best Regards,

Janos Mohacsi
Network Engineer, Research Associate
NIIF/HUNGARNET, HUNGARY
Key 00F9AF98: 8645 1312 D249 471B DBAE  21A2 9F52 0D1F 00F9 AF98

On Wed, 11 Feb 2004, Mathieu Arnold wrote:

>
>
> +-le 11/02/2004 05:58 -0800, Mathieu Arnold =E9crivait :
> | Synopsis: maintainer update: net/p5-IO-INET to version 2.01
>
> I don't understand why you removed the patch and said it was only for 5.6=
=2E1.
> The only thing which needs 5.6.1 is the test with the "no utf8" which jus=
t
> say not to use utf8 at all, which is just what 5.005_03 does.
>
> --
> Mathieu Arnold
Comment 5 Mathieu Arnold freebsd_committer freebsd_triage 2004-02-23 13:42:26 UTC

+-Le 23/02/2004 14:29 +0100, Mohacsi Janos a dit :
| Hi Mathieu,
| 
| 	If you look at the patch you can find, that
| the 'our' keyword and SO_REUSEPORT socket option is missing in perl
| version 5.005_03. It is not related to utf8. I decided to require at least
| version 5.6 for this module. I know this is painful for FreeBSD 4.x
| users ...

Well, the patch did just what was needed to replace the 'our' and
SO_REUSEPORT, so I don't understand...


-- 
Mathieu Arnold
Comment 6 Mohacsi Janos 2004-02-23 13:58:51 UTC
Hi Mathieu,

On Mon, 23 Feb 2004, Mathieu Arnold wrote:

>
>
> +-Le 23/02/2004 14:29 +0100, Mohacsi Janos a dit :
> | Hi Mathieu,
> |
> | 	If you look at the patch you can find, that
> | the 'our' keyword and SO_REUSEPORT socket option is missing in perl
> | version 5.005_03. It is not related to utf8. I decided to require at least
> | version 5.6 for this module. I know this is painful for FreeBSD 4.x
> | users ...
>
> Well, the patch did just what was needed to replace the 'our' and
> SO_REUSEPORT, so I don't understand...

The reasoning is following:
- According to the Perl developers the current stable release is 5.8.3. We
really should not stick to the old, not really maintained release.

- The developer of the p5-IO-INET6 port is working with perl version
5.8.x. I can easily test on perl 5.6.x and 5.8.x., therefore maintain the
port. Testing on 5.005 is much more difficult for me ...

- Please speak up (in a personal e-mail) if you want to keep the
compatibility with 5.005_03. If I receive more than one e-mail, I will
continue maintain the 5.005_03 compatibility.

- Anyway there is a method to apply a patch if a certain perl version is
not installed?

Best Regards,
Comment 7 Mathieu Arnold freebsd_committer freebsd_triage 2004-02-23 14:08:11 UTC
+-Le 23/02/2004 14:58 +0100, Mohacsi Janos a dit :
| Hi Mathieu,
| 
| On Mon, 23 Feb 2004, Mathieu Arnold wrote:
| 
|> 
|> 
|> +-Le 23/02/2004 14:29 +0100, Mohacsi Janos a dit :
|> | Hi Mathieu,
|> | 
|> | 	If you look at the patch you can find, that
|> | the 'our' keyword and SO_REUSEPORT socket option is missing in perl
|> | version 5.005_03. It is not related to utf8. I decided to require at
|> | least version 5.6 for this module. I know this is painful for FreeBSD
|> | 4.x users ...
|> 
|> Well, the patch did just what was needed to replace the 'our' and
|> SO_REUSEPORT, so I don't understand...
| 
| The reasoning is following:
| - According to the Perl developers the current stable release is 5.8.3. We
| really should not stick to the old, not really maintained release.
| 
| - The developer of the p5-IO-INET6 port is working with perl version
| 5.8.x. I can easily test on perl 5.6.x and 5.8.x., therefore maintain the
| port. Testing on 5.005 is much more difficult for me ...
| 
| - Please speak up (in a personal e-mail) if you want to keep the
| compatibility with 5.005_03. If I receive more than one e-mail, I will
| continue maintain the 5.005_03 compatibility.
| 
| - Anyway there is a method to apply a patch if a certain perl version is
| not installed?

Well, until 5-STABLE is branched, we'll have too :)
the easiest thing is like it's done in mail/p5-Net-Server-Mail/Makefile
add some EXTRA_PATCHES with a patch in files directory named like I did for
instance.

-- 
Mathieu Arnold
Comment 8 Mohacsi Janos 2004-02-23 18:09:30 UTC
Hi Mathieu,

Here I send the modified diff to the net/p5-IO-INET that makes usable on
perl 5.005_03 also.

Best Regards,
	Janos Mohacsi

>
> Well, until 5-STABLE is branched, we'll have too :)
> the easiest thing is like it's done in mail/p5-Net-Server-Mail/Makefile
> add some EXTRA_PATCHES with a patch in files directory named like I did for
> instance.
>
Comment 9 Mathieu Arnold freebsd_committer freebsd_triage 2004-02-25 12:20:24 UTC
State Changed
From-To: feedback->closed

Committed, thanks :)