Bug 62954 - arts breaks emulators/wine
Summary: arts breaks emulators/wine
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Gerald Pfeifer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-17 11:30 UTC by Csaba Molnar
Modified: 2004-02-23 22:40 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Molnar 2004-02-17 11:30:19 UTC 
New wine port (20040213) fails to build with the following error - (see also this thread: http://www.freebsdforums.org/forums/showthread.php?s=&postid=104685#post104685):

    cd `dirname winmm/winealsa/__depend__` && make depend
./../../tools/makedep -I. -I. -I../../../include -I../../../include  -C. audio.
c  audio_05.c  alsa.c  midi.c
cd `dirname winmm/winearts/__depend__` && make depend
./../../tools/makedep -I. -I. -I../../../include -I../../../include -I/usr/loca
l/include/artsc -D_THREAD_SAFE -I/usr/local/include/glib-2.0 -I/usr/local/lib/gl
ib-2.0/include -C. arts.c  audio.c
Unknown option '-D_THREAD_SAFE'
Usage: ../../../tools/makedep [options] [files]
Options:
   -Idir   Search for include files in directory 'dir'
   -Cdir   Search for source files in directory 'dir'
   -fxxx   Store output in file 'xxx' (default: Makefile)
   -sxxx   Use 'xxx' as separator (default: "### Dependencies")
*** Error code 1

Stop in /usr/ports/emulators/wine/work/wine-20040213/dlls/winmm/winearts.
*** Error code 1

Stop in /usr/ports/emulators/wine/work/wine-20040213/dlls.
*** Error code 1

Stop in /usr/ports/emulators/wine/work/wine-20040213.
*** Error code 1

Stop in /usr/ports/emulators/wine.

Fix: 

I'm sorry :(
How-To-Repeat: Type make in /usr/ports/emulators/wine
Comment 1 Kirill Ponomarev freebsd_committer freebsd_triage 2004-02-17 12:45:05 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->gerald

Over to maintainer.
Comment 2 Gerald Pfeifer freebsd_committer freebsd_triage 2004-02-17 12:58:16 UTC 
Responsible Changed
From-To: gerald->kde

This is not a Wine bug.   Rather, something on your system improperly 
adds a -D... directive to the INCLUDE variable, and I believe its the arts 
port.
Comment 3 Michael Nottebrock freebsd_committer freebsd_triage 2004-02-17 13:42:49 UTC 
Responsible Changed
From-To: kde->gerald

This is a Wine bug after all. Wine uses the output of 'artsc-config --cflags' 
and expects it to exclusively contain -I statements (and possibly "-pthread", 
which it filters out via sed in configure).
Comment 4 Michael Nottebrock 2004-02-17 13:55:15 UTC 
Proposed fix (untested):


--- configure.orig	Tue Feb 17 14:52:33 2004
+++ configure	Tue Feb 17 14:53:12 2004
@@ -11188,7 +11188,7 @@
 
 if test x$ARTSCCONFIG != x -a x$ARTSCCONFIG != x'"$ARTSCCONFIG"';
 then
-    ARTSC_CFLAGS=`$ARTSCCONFIG --cflags | sed 's/\-pthread//'`
+    ARTSC_CFLAGS=`$ARTSCCONFIG --cflags | sed -e 's/\-pthread//' -e 's/-D_THREAD_SAFE//'`
     ARTSC_LIBS=`$ARTSCCONFIG --libs`
     save_CFLAGS="$CFLAGS"
     CFLAGS="$CFLAGS $ARTSC_CFLAGS"
Comment 5 Csaba Molnar 2004-02-17 16:11:59 UTC 
Thank you very much! It seems to work now :) 
ps: that was fast!
Comment 6 Gerald Pfeifer freebsd_committer freebsd_triage 2004-02-23 22:40:00 UTC 
State Changed
From-To: open->closed

This should be fixed by an update to the emulators/wine port which I just 
committed.