Bug 63216 - [patch] 'BROKEN' or 'IGNORED' ports exit their "make install" with a success status.
Summary: [patch] 'BROKEN' or 'IGNORED' ports exit their "make install" with a success ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-22 13:20 UTC by Jamie Jones
Modified: 2006-01-28 02:13 UTC (History)
0 users

See Also:

Attachments
bsd.port.mk.patch (585 bytes, patch)
2005-01-14 00:45 UTC, Sergey Matveychuk 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jamie Jones 2004-02-22 13:20:15 UTC 
	When attempting to install a port which fails due to being
	marked BROKEN, the make exits with a success status, meaning
	that any scripts that make a port and then delete the previous
	port on successful compile end up deleting the only installed
	working version.

Fix: 

Make ignored/broken ports exit "1" from the make
How-To-Repeat: 	cd /usr/ports/multimedia/ffmpeg  (for example)
	make clean; make && make deinstall

        Although this port is currently marked broken, and won't compile, the
	installed port is deleted as the make exitted with "success" status.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2004-02-22 22:02:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

This looks like a bsd.port.mk issue.
Comment 2 Kris Kennaway freebsd_committer freebsd_triage 2004-03-21 02:27:09 UTC 
State Changed
From-To: open->suspended

Suspended awaiting patch
Comment 3 Sergey Matveychuk freebsd_committer freebsd_triage 2005-01-14 00:45:16 UTC 
State Changed
From-To: suspended->open

A patch was reseived
Comment 4 Sergey Matveychuk freebsd_committer freebsd_triage 2005-01-14 00:45:20 UTC 
The patch is easy enough.
Does it OK for pointyhat builds?

-- 
Sem.
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2006-01-21 20:00:42 UTC 
State Changed
From-To: open->analyzed

Accepted for a test build on the cluster.
Comment 6 Mark Linimon freebsd_committer freebsd_triage 2006-01-28 02:13:16 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks.