Bug 63230 - [MAINTAINER] net/smokeping: update to 1.26
Summary: [MAINTAINER] net/smokeping: update to 1.26
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-22 16:40 UTC by Lars Thegler
Modified: 2004-02-24 12:42 UTC (History)
1 user (show)

See Also:


Attachments
smokeping.diff (27.34 KB, patch)
2004-02-22 16:40 UTC, Lars Thegler
no flags Details | Diff
su.diff (419 bytes, patch)
2004-02-22 21:27 UTC, Lars Thegler
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Thegler 2004-02-22 16:40:08 UTC
- Update to 1.26
- Use OPTIONS for optional dependencies
- Change pkg-{,de}install to avoid risk of data loss when upgrading
- Patch files instead of regexps in Makefile

Committer, please note the following added files:

files/patch-bin-smokeping.dist
files/patch-etc-config.dist
files/patch-htdocs-smokeping.cgi.dist
files/patch-lib-probes-Curl.pm
files/patch-lib-probes-EchoPing.pm
files/patch-lib-probes-EchoPingChargen.pm
files/patch-lib-probes-EchoPingDiscard.pm
files/patch-lib-probes-EchoPingHttp.pm
files/patch-lib-probes-EchoPingHttps.pm
files/patch-lib-probes-EchoPingIcp.pm
files/patch-lib-probes-EchoPingSmtp.pm
files/patch-lib-probes-IOSPing.pm
files/patch-lib-probes-RemoteFPing.pm
files/patch-lib-probes-LDAP.pm
files/patch-lib-probes-Radius.pm
files/patch-lib-probes-passwordchecker.pm
Comment 1 Lars Thegler 2004-02-22 21:27:14 UTC
Thomas-Martin Seck pointed out that when the port is being installed by 
a non-root-user, the pre-install target will fail. This patch will fix that.
Comment 2 Clement Laforet freebsd_committer freebsd_triage 2004-02-23 11:56:16 UTC
without BATCH=yes, I got this error:

===>  Building for smokeping-1.26
"Makefile", line 22: warning: duplicate script for target "doc/%.1" ignored
"Makefile", line 24: warning: duplicate script for target "doc/%.1" ignored
"Makefile", line 26: warning: duplicate script for target "doc/%.1" ignored
"Makefile", line 31: warning: duplicate script for target "doc/%.html" ignored
"Makefile", line 33: warning: duplicate script for target "doc/%.html" ignored
"Makefile", line 35: warning: duplicate script for target "doc/%.html" ignored
Error expanding embedded variable.
*** Error code 2

Can you please investigate ?

clem
Comment 3 Lars Thegler 2004-02-23 22:05:49 UTC
Clement Laforet wrote:
> without BATCH=yes, I got this error:
> ===>  Building for smokeping-1.26
> "Makefile", line 22: warning: duplicate script for target "doc/%.1" ignored

The distribution Makefile is only run during two targets: the do-build 
and do-install targets.

In the smokeping port, the distribution Makefile is not supposed to be 
run. The do-build target is disabled by NO_BUILD=yes, and the do-install 
target is overridden in the ports Makefile. The "Building ..." line 
indicates that the do-build target is not disabled after all. Do you 
have any idea why this might be the case on your installation? Did the 
patch apply cleanly?

I am really sorry, but I need more information to go on. In what way 
does specifying BATCH=yes change the symptoms you see?

/Lars
Comment 4 Oliver Eikemeier freebsd_committer freebsd_triage 2004-02-24 12:42:01 UTC
State Changed
From-To: open->closed

Committed, thanks.