Bug 63427 - Disabling the Java frontend at compile time
Summary: Disabling the Java frontend at compile time
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Gerald Pfeifer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-27 02:40 UTC by erob
Modified: 2004-07-05 22:02 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description erob 2004-02-27 02:40:07 UTC 

The Java frontend included in the ports collection is turn on by default 
according to the lang/gcc33 Makefile. 
You may turn it off by setting the --enable-languages=foo,baz option at compile time.

Fix: 

.if defined(WANT_JAVA) 
CONFIGURE_ARGS+=	--enable-languages=c,c++,java
.else
CONFIGURE_ARGS+=	--enable-languages=c,c++
.endif
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2004-02-27 06:28:56 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->gerald

Over to maintainer.
Comment 2 Gerald Pfeifer freebsd_committer freebsd_triage 2004-02-27 11:02:01 UTC 
State Changed
From-To: open->feedback

In principle, I am in favor of such a patch, if 
- it works in both cases (which it currently does not), 
- the default is not changed (that is, java is built by default), 
- and you do not disable further languages like f77 (which you currently do). 

To see the problems with the current patch, please run the tests described in 
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-testing.html 

I am looking forward to an updated patch. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=63427 

Adding to audit trail from misfiled PR ports/63429 by kris:

 > .if defined(WANT_JAVA) 

 WANT_* is wrong, use WITH_* and WITHOUT_* for user control of build options.
Comment 3 Gerald Pfeifer freebsd_committer freebsd_triage 2004-05-03 18:37:11 UTC 
State Changed
From-To: feedback->suspended

This does seem too complex for too little benefit (since we can already 
disable libgcj).
Comment 4 Gerald Pfeifer freebsd_committer freebsd_triage 2004-07-05 22:00:57 UTC 
State Changed
From-To: suspended->closed

I thought this through, several times over the recent weeks, and I think 
we should avoid adding this extra piece of complexity -- the main benefit 
really can be gained be disabling libgcj, and we already have a hook for 
that.