Bug 64204 - sysutils/gtk-send-pr: fix build with new GTK (2.3/4)
Summary: sysutils/gtk-send-pr: fix build with new GTK (2.3/4)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pav Lucistnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-13 09:20 UTC by Brian Gruber
Modified: 2004-03-15 00:33 UTC (History)
0 users

See Also:


Attachments
gtk-send-pr.diff (509 bytes, patch)
2004-03-13 09:20 UTC, Brian Gruber
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Gruber 2004-03-13 09:20:16 UTC
	Port won't compile against the new version of GTK+, due to use
of DISABLE_DEPRECATED.
Comment 1 Miguel Mendez 2004-03-13 10:04:39 UTC
On Sat, 2004-03-13 at 10:17, Brian Gruber wrote:

Hi,

> 	Port won't compile against the new version of GTK+, due to use
> of DISABLE_DEPRECATED.


The DISABLE_DEPRECATED directive is there for a reason. Gratuitously
removing it will only solve the problem in the short term. I'd rather
you posted where exactly did it fail, so I can fix it by using a non
deprecated function.

Cheers,
-- 
	Miguel Mendez <flynn@energyhq.es.eu.org>
	http://www.energyhq.es.eu.org
	PGP Key: 0xDC8514F1
Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2004-03-14 22:25:45 UTC
Dear maintainer of FreeBSD port sysutils/gtk-send-pr, please take a look
at 

http://www.freebsd.org/cgi/query-pr.cgi?pr=64204

Do you approve this change?

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

A mouse is a device used to point at the xterm you want to type in.
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2004-03-14 22:25:48 UTC
State Changed
From-To: open->feedback

Asked maintainer on this 


Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2004-03-14 22:25:48 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pav

Handle
Comment 5 Miguel Mendez 2004-03-14 23:17:22 UTC
On Sun, 2004-03-14 at 23:25, Pav Lucistnik wrote:

Hi,

> Dear maintainer of FreeBSD port sysutils/gtk-send-pr, please take a look
> at 
> 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=64204
> 
> Do you approve this change?


Yes, I approve. The new GTK+ version comes with new Combo Box functions
not present in the current one, so I can't just move the codebase
without breaking compat with the old one. Let's disable the DEPRECATED
knob for now to be able to build on both lib versions. I'll release a
new version with support for both functions in a week or so. Until then,
let's use the suggested solution.

Cheers,
-- 
	Miguel Mendez <flynn@energyhq.es.eu.org>
	http://www.energyhq.es.eu.org
	PGP Key: 0xDC8514F1
Comment 6 Pav Lucistnik freebsd_committer freebsd_triage 2004-03-15 00:33:28 UTC
State Changed
From-To: feedback->closed

Committed, thanks!