see how to repeat How-To-Repeat: # cd /usr/ports/net/trafshow # make
Responsible Changed From-To: gnats-admin->ports ->ports
lib/interfaces.c includes <net/if_slvar.h>, though it doesn't seem to need the only structure defined there (struct sl_softc). I don't think that trafshow should include this file -- at least not on BSD4.4lite platforms. Fix, to be applied after all other patches included in the port: --- lib/interfaces.c Wed Apr 29 13:56:21 1998 +++ lib/interfaces.c Wed Apr 29 13:56:30 1998 @@ -23,7 +23,6 @@ #include <net/if.h> #include <net/slip.h> #include <net/if_var.h> -#include <net/if_slvar.h> #ifdef __FreeBSD__ #include <net/if_ppp.h> #else Jacques Vidrine <n@nectar.com>
On Thu, 30 Apr 1998, Jacques Vidrine wrote: > Fix, to be applied after all other patches included in the port: No, there is already one patch to lib/interfaces.c. Any further patches should be combined with that one (style guide says "two patches no patch one file"). -- Only two other people have a .sig like this one.
-----BEGIN PGP SIGNED MESSAGE----- Hmm, OK. I'm off to find the style guide for next time. Meanwhile, I see a fix has been committed for the problem, though I think the wrong fix. lib/interfaces.c wouldn't compile because it included <net/if_slvar.h>, which references struct slcompress. The distribution shouldn't have included <net/if_slvar.h>, at least not on BSD4.4lite. That header is only needed for struct sl_softc, which trafshow does not reference. Anyway, the name seems to indicate that it should only be included in kernel sources. The fix that was committed just imported all the stuff struct slcompress needed (<net/if_var.h>, <netinet/mbuf.h>, <net/slcompress.h>), which doesn't seem like the right thing. Thanks, Jacques Vidrine <n@nectar.com> On 30 April 1998 at 21:22, Tim Vanderhoek <ac199@hwcn.org> wrote: > On Thu, 30 Apr 1998, Jacques Vidrine wrote: > > > Fix, to be applied after all other patches included in the port: > > No, there is already one patch to lib/interfaces.c. Any further > patches should be combined with that one (style guide says "two > patches no patch one file"). > > > -- > Only two other people have a .sig like this one. > -----BEGIN PGP SIGNATURE----- Version: 2.6.2 iQCVAwUBNUkwDjeRhT8JRySpAQFdjAQAiHQCJvHIkgzd+FvwvBq9ljqRcB1fQbSX DYi++9weYebT9KdibFoM42auBnAjyURsanoH0Cicfc9yCmGn3WVp/KjPylT8okee ytL5c5Qvms8Z/PsfAPyOUwZohRgoL/rqspfkeqMtdVnEJqwPIg1rUJAoyFSuDett DyosdRZGIJw= =3fnG -----END PGP SIGNATURE-----
Responsible Changed From-To: ports->jseger Assign to port's maintainer.
State Changed From-To: open->closed I fixed this a while ago.