Bug 64700 - ispell fixes (leftover .bak files and install error)
Summary: ispell fixes (leftover .bak files and install error)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: jmz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-25 12:10 UTC by Jeremy Chadwick
Modified: 2004-03-25 19:02 UTC (History)
0 users

See Also:


Attachments
file.diff (1.38 KB, patch)
2004-03-25 12:10 UTC, Jeremy Chadwick
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Chadwick 2004-03-25 12:10:21 UTC
	This send-pr contains two fixes: 1) fix ispell leaving .bak files
	laying around TMPDIR (/tmp), and 2) Makefile fix for languages which
	do not use or generate *.hash or *.aff files.
	
	1) ispell creates backup files in TMPDIR (/tmp) when doing spell-checking.
	The problem is that ispell won't unlink (delete) it's own backup files
	if the filename length is greater than MAXNAMLEN.  In config.X, an #ifdef
	check for MAXNAMLEN is done.  If unavailable, it defines a default of 14.
	
	This is particularly annoying for those of us who use mutt, which
	creates temporary files named /tmp/mutt-HOSTNAME-RANDOM8CHARS.  If
	ispell is spawned, tons of .bak files are left laying around /tmp.
	
	"ispell -x" will not work around this problem.
	
	2) During "make install" of the ispell port, one commonly sees the
	following (albeit harmless) error:
	
	install: /usr/ports/textproc/ispell/work/*/*.aff: No such file or directory
	
	*.aff and *.hash files (from what I can tell) only apply to German,
	Finnish, and Polish.  Therefore we now do an .if defined() check before
	firing off that install command.

Fix: 1) Make config.X use dirent.h to get our system-wide MAXNAMLEN.
	
	2) Simple Makefile .if defined() check.
	
	Applicable diff is included below.

How-To-Repeat: 	1) Run "ispell -vv".  Otherwise, run mutt, make some typos in your
	editor, hit "i" to spawn ispell (prior to sending), apply changes, hit
	"x", then find .bak files laying around /tmp.
	
	2) Run "make install" without using certain ISPELL_xx hooks.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2004-03-25 14:26:12 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jmz

Over to maintainer.
Comment 2 jmz freebsd_committer freebsd_triage 2004-03-25 19:02:20 UTC
State Changed
From-To: open->closed

Committed. Thanks!