package leave extra dirs after deinstall. maintainer contacted: 2004-03-20, no response. How-To-Repeat: install port or package, then deinstall.
Responsible Changed From-To: freebsd-ports-bugs->arved over to maintainer
State Changed From-To: open->closed Sorry for forgetting your PR. There were problems with your patch, as the PLIST_DIRS Macro does not support conditionals, and the directories were only created in the WITH NLS case. Also I could not dirrm the directories since other ports like nmap, samba and cups install localized manpages too. I hope you are satisfied with the solution, I just committed. BTW, imho this directories should be created by mtree (like the de-manpages).
> There were problems with your patch, as the PLIST_DIRS Macro > does not support conditionals, and the directories were only created > in the WITH NLS case. easy to solve, you can move the PLIST_FILES/PLIST_DIRS definition in the conditional part of the makefile. > Also I could not dirrm the directories since other > ports like nmap, samba and cups install localized manpages too. It just fails to delete teh dir then, so when you delete the last port of nmap, samba and cups the directory shall vanish > I hope you are satisfied with the solution, I just > committed. BTW, imho this directories should be created by mtree (like the > de-manpages). Looks fine ... Thanks. The patch down here ist just an example, how it can be done without PLIST_SUB. kind regards Dirk - Dirk Meyer, Im Grund 4, 34317 Habichtswald, Germany - [dirk.meyer@dinoex.sub.org],[dirk.meyer@guug.de],[dinoex@FreeBSD.org] Index: Makefile =================================================================== RCS file: /home/pcvs/ports/misc/help2man/Makefile,v retrieving revision 1.10 diff -u -u -r1.10 Makefile --- Makefile 30 Mar 2004 09:29:47 -0000 1.10 +++ Makefile 30 Mar 2004 19:26:18 -0000 @@ -21,10 +21,12 @@ RUN_DEPENDS= ${BUILD_DEPENDS} MANLANG= "" pl fr -PLIST_SUB= NLS="" +PLIST_FILES+= lib/hacklocaledir.so \ + share/locale/fr/LC_MESSAGES/help2man.mo \ + share/locale/pl/LC_MESSAGES/help2man.mo \ +PLIST_DIRS+= man/fr/man1 man/pl/man1 .else CONFIGURE_ARGS+= --disable-nls -PLIST_SUB= NLS="@comment " .endif WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION} @@ -34,5 +36,7 @@ MAN1= help2man.1 INFO= help2man + +PLIST_FILES+= bin/help2man .include <bsd.port.mk> Index: pkg-plist =================================================================== RCS file: /home/pcvs/ports/misc/help2man/pkg-plist,v retrieving revision 1.4 diff -u -u -r1.4 pkg-plist --- pkg-plist 30 Mar 2004 09:29:47 -0000 1.4 +++ pkg-plist 30 Mar 2004 19:26:18 -0000 @@ -1,6 +0,0 @@ -bin/help2man -%%NLS%%lib/hacklocaledir.so -%%NLS%%share/locale/fr/LC_MESSAGES/help2man.mo -%%NLS%%share/locale/pl/LC_MESSAGES/help2man.mo -%%NLS%%@unexec rmdir %D/man/fr/man1 2>/dev/null || true -%%NLS%%@unexec rmdir %D/man/pl/man1 2>/dev/null || true