Bug 65440 - munin-node port removes customized plugins upon deinstall
Summary: munin-node port removes customized plugins upon deinstall
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-11 16:10 UTC by kasahara
Modified: 2004-04-20 22:48 UTC (History)
0 users

See Also:


Attachments
munin-node.patch (559 bytes, patch)
2004-04-16 16:21 UTC, Lupe Christoph
no flags Details | Diff
munin-node.patch (918 bytes, patch)
2004-04-16 16:24 UTC, Lupe Christoph
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description kasahara 2004-04-11 16:10:23 UTC
	pkg-plist of munin-node-1.0.0.p3_1 still contains 
	'rm -rf %D/etc/munin/plugins', so customized plugin files in the
	directory will be removed when it is uninstalled.  Upgrading the
	port is dangerous....  deinstalling port shouldn't remove the
	modified files, I believe.

        Also, I guess modified config files will be deleted too...
	(I didn't try that yet)

Fix: 

delete 'rm -rf' line from plist
	similar modification check of config files such as apache2 ports
How-To-Repeat:    
        deinstall the package.
Comment 1 Volker Stolz freebsd_committer freebsd_triage 2004-04-16 15:07:56 UTC
Dear maintainer of sysutils/munin-node, could you please review the 
proposed patch at:
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/65440

Regards,
   Volker
Comment 2 Volker Stolz freebsd_committer freebsd_triage 2004-04-16 15:09:41 UTC
State Changed
From-To: open->feedback

Asked maintainer for feedback.
Comment 3 Lupe Christoph 2004-04-16 16:21:59 UTC
On Friday, 2004-04-16 at 16:07:56 +0200, Volker Stolz wrote:
> Dear maintainer of sysutils/munin-node, could you please review the 
> proposed patch at:
> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/65440

The attached mini-patch corrects the thinko in package removal. (I
*hate* it that ports can't be upgraded without removing them.)

.../etc/munin/plugins should not contain files, just symlinks. Please
put custom plugins somewhere else (maybe .../share/munin/plugins.local)
and link to them.

Lupe Christoph
-- 
| lupe@lupe-christoph.de       |           http://www.lupe-christoph.de/ |
| "Violence is the resort of the violent" Lu Tze                         |
| "Thief of Time", Terry Pratchett                                       |
Comment 4 Lupe Christoph 2004-04-16 16:23:38 UTC
On Friday, 2004-04-16 at 17:21:59 +0200, lupe wrote:

> The attached mini-patch corrects the thinko in package removal. (I
> *hate* it that ports can't be upgraded without removing them.)

The moment after I sent this I remembered I had not bumped the
PORTREVISION. Corrected patch attached.

Lupe Christoph
-- 
| lupe@lupe-christoph.de       |           http://www.lupe-christoph.de/ |
| "Violence is the resort of the violent" Lu Tze                         |
| "Thief of Time", Terry Pratchett                                       |
Comment 5 Lupe Christoph 2004-04-16 16:24:32 UTC
On Friday, 2004-04-16 at 17:23:38 +0200, lupe wrote:
> On Friday, 2004-04-16 at 17:21:59 +0200, lupe wrote:

> > The attached mini-patch corrects the thinko in package removal. (I
> > *hate* it that ports can't be upgraded without removing them.)

> The moment after I sent this I remembered I had not bumped the
> PORTREVISION. Corrected patch attached.

My only excuse is we have Foen today...

Lupe Christoph
-- 
| lupe@lupe-christoph.de       |           http://www.lupe-christoph.de/ |
| "Violence is the resort of the violent" Lu Tze                         |
| "Thief of Time", Terry Pratchett                                       |
Comment 6 Volker Stolz freebsd_committer freebsd_triage 2004-04-20 14:40:35 UTC
State Changed
From-To: feedback->analyzed

Solution is in ports/65814.
Comment 7 Pav Lucistnik freebsd_committer freebsd_triage 2004-04-20 22:48:10 UTC
State Changed
From-To: analyzed->closed

Fix committed.