Comment 1 Kirill Ponomarev 2004-05-01 08:32:25 UTC

Responsible Changed
From-To: freebsd-ports-bugs->petef

Over to maintainer.

Comment 2 Pete Fritchman 2004-05-02 19:25:11 UTC

State Changed
From-To: open->feedback

Hmm. This compiles on -current for me, but not -stable: 

> ccache cc  -O -pipe    -o joe  b.o blocks.o bw.o cmd.o hash.o help.o kbd.o macro.o main.o menu.o path.o poshist.o pw.o queue.o qw.o rc.o regex.o scrn.o tab.o termcap.o tty.o tw.o ublock.o uedit.o uerror.o ufile.o uformat.o uisrch.o umath.o undo.o usearch.o ushell.o utag.o va.o vfile.o vs.o w.o utils.o syntax.o wcwidth.o utf8.o selinux.o  -lncurses -L/usr/local/lib -liconv 
> regex.o: In function `pmatch': 
> regex.o(.text+0x983): undefined reference to `towupper' 
> regex.o(.text+0x98e): undefined reference to `towupper' 
> utils.o: In function `isalnum_': 
> utils.o(.text+0x118): undefined reference to `iswalnum' 
> gmake: *** [joe] Error 1

Comment 3 Pav Lucistnik 2004-05-27 16:53:45 UTC

Please check out this additional patch to Makefile (apply on top of
krion's work):


--- joe-devel/Makefile	Thu May 27 17:51:48 2004
+++ joe-pav/Makefile	Thu May 27 17:46:03 2004
@@ -26,10 +26,19 @@
 
 USE_GMAKE=	yes
 USE_ICONV=	yes
+USE_REINPLACE=	yes
 
 ALL_TARGET=	joe
 MAN1=		joe.1
 
+.include <bsd.port.pre.mk>
+
+.if ${OSVERSION} < 500000
+post-patch:
+	@${REINPLACE_CMD} -e 's/towupper/__toupper/g' ${WRKSRC}/regex.c
+	@${REINPLACE_CMD} -e 's/iswalnum(c)/__istype(c, _CTYPE_A|_CTYPE_D)/' ${WRKSRC}/utils.c
+.endif
+
 post-install:
 .if !defined(NOPORTDOCS)
 	@${MKDIR} ${DOCSDIR}
@@ -42,4 +51,4 @@
 .endif
 .endfor
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>


Builds on 4.x and works (I tried seeking words under UTF-8 locale, it
works as expected).

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

Stupidity got us into this mess -- why can't it get us out?

Comment 4 Pav Lucistnik 2004-05-27 17:07:05 UTC

State Changed
From-To: feedback->open

Feedback received. ;)

Hi,

On Thu, May 27, 2004 at 05:53:45PM +0200, Pav Lucistnik wrote:
> Please check out this additional patch to Makefile (apply on top of
> krion's work):

I sent a similar patch one month ago to maintainer but got no
response from him.

-Kirill

Comment 6 Pav Lucistnik 2004-05-27 21:32:57 UTC

V èt, 27. 05. 2004 v 21:28, Kirill Ponomarew pí¹e:

> On Thu, May 27, 2004 at 05:53:45PM +0200, Pav Lucistnik wrote:
> > Please check out this additional patch to Makefile (apply on top of
> > krion's work):
> 
> I sent a similar patch one month ago to maintainer but got no
> response from him.


Too bad you haven't Cc'ed it to GNATS, we could apply maintainer timeout
by now.

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

Any sufficiently advanced technology is indistinguishable from magic.
  -- Arthur C. Clarke

Hi,

On Thu, May 27, 2004 at 10:32:57PM +0200, Pav Lucistnik wrote:
 
> Too bad you haven't Cc'ed it to GNATS, we could apply maintainer timeout
> by now.


You can apply maintainer timeout without GNATS also, I can
affirm and bounce the second patch to somebody who has doubts
about that.

-Kirill

Comment 8 Pav Lucistnik 2004-05-27 21:54:31 UTC

V èt, 27. 05. 2004 v 22:47, Kirill Ponomarew pí¹e:

> > Too bad you haven't Cc'ed it to GNATS, we could apply maintainer timeout
> > by now.
> 
> You can apply maintainer timeout without GNATS also, I can
> affirm and bounce the second patch to somebody who has doubts
> about that.


I like to have things look official, but if you're willing to take
responsibility, then go ahead, commit the update and close the PR.

Thank you!

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

Stupidity got us into this mess -- why can't it get us out?

Go ahead and commit -- sorry about the delay, guys, been swamped
at work..

--pete

Comment 10 Kirill Ponomarev 2004-05-28 19:00:25 UTC

State Changed
From-To: open->closed

Committed.