Bug 66892 - possible bug in philosophy of ports/MOVED
Summary: possible bug in philosophy of ports/MOVED
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-05-19 16:40 UTC by Mark Linimon
Modified: 2006-01-27 19:41 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Linimon 2004-05-19 16:40:20 UTC
	portsmon relies on the MOVED file to determine when it considers
	a port to be obsolete.  Currently, it considers devel/linux_devtools
	to be obsolete -- but it isn't.

	Here's the history:

devel/linux_devtools/Makefile:
revision 1.35
date: 2003/04/17 11:38:43;  author: edwin;  state: dead;  lines: +1 -1
It seemed that devel/linux_devtools was repocopied to linux_develtools-6
and linux_devtools-7, but that the original directory never was
removed. Finished this action and update dependencies.

MOVED:
revision 1.100
date: 2003/04/17 11:38:42;  author: edwin;  state: Exp;  lines: +2 -1
devel/linux_devtools|devel/linux_devtools-6|2003-04-17|finished repocopy

devel/linux_devtools/Makefile:
revision 1.36
date: 2003/10/12 05:47:42;  author: trevor;  state: Exp;  lines: +61 -82
Add linux_devtools 8.0.

	So as of 2003/04/17, portsmon is happy to report that the new
	location of devel/linux_devtools is devel/linux_devtools6.  And
	so it remains to this day.

Fix: 

I guess I can work around this in portsmon ... somehow.  But
	shouldn't there be some kind of notation added to MOVED when
	something gets reintroduced?  (I can imagine this problem
	affecting FreshPorts as well).
How-To-Repeat: 	(n/a)
Comment 1 Oliver Eikemeier 2004-05-19 17:15:06 UTC
Mark Linimon wrote:

> 	I guess I can work around this in portsmon ... somehow.  But
> 	shouldn't there be some kind of notation added to MOVED when
> 	something gets reintroduced?  (I can imagine this problem
> 	affecting FreshPorts as well).

Yep. I don't know what to check for in MOVEDlint, and I'm not sure what
the proper semantics are: has OpenLDAP 2.0 moved to OpenLDAP 2.1, or
is it simply deleted?

We have to clarify that for MOVED to be useful for automated tools.

-Oliver
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2004-05-19 17:36:56 UTC
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

Ports meta-issue. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=66892 

Adding to audit trail from misfiled PR ports/66895:

 I just checked http://www.freshports.org/devel/linux_devtools/ and it
 reports:
 
 Port Moves
 port moved to devel/linux_devtools-6 on 2003-04-17
 REASON: finished repocopy
 
 And that is all.
 
 FWIW, FreshProts determines that a port no longer exists when the Makefile
 is explicitly removed via a commit.  Therefore, this port is not marked as
 deleted.  That is one of the limitations of FreshPorts with respect
 to repocopies.
 
 -- 
 Dan Langille - BSDCan: http://www.bsdcan.org/

Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2006-01-27 18:49:29 UTC
As the most prominent consumer of MOVED file, portupgrade, does not grok
well the state when port is listed in MOVED but still present in the
tree, and people are coming up with "wtf?" in regular interval,
I propose to sweep the MOVED file and remove such lines (there is 28
instances at the moment).

I'll do that, unless I hear a "stop!" from Mark/portmgr.

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

lofi> My _sympathetic_ opinion about kdevelop is that it's a huge pile
of shit that might at least work okay if used in Linux.
lofi> My neutral opinion is that it's just a huge pile of shit.
Comment 4 Mark Linimon 2006-01-27 19:13:45 UTC
On Fri, Jan 27, 2006 at 07:49:29PM +0100, Pav Lucistnik wrote:
> As the most prominent consumer of MOVED file, portupgrade, does not grok
> well the state when port is listed in MOVED but still present in the
> tree, and people are coming up with "wtf?" in regular interval,
> I propose to sweep the MOVED file and remove such lines (there is 28
> instances at the moment).

My own personal opinion is that this is a bug in portupgrade, OTOH
what's already happened is that the "history" in MOVED has already been
erased to some degree, leaving it half with "history" and half with
"reflects current tree".  Since we're already halfway there we should
finish the job and you should go ahead and commit these changes and close
this PR.  The downside (possible misattribution of old PRs) does not
justify actual users getting bitten by this.

We'll just need to document that MOVED reflects the most current state
of the tree.

mcl
Comment 5 Pav Lucistnik freebsd_committer freebsd_triage 2006-01-27 19:39:47 UTC
State Changed
From-To: open->closed

This was solved by removing all resurrected ports from the file, 
and stating a new policy in the header.