Bug 67796 - Update port: multimedia/mmpython from 0.4.2 to 0.4.3
Summary: Update port: multimedia/mmpython from 0.4.2 to 0.4.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-10 15:20 UTC by Lewis Thompson
Modified: 2004-06-10 20:12 UTC (History)
0 users

See Also:


Attachments
file.diff (2.96 KB, patch)
2004-06-10 15:20 UTC, Lewis Thompson
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lewis Thompson 2004-06-10 15:20:25 UTC
	Change the version number and update pkg-plist.
Comment 1 Lewis Thompson 2004-06-10 19:34:01 UTC
Please also include the following patch.  This fixes mmpython so that it
properly detects DVDs, VCDs etc.  This simply changes the seek
boundaries and will be sumitted to Freevo developers shortly.  Patch is
as follows: patch-freebsd-dvd:

diff -ruN disc/discinfo.py disc/discinfo.py
--- disc/discinfo.py	Thu Jun 10 19:22:00 2004
+++ disc/discinfo.py	Thu Jun 10 19:22:59 2004
@@ -223,22 +223,10 @@
     else:
         f = open(device,'rb')
 
-        f.seek(0x0000832d)
-        if os.uname()[0] == 'FreeBSD':
-            # why doesn't seeking to 0x0000832d+40 and reading 32 work?
-            # no idea, do it this way
-            label = f.read(72);
-            label = label[40:72]
-        else:    
-            id = f.read(16)
-        f.seek(32808, 0)
-        if os.uname()[0] == 'FreeBSD':
-            # why doesn't seeking to 32808 + 829 and reading 16 work?
-            # no idea, do it this way
-            id = f.read(829);
-            id = id[813:829]
-        else:
-            label = f.read(32)
+        f.seek(32768)
+        id = f.read(829)
+        label = id[40:72]
+        id = id[813:829]
 
         if CREATE_MD5_ID:
             id_md5 = md5.new()
diff -ruN disc/dvdinfo.py disc/dvdinfo.py
--- disc/dvdinfo.py	Thu Jun 10 19:22:00 2004
+++ disc/dvdinfo.py	Thu Jun 10 19:23:49 2004
@@ -115,8 +115,8 @@
 
         # brute force reading of the device to find out if it is a DVD
         f = open(device,'rb')
-        f.seek(32808, 0)
-        buffer = f.read(50000)
+        f.seek(32768, 0)
+        buffer = f.read(50040)
 
         if buffer.find('UDF') == -1:
             f.close()
@@ -148,8 +148,8 @@
 
     def isDVDiso(self, f):
         # brute force reading of the device to find out if it is a DVD
-        f.seek(32808, 0)
-        buffer = f.read(50000)
+        f.seek(32768, 0)
+        buffer = f.read(50040)
 
         if buffer.find('UDF') == -1:
             return 0
diff -ruN disc/lsdvd.py disc/lsdvd.py
--- disc/lsdvd.py	Thu Jun 10 19:22:00 2004
+++ disc/lsdvd.py	Thu Jun 10 19:24:01 2004
@@ -173,8 +173,8 @@
 
         # brute force reading of the device to find out if it is a DVD
         f = open(device,'rb')
-        f.seek(32808, 0)
-        buffer = f.read(50000)
+        f.seek(32768, 0)
+        buffer = f.read(50040)
 
         if buffer.find('UDF') == -1:
             f.close()
diff -ruN disc/vcdinfo.py disc/vcdinfo.py
--- disc/vcdinfo.py	Thu Jun 10 19:22:00 2004
+++ disc/vcdinfo.py	Thu Jun 10 19:24:13 2004
@@ -62,8 +62,8 @@
         
         # brute force reading of the device to find out if it is a VCD
         f = open(device,'rb')
-        f.seek(32808, 0)
-        buffer = f.read(50000)
+        f.seek(32768, 0)
+        buffer = f.read(50040)
         f.close()
 
         if buffer.find('SVCD') > 0 and buffer.find('TRACKS.SVD') > 0 and \
diff -ruN video/vcdinfo.py video/vcdinfo.py
--- video/vcdinfo.py	Thu Jun 10 19:22:00 2004
+++ video/vcdinfo.py	Thu Jun 10 19:24:29 2004
@@ -85,8 +85,8 @@
         
         # brute force reading of the bin to find out if it is a VCD
         f = open(bin,'rb')
-        f.seek(32808, 0)
-        buffer = f.read(50000)
+        f.seek(32768, 0)
+        buffer = f.read(50040)
         f.close()
 
         if buffer.find('SVCD') > 0 and buffer.find('TRACKS.SVD') > 0 and \

-lewiz.

-- 
I was so much older then, I'm younger than that now.  --Bob Dylan, 1964.
------------------------------------------------------------------------
-| msn:purple@lewiz.net | jabber:lewiz@jabber.org | url:www.lewiz.org |-
Comment 2 Kirill Ponomarev freebsd_committer freebsd_triage 2004-06-10 20:12:24 UTC
State Changed
From-To: open->closed

Committed, thanks!