Bug 67920 - devel/perforce version information missing
Summary: devel/perforce version information missing
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-14 06:20 UTC by Conrad J. Sabatier
Modified: 2004-06-16 21:31 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Conrad J. Sabatier 2004-06-14 06:20:01 UTC 
/usr/ports/devel/perforce/Makefile needs to have version info filled in.
The current Makefile contains the following lines:

PORTNAME=       perforce
PORTVERSION=    ${VERSION}
PORTREVISION=   ${REVISION}
PORTEPOCH=      1

This causes a warning to be issued when doing a 'portsdb -u' and/or
'make index', as the first field of the resulting line in INDEX-5 is 
bogus:

perforce-,1|/usr/ports/devel/perforce|/usr/local|Perforce client and server|/usr/ports/devel/perforce/pkg-descr|marshall@chezmarshall.com|devel|||http://www.perforce.com/

# portsdb -uf
[Updating the portsdb <format:bdb1_btree> in /usr/ports ... - 11065 port 
entries found 
.........1000.........2000..../usr/ports/INDEX-5:2446:perforce-,1: ,1: Not 
in due form: '<version>[_<revision>][,<epoch>]'.

Fix: 

Maintainer should add correct version info to the port's Makefile.
How-To-Repeat: 
Do a 'portsdb -u' and/or 'make index'.
Comment 1 Pav Lucistnik freebsd_committer freebsd_triage 2004-06-16 20:28:46 UTC 
I propose this patch to silence warning about malformed version string
on unsupported architectures:

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/devel/perforce/Makefile,v
retrieving revision 1.30
diff -a -u -r1.30 Makefile
--- Makefile	26 May 2004 16:24:27 -0000	1.30
+++ Makefile	16 Jun 2004 19:26:39 -0000
@@ -43,6 +43,7 @@
 SBIN_FILES=	p4d
 REL_NOTES=	http://www.perforce.com/perforce/doc.991/user/relnotes.txt
 .else
+VERSION=	0
 IGNORE=		"Unsupported platform, sorry."
 .endif
 
Is maintainer fine with this?

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

Linux is a happy free-for-all chaos.
Comment 2 David Marshall 2004-06-16 21:17:30 UTC 
OK with me.  Thank you for taking care of this.  I don't know enough about 
other architectures to have realized that this was a problem.

Have a nice day.

--On Wednesday, June 16, 2004 21:28 +0200 Pav Lucistnik <pav@FreeBSD.org> 
wrote:

> I propose this patch to silence warning about malformed version string
> on unsupported architectures:
>
> Index: Makefile
> ===================================================================
> RCS file: /home/pcvs/ports/devel/perforce/Makefile,v
> retrieving revision 1.30
> diff -a -u -r1.30 Makefile
> --- Makefile	26 May 2004 16:24:27 -0000	1.30
> +++ Makefile	16 Jun 2004 19:26:39 -0000
> @@ -43,6 +43,7 @@
>  SBIN_FILES=	p4d
>  REL_NOTES=	http://www.perforce.com/perforce/doc.991/user/relnotes.txt
>  .else
> +VERSION=	0
>  IGNORE=		"Unsupported platform, sorry."
>  .endif
>
> Is maintainer fine with this?
>
> --
> Pav Lucistnik <pav@oook.cz>
>               <pav@FreeBSD.org>
>
> Linux is a happy free-for-all chaos.
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2004-06-16 21:31:39 UTC 
State Changed
From-To: open->closed

Committed, thanks!